From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43E4EC3DA6F for ; Fri, 25 Aug 2023 01:04:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nzr02Y1QsFxGxe9skXS9T6e2mrxtw2so/vE8kZL8uNM=; b=BmzswsKGWQUWCw vqyzaxPtznqGW/ClEjM3O/+w/3C2uQwcbA6Um1eAT+uYkuCx+GghXIVWU91K3m1YkP4ObTf+IJaVY Bdws29r4/gSHputyM89H/qEi2h7GvDDTK8PhJU+fxkPGUrvay88uFZwezyetTmNLh/U/5J6Ctje// NqO7h/4UiF9M4Q47M9Oz3d6w4A+vA1MZB4m3wFy6cb/O4jEJBdWDpeSn+nkXmtEy2y+lbc7TTwo3s ETjYOdB302oPT2E0v/mLrYl+coRQ3E4wc3yeULWcLyGRqHCYJa2huPdggM/yEg984FnhhMboxGlHt 2d26Fm6u+TZI062BzncQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qZLFB-0043BI-06; Fri, 25 Aug 2023 01:04:09 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qZLF7-0043Al-17 for linux-arm-kernel@lists.infradead.org; Fri, 25 Aug 2023 01:04:06 +0000 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-68a56ed12c0so76990b3a.0 for ; Thu, 24 Aug 2023 18:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692925443; x=1693530243; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=O78US63FfsQzmACvTjZMokzlCsmaMM4h32+Wp3IzgcU=; b=h/OlHopVZqV0ui3E+m+IdDYT58/fes7lwYYaK/DEj//H9Wh7UqxCKfcYzGZ+ekMJ7f qMPYNqWprGuGccHYWpsbSAU3ToS1t+y84N/nh29EwvJVTmAuBKcdxUePTY99d9xKPPBo p/w6//TXZkPAz83UFrvdmxzoCkPtpuwRYV99jEAB2OnmMCWS+pXSMiQJPQFuVFk4yekP YxWaTdH62vFrGbOZMz7i75GqPS40X50Q0IWJl3LltLg78563BJKSMm305AFnnvYacwjE wKBLEKxnbnzIoqDS1LxK5oNxLIf/O6kqlsT8dCA9GT9AuU1z8wyXU82z4sMpHrrkXy+W XGSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692925443; x=1693530243; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O78US63FfsQzmACvTjZMokzlCsmaMM4h32+Wp3IzgcU=; b=R96m3tQvja6U+I36PwbU9Y2bBLo9RF/mqQGcRXpRDkXADMXaUrFLzym1myAxoAbW5u lH1Qitp+9bYOmqwJKBbJpcxkfgA/onN6zno1D67pzB2D0WlgapxwmjqUFyHoJrb4CNru mQEZW0Vla3+/tDXAyN3rny1HYrff0YJXE/RNM0v8D2gWX2s93peVC6SGy/79aH3tHIh3 8rRSRnME3ggBSVDX0iIWQRgscrqyNbXT9dIHqnN04kNo+zo35rDswGlTpSZT9hadwn2t ornm80wykeBhYjsCijV48C6pSA1+KkB49EZ2Ud77TIuBjrNoAudVWybOuUt+Qx50m/Ck AW/Q== X-Gm-Message-State: AOJu0Yx0haEI6lRjgBkGz41Oh5JxbQqU4vzx797iAIta/+JkJfArr4CA 4hW1QwSIgE1cKGMdcF7xA1mwuw== X-Google-Smtp-Source: AGHT+IFADa9to1oIspLe0Sh5Ftf307VsJJzQgb6brQ/sYjhq0w4KfW8P3TPfT//dHMboCCp5MQcUcQ== X-Received: by 2002:a05:6a21:6da5:b0:137:3eba:b81f with SMTP id wl37-20020a056a216da500b001373ebab81fmr22106910pzb.3.1692925443476; Thu, 24 Aug 2023 18:04:03 -0700 (PDT) Received: from octopus ([2400:4050:c3e1:100:ebbb:f01b:5bbb:8d77]) by smtp.gmail.com with ESMTPSA id g15-20020a1709029f8f00b001b898595be7sm300108plq.291.2023.08.24.18.04.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Aug 2023 18:04:03 -0700 (PDT) Date: Fri, 25 Aug 2023 10:03:59 +0900 From: AKASHI Takahiro To: Oleksii Moisieiev Cc: "sudeep.holla@arm.com" , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" Subject: Re: [PATCH v4 4/4] dt-bindings: firmware: arm,scmi: Add support for pinctrl protocol Message-ID: Mail-Followup-To: AKASHI Takahiro , Oleksii Moisieiev , "sudeep.holla@arm.com" , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" References: <1dcf25b5c6b16b7138534e3c13827287f7c644cf.1691518314.git.oleksii_moisieiev@epam.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1dcf25b5c6b16b7138534e3c13827287f7c644cf.1691518314.git.oleksii_moisieiev@epam.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230824_180405_420967_30A76AC9 X-CRM114-Status: GOOD ( 22.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 08, 2023 at 06:25:36PM +0000, Oleksii Moisieiev wrote: > Add new SCMI v3.2 pinctrl protocol bindings definitions and example. > > Signed-off-by: Oleksii Moisieiev > > --- > Changes v3 -> v4 > - reworked protocol@19 format > --- > .../bindings/firmware/arm,scmi.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 5824c43e9893..5318fe72354e 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -233,6 +233,39 @@ properties: > reg: > const: 0x18 > > + protocol@19: > + type: object > + allOf: > + - $ref: "#/$defs/protocol-node" > + - $ref: "../pinctrl/pinctrl.yaml" Does this rule require that the node name start with "pinctrl" or "pinmux"? If so, it doesn't match with "protocol@19". > + unevaluatedProperties: false > + > + properties: > + reg: > + const: 0x19 > + > + '#pinctrl-cells': > + const: 0 > + > + patternProperties: > + '-pins$': Is this restriction necessary? (Most pinctrl's do so, though.) > + type: object > + allOf: > + - $ref: "../pinctrl/pincfg-node.yaml#" > + - $ref: "../pinctrl/pinmux-node.yaml#" > + unevaluatedProperties: false > + > + description: I think the description may be a bit ambiguous. > + A pin multiplexing sub-node describe how to configure a > + set of pins is some desired function. Even a sub-node that has pin multiplexing definitions may have pin property/parameter definitions. Right? > + A single sub-node may define several pin configurations. Do you not allow for having a sub-node under a sub-node? > + This sub-node is using default pinctrl bindings to configure Does "default pinctrl bindings" refer to "pinctrl-bindings.txt"? Is it necessary to specifically mention it here as it is for client devices? > + pin multiplexing and using SCMI protocol to apply specified Again, not only multiplexing but also pin property/parameters. Thanks, -Takahiro Akashi > + configuration using SCMI protocol. > + > + required: > + - reg > + > additionalProperties: false > > $defs: > @@ -384,6 +417,26 @@ examples: > scmi_powercap: protocol@18 { > reg = <0x18>; > }; > + > + scmi_pinctrl: protocol@19 { > + reg = <0x19>; > + #pinctrl-cells = <0>; > + > + i2c2-pins { > + groups = "i2c2_a", "i2c2_b"; > + function = "i2c2"; > + }; > + > + mdio-pins { > + groups = "avb_mdio"; > + drive-strength = <24>; > + }; > + > + keys_pins: keys-pins { > + pins = "GP_5_17", "GP_5_20", "GP_5_22", "GP_2_1"; > + bias-pull-up; > + }; > + }; > }; > }; > > -- > 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel