From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 378BEC83F10 for ; Sun, 27 Aug 2023 10:33:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H+wi9kyNiYkb+rAF9MyGScbDjqTYSmnH3d7Ky1IUC5o=; b=l0lM43gPEKPpqN nFJHdv0Jz1qxrStLG1iWVzBLNVEEFtpnaTY78RbkqZOPHkqT6xhsuJPCNN/RexBuO9cdkML8Kytcv JFmsI+xeKNqcjAJUhP+2ytPkGcmbOyrSYL5FalWiT1snhQ/l+wr52Xk/p3OW60bhDpUShkBdKn/XQ xxed4/QEgy8Rw8cfLoDtkG8neWWnGHHHIME0AOAe0Gmtxc9gjPF4DAIpmJ2V0iGFfxzEOitxsaTSu oG5ukyo67LbQzmtEgAkw3NaWjI1Kou9d7Vg/jge3N1V5lBldBK66mHIAVhGDpZI9h23U7AAxWzx+b BKqOaoPwbfwYWq5lYxfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qaD53-007wcY-2D; Sun, 27 Aug 2023 10:33:17 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qaD4z-007wcA-3A for linux-arm-kernel@lists.infradead.org; Sun, 27 Aug 2023 10:33:15 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4CF73614A5; Sun, 27 Aug 2023 10:33:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92221C433C7; Sun, 27 Aug 2023 10:33:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693132392; bh=sANaBJsu9MUxCeR6mbhC5kK4bakw14h8fZPDowZ0meU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EdKYS1aqAbXFiwMK8pIiuhUolMTeJRjBG9Ol6nxWZEafNvirjc+JaCogW62ODu7z/ UFtIp048CA9PEfVeyF4xkzCR4yQb8TIW7SSCmhCXwWzBE1Bl1HfbEoZAHTcDgmEtG7 99EuMzJh0sehI2y0AkTwqMqEDKkmwQJbwnsAOh38zWoFAYqbYdGWzuqKgHihtCs3gI QeUZQPIDmuZxz/nHixiDwqvk/sJgbsJ/zrrcykWlokEgAaDlV2gYwjW6lts6+cemhO FYrgmnZLRk9npHpnJTeLDnH/Ojyqo7fE87+KGQIfWxdWhKTrATQ7FIw/3mVmW/NI0/ ADdYIiUqc+kqg== Date: Sun, 27 Aug 2023 18:21:25 +0800 From: Jisheng Zhang To: Geert Uytterhoeven Cc: Linus Walleij , Sebastian Hesselbarth , Antoine Tenart , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] pinctrl: berlin: Drop superfluous ampersands Message-ID: References: <0ff17be9b31c9fcf03481c0665293b98ced741f7.1692871243.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0ff17be9b31c9fcf03481c0665293b98ced741f7.1692871243.git.geert+renesas@glider.be> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230827_033314_714716_54EFD887 X-CRM114-Status: GOOD ( 17.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 24, 2023 at 12:05:50PM +0200, Geert Uytterhoeven wrote: > There is no need to use an ampersand to take the address of a function. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Jisheng Zhang Hi Linus Walleij, If it's not too late, could you please merge it? Thanks in advance > --- > drivers/pinctrl/berlin/berlin.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berlin.c > index 1e427ea4d31bcbfc..9550cc8095c28720 100644 > --- a/drivers/pinctrl/berlin/berlin.c > +++ b/drivers/pinctrl/berlin/berlin.c > @@ -96,10 +96,10 @@ static int berlin_pinctrl_dt_node_to_map(struct pinctrl_dev *pctrl_dev, > } > > static const struct pinctrl_ops berlin_pinctrl_ops = { > - .get_groups_count = &berlin_pinctrl_get_group_count, > - .get_group_name = &berlin_pinctrl_get_group_name, > - .dt_node_to_map = &berlin_pinctrl_dt_node_to_map, > - .dt_free_map = &pinctrl_utils_free_map, > + .get_groups_count = berlin_pinctrl_get_group_count, > + .get_group_name = berlin_pinctrl_get_group_name, > + .dt_node_to_map = berlin_pinctrl_dt_node_to_map, > + .dt_free_map = pinctrl_utils_free_map, > }; > > static int berlin_pinmux_get_functions_count(struct pinctrl_dev *pctrl_dev) > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel