From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BD2EC83F10 for ; Thu, 31 Aug 2023 10:15:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P9Mexzace6wC9uRAXiGSqfttdghurwLqyz9WBHg/GEQ=; b=wrK+CzBwh7PV8/ ahEQ7zZ67pLGj86fEs4tp+rImIEVu82DIdRQSRI3TrFhhtMbpRhzEN4Tkju7T/r5Kz782N7m0mR4c Kom47f+jN9+l5xILEVRpzkT96NpsLxcBbHJMPXXB9AG1T9vRg/MQfApGiVNsBuZ6ep+6YhmcEsH3w oN0NI+PdRYfut9jPAQBtp/UWNlXLjeEpuHOzGwTTgBNq1Tu2LpKWBg4M5NYmlWyxN8cHmknjGhXz8 VNuYvUIY3t/+wjrLudqVW4AXP05mE7zB3vyy2DXm1q2tRpp3yqoqZyaeFT9Ef0bD8p98+zcjd1PiQ +ythTlPG+m2FrNZerPqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbehz-00EzxM-0b; Thu, 31 Aug 2023 10:15:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbehw-00EzwL-0Z for linux-arm-kernel@lists.infradead.org; Thu, 31 Aug 2023 10:15:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 187F7C15; Thu, 31 Aug 2023 03:16:01 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.3.201]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 42A9D3F64C; Thu, 31 Aug 2023 03:15:18 -0700 (PDT) Date: Thu, 31 Aug 2023 11:15:15 +0100 From: Mark Rutland To: Douglas Anderson Cc: Catalin Marinas , Will Deacon , Sumit Garg , Daniel Thompson , Marc Zyngier , linux-arm-kernel@lists.infradead.org, Masayoshi Mizuma , "Rafael J . Wysocki" , Chen-Yu Tsai , Lecopzer Chen , Tomohiro Misono , Stephane Eranian , kgdb-bugreport@lists.sourceforge.net, Peter Zijlstra , Thomas Gleixner , Stephen Boyd , ito-yuichi@fujitsu.com, linux-perf-users@vger.kernel.org, Ard Biesheuvel , D Scott Phillips , Josh Poimboeuf , Valentin Schneider , linux-kernel@vger.kernel.org Subject: Re: [PATCH v12 7/7] arm64: smp: Mark IPI globals as __ro_after_init Message-ID: References: <20230830191314.1618136-1-dianders@chromium.org> <20230830121115.v12.7.I625d393afd71e1766ef73d3bfaac0b347a4afd19@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230830121115.v12.7.I625d393afd71e1766ef73d3bfaac0b347a4afd19@changeid> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230831_031524_263699_B572A8DE X-CRM114-Status: GOOD ( 22.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 30, 2023 at 12:11:28PM -0700, Douglas Anderson wrote: > Mark the three IPI-related globals in smp.c as "__ro_after_init" since > they are only ever set in set_smp_ipi_range(), which is marked > "__init". This is a better and more secure marking than the old > "__read_mostly". > > Suggested-by: Stephen Boyd > Signed-off-by: Douglas Anderson > --- > This patch is almost completely unrelated to the rest of the series > other than the fact that it would cause a merge conflict with the > series if sent separately. I tacked it on to this series in response > to Stephen's feedback on v11 of this series [1]. If someone hates it > (not sure why they would), it could be dropped. If someone loves it, > it could be promoted to the start of the series and/or land on its own > (resolving merge conflicts). > > [1] https://lore.kernel.org/r/CAE-0n52iVDgZa8XT8KTMj12c_ESSJt7f7A0fuZ_oAMMqpGcSzA@mail.gmail.com This looks reasonable to me, so: Acked-by: Mark Rutland Mark. > > Changes in v12: > - ("arm64: smp: Mark IPI globals as __ro_after_init") new for v12. > > arch/arm64/kernel/smp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > index 1a53e57c81d0..814d9aa93b21 100644 > --- a/arch/arm64/kernel/smp.c > +++ b/arch/arm64/kernel/smp.c > @@ -84,9 +84,9 @@ enum ipi_msg_type { > MAX_IPI > }; > > -static int ipi_irq_base __read_mostly; > -static int nr_ipi __read_mostly = NR_IPI; > -static struct irq_desc *ipi_desc[MAX_IPI] __read_mostly; > +static int ipi_irq_base __ro_after_init; > +static int nr_ipi __ro_after_init = NR_IPI; > +static struct irq_desc *ipi_desc[MAX_IPI] __ro_after_init; > > static void ipi_setup(int cpu); > > -- > 2.42.0.283.g2d96d420d3-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel