From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: gregory.greenman@intel.com, kvalo@kernel.org,
briannorris@chromium.org, nbd@nbd.name, lorenzo@kernel.org,
ryder.lee@mediatek.com, shayne.chen@mediatek.com,
sean.wang@mediatek.com, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, avraham.stern@intel.com,
johannes.berg@intel.com, emmanuel.grumbach@intel.com,
trix@redhat.com, dmantipov@yandex.ru,
christophe.jaillet@wanadoo.fr, yangyang@marvell.com,
linville@tuxdriver.com, rramesh@marvell.com, akarwar@marvell.com,
nishants@marvell.com, linux-wireless@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net 0/3] wifi: Fix the NULL vs IS_ERR() bugs for debugfs_create_dir()
Date: Thu, 31 Aug 2023 15:17:44 +0100 [thread overview]
Message-ID: <ZPChCNLPMQiRrVU5@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230831141347.3166988-1-ruanjinjie@huawei.com>
On Thu, Aug 31, 2023 at 10:13:44PM +0800, Jinjie Ruan wrote:
> Since debugfs_create_dir() returns ERR_PTR and never return NULL, So use
> IS_ERR() to check it instead of checking NULL.
It is preferred that the return value from debugfs functions is _not_
checked.
See for example:
https://lore.kernel.org/linux-arm-kernel/20180601111004.1670-3-gregkh@linuxfoundation.org/T/
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-31 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 14:13 [PATCH net 0/3] wifi: Fix the NULL vs IS_ERR() bugs for debugfs_create_dir() Jinjie Ruan
2023-08-31 14:13 ` [PATCH net 1/3] wifi: iwlwifi: mei: Fix the NULL vs IS_ERR() bug " Jinjie Ruan
2023-08-31 14:13 ` [PATCH net 2/3] mwifiex: debugfs: " Jinjie Ruan
2023-08-31 14:13 ` [PATCH net 3/3] wifi: mt76: " Jinjie Ruan
2023-08-31 14:17 ` Russell King (Oracle) [this message]
2023-08-31 15:27 ` [PATCH net 0/3] wifi: Fix the NULL vs IS_ERR() bugs " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPChCNLPMQiRrVU5@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=akarwar@marvell.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avraham.stern@intel.com \
--cc=briannorris@chromium.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmantipov@yandex.ru \
--cc=emmanuel.grumbach@intel.com \
--cc=gregory.greenman@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=nishants@marvell.com \
--cc=rramesh@marvell.com \
--cc=ruanjinjie@huawei.com \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
--cc=trix@redhat.com \
--cc=yangyang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).