From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9004ECA0FE2 for ; Thu, 31 Aug 2023 23:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2hcPBhdOBgeIaAOVuGlFqlDaiu64aVHABBU9yp3v+H4=; b=xylrvb8gPwfZMF LPL5Y+qJtlqprMThG92JQBT+x7Qyv8jU2B+Yrgin9H9YK5U4VYhJ+vep+xTm4MclGDT61NHwW9fY1 DtcQSBvpQI/19cMfQq4uZanJLq58HJJ942tbAZ+py3cKw3rR9qteYxCxVI33ZzYjJ/BUXwjFQ03wx 0XMStW1mmLPQ8dibbHxIPPVNi6FTr2yyijP7A9RkP/TMnji5WZJAGmA/inDYm2LSR2Tyo2d2GsemX +YjAMehVUEtUbpdrov9qAl9Zwe4qOaV6hx0LLC/GP/C623LWJf3WCLL8LCzpCEsoZ00g0LGP1tdF8 eRbk4IAdiSSofwD4Zdkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbr2F-00FxYp-1J; Thu, 31 Aug 2023 23:25:11 +0000 Received: from mgamail.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qbr2B-00FxY8-0X; Thu, 31 Aug 2023 23:25:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693524307; x=1725060307; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Z+i7hqSDClaxEdZAuo9sNl0FYXSUAPr3Xs/8KN7dhc8=; b=CFoS2MGyTmda1wHwxx0j8RUyb8kg1Soge+sPb0TEVufxkfbq+oFFoJF4 KDXssaVGRKDXi5ndbmOcsBT9v7dFHVWNwCSRi2MfnJGOKt0C/auzGie+5 gsTgbVcHLDKiIng5BUOlxFUWhTYUW8Tt2OrVJBIYZbv8WiAxy0NTPKqTm 539dzUkwI/oulR5fTsyNVgd60CURZ/B5XXsAqzhG3oMRXGJnRyaXHnP63 jFF4VK9ZoULzb/6jWHlF5dZG/MPft39UCj70z0+1lN6Ctf84TLzQveQkI vmq0QXZXXdFacrU5nFa/fyYyHocaS7BFrG3biOLsO75A4DKgms0unhuRO w==; X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="366317573" X-IronPort-AV: E=Sophos;i="6.02,218,1688454000"; d="scan'208";a="366317573" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2023 16:25:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="829904226" X-IronPort-AV: E=Sophos;i="6.02,218,1688454000"; d="scan'208";a="829904226" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2023 16:25:02 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qbr23-005WmK-1D; Fri, 01 Sep 2023 02:24:59 +0300 Date: Fri, 1 Sep 2023 02:24:59 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Mark Brown , Florian Fainelli , Linus Walleij , Ray Jui , Scott Branden , Broadcom internal kernel review list , linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski Subject: Re: [RFT PATCH] spi: bcm2835: reduce the abuse of the GPIO API Message-ID: References: <20230831194934.19628-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230831194934.19628-1-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230831_162507_253543_2A0302D8 X-CRM114-Status: GOOD ( 17.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 31, 2023 at 09:49:34PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Currently the bcm2835 SPI driver uses functions meant for GPIO providers > exclusively to locate the GPIO chip it gets its CS pins from and request > the relevant pin. I don't know the background and what bug forced this. ... > /* > + * TODO: The code below is a slightly better alternative to the utter > + * abuse of the GPIO API that I found here before. It creates a > + * temporary lookup table, assigns it to the SPI device, gets the GPIO > + * descriptor and then releases the lookup table. > * > + * Still the real problem is unsolved. Looks like the cs_gpiods table > + * is not assigned correctly from DT? > */ I'm not sure why this quirk is here. AFAIR the SPI CS quirks are located in gpiolib-of.c. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel