From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CF27C83F2C for ; Tue, 5 Sep 2023 16:32:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=itzdmvoQEPD8jyi3zCcHFuSAl99wa+hVHsv/WNFvy4A=; b=gYErjcW6cRpKcVo3CHHYOSY/Ha rXtzG9T/gl21R/wRGC3gpEeCa/YAKh7oP4T6wsdipTEax0aNCnOJGLIZkydHupq3K6KdJSWS4iLCR So3CenNJ4ACr9xZ8VfCIBGqzEYw52kDGGgHB70cYVJgBmrX38wBKixDIQtI9p62cFGoqNPUXq/9Nc U+1lb3QRUjboiwNYT9G3RLAhhZBDNbZ7FCYtu0OnTixYyKPiSnOSDIJq5z1qwFpuCUC+2HpriivFB IBtvw0mIkRHXdClk2CoCqiC6rns0ApM1WuhmbLOKjUMSjjAWphJeQHBPjuBcGkrjwhSksYe2dajJg k+lJcy2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdYyc-006Mfe-0C; Tue, 05 Sep 2023 16:32:30 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdYyZ-006Mf6-1F for linux-arm-kernel@lists.infradead.org; Tue, 05 Sep 2023 16:32:28 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A2018CE0EF6; Tue, 5 Sep 2023 16:32:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF28CC433C7; Tue, 5 Sep 2023 16:32:18 +0000 (UTC) Date: Tue, 5 Sep 2023 12:32:16 -0400 From: William Breathitt Gray To: Dharma Balasubiramani Subject: Re: [linux][PATCH] counter: microchip-tcb-capture: Fix the use of internal GCLK logic Message-ID: References: <20230905100835.315024-1-dharma.b@microchip.com> MIME-Version: 1.0 In-Reply-To: <20230905100835.315024-1-dharma.b@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230905_093227_626973_E8D1F029 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kamel.bouhara@bootlin.com, linux-iio@vger.kernel.org, balamanikandan.gunasundar@microchip.com, linux-kernel@vger.kernel.org, hari.prasathge@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============4932674596017103472==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4932674596017103472== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IBs/xuK4vyQAAN/S" Content-Disposition: inline --IBs/xuK4vyQAAN/S Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 05, 2023 at 03:38:35PM +0530, Dharma Balasubiramani wrote: > As per the datasheet, the clock selection Bits 2:0 =E2=80=93 TCCLKS[2:0] = should > be set to 0 while using the internal GCLK (TIMER_CLOCK1). >=20 > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") > Signed-off-by: Dharma Balasubiramani > --- > drivers/counter/microchip-tcb-capture.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/mi= crochip-tcb-capture.c > index e2d1dc6ca668..c7af13aca36c 100644 > --- a/drivers/counter/microchip-tcb-capture.c > +++ b/drivers/counter/microchip-tcb-capture.c > @@ -98,7 +98,7 @@ static int mchp_tc_count_function_write(struct counter_= device *counter, > priv->qdec_mode =3D 0; > /* Set highest rate based on whether soc has gclk or not */ > bmr &=3D ~(ATMEL_TC_QDEN | ATMEL_TC_POSEN); > - if (priv->tc_cfg->has_gclk) > + if (!priv->tc_cfg->has_gclk) > cmr |=3D ATMEL_TC_TIMER_CLOCK2; > else > cmr |=3D ATMEL_TC_TIMER_CLOCK1; > --=20 > 2.25.1 Applied to counter-fixes as commit df8fdd01c98b. Thanks, William Breathitt Gray --IBs/xuK4vyQAAN/S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZPdYEAAKCRC1SFbKvhIj K1MKAP9E6JRTEYYf67ux4TBjDQjMrZOTu5kghFg/hzzk6Q0BhwD/cdGiI//RMHXq Q4EZXZ0BJFEs6FAi8zbtNOAf4XXS7QI= =lPuS -----END PGP SIGNATURE----- --IBs/xuK4vyQAAN/S-- --===============4932674596017103472== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4932674596017103472==--