From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Vladimir Zapolskiy <vz@mleia.com>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] pwm: lpc32xx: remove handling of PWM channels
Date: Wed, 6 Sep 2023 16:26:40 +0200 [thread overview]
Message-ID: <ZPiMILkEznOJNTU-@orome> (raw)
In-Reply-To: <20230906094730.w2igbdq75jms266o@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1447 bytes --]
On Wed, Sep 06, 2023 at 11:47:30AM +0200, Uwe Kleine-König wrote:
> Hello Thierry,
>
> On Fri, Jul 28, 2023 at 11:23:29AM +0200, Uwe Kleine-König wrote:
> > On Mon, Jul 24, 2023 at 04:00:32PM +0200, Uwe Kleine-König wrote:
> > > As noted by Dan Carpenter in
> > > https://lore.kernel.org/linux-pwm/919cac5d-491e-4534-baed-bf813181192d@moroto.mountain
> > > lpc32xx->chip.pwms is NULL before devm_pwmchip_add() is called so this
> > > patch fixes a null pointer exception.
> > >
> > > Maybe add the following to the commit log:
> > >
> > > Even though I wasn't aware at the time when I forward ported that patch,
> > > this fixes a null pointer dereference as lpc32xx->chip.pwms is NULL
> > > before devm_pwmchip_add() is called.
> > >
> > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > > Fixes: 3d2813fb17e5 ("pwm: lpc32xx: Don't modify HW state in .probe() after the PWM chip was registered")
> >
> > You (probably with b4's help) picked up the Fixes line. The description
> > and also the Reported-by was not picked up, though.
> >
> > IMHO adding the missed bits would be beneficial.
>
> I'd consider it important that this is added before you send the PR to
> Linus for this cycle. Is this still on your radar?
This has been in the for-next branch for a few weeks now. Can you check
and let me know it's what you expect? I was planning on sending the PR
today or tomorrow.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-09-06 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 15:52 [PATCH] pwm: lpc32xx: remove handling of PWM channels Uwe Kleine-König
2023-07-28 8:16 ` Thierry Reding
[not found] ` <20230724140032.g7vriv72uuvxbohd@pengutronix.de>
2023-07-28 9:23 ` Uwe Kleine-König
2023-09-06 9:47 ` Uwe Kleine-König
2023-09-06 14:26 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPiMILkEznOJNTU-@orome \
--to=thierry.reding@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox