On Wed, Sep 06, 2023 at 11:47:30AM +0200, Uwe Kleine-König wrote:
> Hello Thierry,
> 
> On Fri, Jul 28, 2023 at 11:23:29AM +0200, Uwe Kleine-König wrote:
> > On Mon, Jul 24, 2023 at 04:00:32PM +0200, Uwe Kleine-König wrote:
> > > As noted by Dan Carpenter in
> > > https://lore.kernel.org/linux-pwm/919cac5d-491e-4534-baed-bf813181192d@moroto.mountain
> > > lpc32xx->chip.pwms is NULL before devm_pwmchip_add() is called so this
> > > patch fixes a null pointer exception.
> > > 
> > > Maybe add the following to the commit log:
> > > 
> > > 	Even though I wasn't aware at the time when I forward ported that patch,
> > > 	this fixes a null pointer dereference as lpc32xx->chip.pwms is NULL
> > > 	before devm_pwmchip_add() is called.
> > > 
> > > 	Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > > 	Fixes: 3d2813fb17e5 ("pwm: lpc32xx: Don't modify HW state in .probe() after the PWM chip was registered")
> > 
> > You (probably with b4's help) picked up the Fixes line. The description
> > and also the Reported-by was not picked up, though.
> > 
> > IMHO adding the missed bits would be beneficial.
> 
> I'd consider it important that this is added before you send the PR to
> Linus for this cycle. Is this still on your radar?

This has been in the for-next branch for a few weeks now. Can you check
and let me know it's what you expect? I was planning on sending the PR
today or tomorrow.

Thierry