From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 763DFEB8FD6 for ; Wed, 6 Sep 2023 14:27:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WZqJqm6uUll8WOIb7YH1jjLDdr+tmIvEg3Fe2DRxBUM=; b=ReBAyJb6y7fHnRf9apC5h2NAYx RY4hpP85RQqS+kdMuGre62Qn0UsZiEHQZ8VcgdhI4ZBH0W2g1a9+U3Vd13ObSofQeswQnK6NA5S3j THgL8lZpG1gpZSCWQGqQ8XAprQAr2cLLOX7aGLr7zEkxEoAwAUMi7sgB9vAM9ozaH46eJvE6rBNDX Gjm9ItPib1958IQA4MZV9ZQlYIEqdMgTEeXbHoqvH/xgydfsuAweVvSiOG1d2PULv7bPcDOdPvm48 WQuPAlUbdcHQt+tlODKXPJ/K+tf5N4qtmPU+5mRGvI068+hd5yaC4ZPhftC1I1oGz6udMxseGsGfU 9elF7W+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdtUY-00AFhm-0I; Wed, 06 Sep 2023 14:26:50 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdtUU-00AFgT-1h for linux-arm-kernel@lists.infradead.org; Wed, 06 Sep 2023 14:26:48 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-52a40cf952dso5282719a12.2 for ; Wed, 06 Sep 2023 07:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694010403; x=1694615203; darn=lists.infradead.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Bs+W/u3S403yXjxn4vONJBldMdIB4gft+2a5Itd2PCo=; b=C2+gGqIbAl6lcE8YWNeh8hueDdqcY457xfdM6GOBOJI/tyX4le2FzJeHV2bR84DrHZ gdWiadReCE5lL33RE46ieTsBcgeicysqonhG0L++3WPcIzcKdIOm5o7ndHZspmZn2ENH QNm6FW7EPruGpXwKbd8mL+CS6szTdjn+nJUZVKEIFNFM2bCXSy6zxlja6zQQGaFvXG9r NTiVtbUcx8So8R+8t0YjEeGiwJgaKPqnBeeTsVThWe4yVUvNOhJe61dYrZUJsmyPSU0C PQGKny3lcXoW1hpRoOAQqls3/JynkqEieiRwloXfGfsK0MRrj7p/CZ+FD0nhzIwGwXZD d+pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694010403; x=1694615203; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bs+W/u3S403yXjxn4vONJBldMdIB4gft+2a5Itd2PCo=; b=B8tSloYA2IVunER//8gVkLjXJHgwEo1WEvYqZjXY9lfUNRSHG9uptQfVbp72vESIZB drqyFXpWJC3rBXIPZpaN94MSb+r292vTdwcf3uhj6kxMuOmvwCrXWZk9gC9sZwRpZH8P ox197uRc03HQYws5yXFyYlF9c6iL6G8v1Nirc2TssUkYwGvf6tRFYEKZWUGzFwJslByN lFPz5UprlXgNbHGLvdfv0WQQAhrHtCqyT9lYIgz+kYTbaMr3fO99jqwMNWwLhpys7ivM QIW2jXrvKUxMlVeP+DD9rsNE6wPCvS3dsH8s05aBpJjqckzPTM+v69QM/QElr9gh5q18 wgKQ== X-Gm-Message-State: AOJu0YyXeO6RgoDohPEhDHrkMos1uLWH1KIGOnd+YFqc2faY20awwRLz 2CQd53DJdidjH0AKAg4d59w= X-Google-Smtp-Source: AGHT+IF6yELDWL5gXf9ZQS/BjPUPQf9FVvfGolbQodzw2JzBpbVPRcUiKR4rr3p0Dszz66QmhnqGQA== X-Received: by 2002:a05:6402:608:b0:525:6ab3:dd22 with SMTP id n8-20020a056402060800b005256ab3dd22mr2660080edv.38.1694010402706; Wed, 06 Sep 2023 07:26:42 -0700 (PDT) Received: from orome (p200300e41f1bd600f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f1b:d600:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id g10-20020aa7c58a000000b005227e53cec2sm8491122edq.50.2023.09.06.07.26.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 07:26:41 -0700 (PDT) Date: Wed, 6 Sep 2023 16:26:40 +0200 From: Thierry Reding To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Vladimir Zapolskiy , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dan Carpenter Subject: Re: [PATCH] pwm: lpc32xx: remove handling of PWM channels Message-ID: References: <20230717155257.2568627-1-u.kleine-koenig@pengutronix.de> <20230724140032.g7vriv72uuvxbohd@pengutronix.de> <20230728092329.i43omkxgkryui6ku@pengutronix.de> <20230906094730.w2igbdq75jms266o@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20230906094730.w2igbdq75jms266o@pengutronix.de> User-Agent: Mutt/2.2.10 (2023-03-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230906_072646_593909_B66BB7A4 X-CRM114-Status: GOOD ( 25.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8569453050443388144==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8569453050443388144== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QkR731jkCIIdfmCv" Content-Disposition: inline --QkR731jkCIIdfmCv Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 06, 2023 at 11:47:30AM +0200, Uwe Kleine-K=C3=B6nig wrote: > Hello Thierry, >=20 > On Fri, Jul 28, 2023 at 11:23:29AM +0200, Uwe Kleine-K=C3=B6nig wrote: > > On Mon, Jul 24, 2023 at 04:00:32PM +0200, Uwe Kleine-K=C3=B6nig wrote: > > > As noted by Dan Carpenter in > > > https://lore.kernel.org/linux-pwm/919cac5d-491e-4534-baed-bf813181192= d@moroto.mountain > > > lpc32xx->chip.pwms is NULL before devm_pwmchip_add() is called so this > > > patch fixes a null pointer exception. > > >=20 > > > Maybe add the following to the commit log: > > >=20 > > > Even though I wasn't aware at the time when I forward ported that pa= tch, > > > this fixes a null pointer dereference as lpc32xx->chip.pwms is NULL > > > before devm_pwmchip_add() is called. > > >=20 > > > Reported-by: Dan Carpenter > > > Fixes: 3d2813fb17e5 ("pwm: lpc32xx: Don't modify HW state in .probe(= ) after the PWM chip was registered") > >=20 > > You (probably with b4's help) picked up the Fixes line. The description > > and also the Reported-by was not picked up, though. > >=20 > > IMHO adding the missed bits would be beneficial. >=20 > I'd consider it important that this is added before you send the PR to > Linus for this cycle. Is this still on your radar? This has been in the for-next branch for a few weeks now. Can you check and let me know it's what you expect? I was planning on sending the PR today or tomorrow. Thierry --QkR731jkCIIdfmCv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmT4jB0ACgkQ3SOs138+ s6HvaxAAgsxePyU8FbfUk7b9Su6ev2Mcj0QVBWN+lhqt8MXF+k16wotqJEPNc4Ec NeXLF5KIo6EnNX0DEmHMNEyynroZpmfeRMi4CJ5jC28rUKGjJr/di78Fw4cGSd/J ZDIDTzje6IYnaRs3UiDs4yvQjNaQrnQgMmU0FKqsb2L43BhaVws8U7a8p3Iqxyvu bh/jECxSz8Po6GxfvCzi3QlNVebUPDEar4DG67JfRqgZKXiMDz20u8EPel6Aj+JV w7S5dIiM+D+Mvj/HD3vlc25vNdbmSqkOilKHkz/dJIX5exYlv/nl4NomJHBzSpSr aPU3qNEL+ROCwzJ2lf4daHC3O4vg3qzX4rFdBW6h2+5pr1lcehG0cp8dmyxy2e1M b3Psvo5xjHlzg5xgRZVe7pwz5WAZDL3hT0BRtoQVHJkvHlrHELSpGSF4ob/t+wFr GTVKyw69OZz5eGjvwCE8gGE+7h2zPmtSawsFJnbWBV2gFflNa8+coY/omFqz+HBW R8jZqDE+rMoeRWfRWHmYfPjed8CxinF4QIa48TabRvCjtNjwRIH0qoED1cfv4kyX WFUMcFo87F7aj8/goj8iBMQ8j9zv36w6Gc+T153ZQnk2B9NOpr77AqM5sNuYkLdq 6aVfWFwHvQj2M+Q6RU0h9nuRUxhDoezXSe6dje/fZPDT3fQOAe8= =mBL5 -----END PGP SIGNATURE----- --QkR731jkCIIdfmCv-- --===============8569453050443388144== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8569453050443388144==--