From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4696CEE14A0 for ; Wed, 6 Sep 2023 14:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OxPv4Jb+sfA333bnwh2nvkSeqZI7TWwos5GQj/jLj0E=; b=YNyvSRPFBlunR8 D+U1g5f1tp3nP52rDg1L8DGDuXdINux+/+RJsgaE35tYFKcClpsZz/QGBZHxYewMDjc9Kd7xzogMU 7zke64d4r+UHd++ClS3riyE/WCWs8yBXJhU7IZX/OQG0Gz8DKBOzOix2dSeUVLXgIEtT+4eyFIQjr xwXAZaoDy2p7bIScFdy+EplyPric23SSDeg9uePYHjpSd3pt6FcbRN2/58E4ZP8z233qfKZZpRjj9 3Ndb8wbukccCR3VcLnn3bp8TBoXiU0wgVBLEjuaU74C3DqveJV0jrQdKXFfrN29nzf3u8jLoYiNZn 5zpzev0Xvl2RqrgcRwYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdttZ-00AKBQ-1E; Wed, 06 Sep 2023 14:52:41 +0000 Received: from mgamail.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdttW-00AK8c-0i for linux-arm-kernel@lists.infradead.org; Wed, 06 Sep 2023 14:52:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694011958; x=1725547958; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=inkf0Vv2sw3e1+dq2vxBlduL5A9wIEDv+hfvFclNOlw=; b=IeS0ZOURsmSN6ubFaMeqHCPqTh9oUPs1jyaVVC4LzHBTc8DAOkZI8mg8 p2yUcSrwgP+j6/8LQ8DQgfVCnUBeKwQH1/oPYKV6Jfn8Az8QajZgAV1QP H6Wy+4F52P4e2sdYD4lamQpYOY0QpCHzg+UAEVedg+T2iE9mlFnA2eeua GJpjc2ckTJ/LPVZ93LXCQ7TGv4Szzl+CJzlSY9kGxcE9AHCNkepuEQt2s 8fZ+0R6k/Q1X35nBqXABRlOS+4ZP/u6/oBd2ns3qNJEhhGgfbBi82wYqY a8L+js7UOArM5cmEhvBt/a9aZlpKX+7ekZcR0mKyWpZmchc2P1gxsGuyY Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10825"; a="362116761" X-IronPort-AV: E=Sophos;i="6.02,232,1688454000"; d="scan'208";a="362116761" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2023 07:52:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10825"; a="735086303" X-IronPort-AV: E=Sophos;i="6.02,232,1688454000"; d="scan'208";a="735086303" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2023 07:52:29 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qdttJ-006y5B-3D; Wed, 06 Sep 2023 17:52:26 +0300 Date: Wed, 6 Sep 2023 17:52:25 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Mika Westerberg , Linus Walleij , Dipen Patel , Thierry Reding , Jonathan Hunter , Hans de Goede , Mark Gross , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, timestamp@lists.linux.dev, linux-tegra@vger.kernel.org, platform-driver-x86@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 19/21] gpio: swnode: replace gpiochip_find() with gpio_device_find_by_label() Message-ID: References: <20230905185309.131295-1-brgl@bgdev.pl> <20230905185309.131295-20-brgl@bgdev.pl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230905185309.131295-20-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230906_075238_322136_BF5CB719 X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 05, 2023 at 08:53:07PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We're porting all users of gpiochip_find() to using gpio_device_find(). > Update the swnode GPIO code. ... > -static int swnode_gpiochip_match_name(struct gpio_chip *chip, void *data) > +static struct gpio_device *swnode_get_gpio_device(struct fwnode_handle *fwnode) > { > - return !strcmp(chip->label, data); > -} > + const struct software_node *gdev_node; > + struct gpio_device *gdev; > > -static struct gpio_chip *swnode_get_chip(struct fwnode_handle *fwnode) > -{ Not sure if you used --patience. Patches might look better. > - const struct software_node *chip_node; > - struct gpio_chip *chip; > - > - chip_node = to_software_node(fwnode); > - if (!chip_node || !chip_node->name) > + gdev_node = to_software_node(fwnode); > + if (!gdev_node || !gdev_node->name) > return ERR_PTR(-EINVAL); > > - chip = gpiochip_find((void *)chip_node->name, swnode_gpiochip_match_name); > - return chip ?: ERR_PTR(-EPROBE_DEFER); > + gdev = gpio_device_find_by_label((void *)gdev_node->name); > + return gdev ?: ERR_PTR(-EPROBE_DEFER); > } ... > - desc = gpiochip_get_desc(chip, args.args[0]); > + desc = gpiochip_get_desc(gdev->chip, args.args[0]); gpio_device_get_desc() ? -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel