From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52D8CCD4F4A for ; Fri, 22 Sep 2023 10:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YJIcgmjGkiGBTDQ5fTU57/37FhtBZ6UJVuZkA4yfZsE=; b=wafpd+A9aS29aloz/WV0Hoyfil 5GE9beim6VLxI80t9+sIT157XjzhqYiH9xqchjLXD/tSQPJwazdAtdTosFq4YK6YY8k3M2hGfvVVv LI/uT3XEZSkaSskbmaneiqWPISKx6Vfyj2ri3Av8rf8Efr1P1Ya6lToir5aiL9cBOXITQCZlMZlr5 d5D0hBOGzGaCBB6Mt1CxRaYdTRvWTtX3qQ6t3Wr05vrsvPAPIMiHxNHcZ1mpRlIYCc7yFjNqeV/7w FOFOCMUAaiKEFoG7IhvY3EB7DV6Bs8+MHXm0xzARrgwb6SxMNWr5do0eW0IwxH6rU/5i1zmBfjvMl vZOClLlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjd4V-008gF8-1p; Fri, 22 Sep 2023 10:07:39 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qjd4T-008gE8-13 for linux-arm-kernel@lists.infradead.org; Fri, 22 Sep 2023 10:07:38 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6D052B822CE; Fri, 22 Sep 2023 10:07:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89215C433C8; Fri, 22 Sep 2023 10:07:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695377254; bh=61yyli1b+TB36mlGU4MRImwKwe43A3AAFbw7HbiYo4Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K8NOjXQLNypTx+lKv2KhF5D44R/8w70MEIogcZl4us0wCpgrmQRD12KjxTLIwb+o4 Q/nUORUqS5UfSA/SsE3qmQhtVikxtJr5sHRELvdWE5o9mE9lkS0avlEA5btZzaU7hO gbKa1euKiVDs6NKQ3htpkuWyd4I2AcXH77Wx8/kh4mz7wPFrlCG3Ld3mcHHL/vulUg 7NhINzWTa9rcckjezTJlOy1fSHqZDAaGBlH08fI9E13pnrYIrtzX0v7bJkyPlicRUH 6T2opBqElK4lnQV7+uMio9NXBbVW0JAE7vqeznShaaCCXDoCU452vh5Le7QZr+LFPk 5XWpUXptqdFRw== Date: Fri, 22 Sep 2023 12:07:30 +0200 From: Wolfram Sang To: Daniel Scally Cc: Michal Simek , Andi Shyti , Shubhrajyoti Datta , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, Raviteja Narayanam Subject: Re: [PATCH] i2c: xiic: Correct return value check for xiic_reinit() Message-ID: Mail-Followup-To: Wolfram Sang , Daniel Scally , Michal Simek , Andi Shyti , Shubhrajyoti Datta , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, Raviteja Narayanam References: <20230920134109.2232769-1-dan.scally@ideasonboard.com> MIME-Version: 1.0 In-Reply-To: <20230920134109.2232769-1-dan.scally@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230922_030737_538376_766FE31A X-CRM114-Status: GOOD ( 13.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6690444335724945724==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6690444335724945724== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HhmUBSpH2Bkg5dom" Content-Disposition: inline --HhmUBSpH2Bkg5dom Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 20, 2023 at 02:41:09PM +0100, Daniel Scally wrote: > The error paths for xiic_reinit() return negative values on failure > and 0 on success - this error message therefore is triggered on > _success_ rather than failure. Correct the condition so it's only > shown on failure as intended. >=20 > Fixes: 8fa9c9388053 ("i2c: xiic: return value of xiic_reinit") > Signed-off-by: Daniel Scally Applied to for-current, thanks! --HhmUBSpH2Bkg5dom Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmUNZ2IACgkQFA3kzBSg Kbb10BAAi5dF8kPA1ACtZhc6vVe0VCPwKlGJ1VMYYzaIjAPm5+jXbKHrTCxnbKsa FLH/gFqGn9jwtccrrt7mdtIW1WRJqMoqmqDw4E+/A76/XYSF4xNjwCCbloQvpsDX Lp9mYd2DY+t1mOlkxECtVB7b9dfMPRISzMLO3bWYKDRaXnXzMExFSxC2Dz5mvO7e jPT85u839WtvpHPPMFBzVHgXwJ89FoPwM649RbcpcEiLp13bZycYMSNm5xhlI+Jn nGS4TYyHvnSAyEZmSjtbGasipKom7f7yux+jlrDm8DuMkOD+LKGuPAq7I7oLnLXu ohMzg/cwoNkgj3D5XuaDpLUUpZLzELmz5zv4bD0bauuVdN6WJ/xSvTTscEGofL3P oY168nPeaP1Nkd4PkdeRCXCglPQX8DNxKU4EMMts5qeNgaB64M4StUCt/fqWyTOQ ZDaJyp1tGYNYk1a7czOI5mxlItvoey7I+Xl8t1Z96pUdMaKjYcvb+A4IF/lWp83Q p9mIGne6byS4KwgYD1NkJgVrwDgs2ihgJ8ucR4qbD6lTdIl9zh0jRs9JM94E2jFu 9wSG1cQNK9h8uD4LPS4OBUsFBJ5TRxnVg5xE+ajjAh3sUrH7iBs6OaIw1qHbEKq6 HISm5HO+GMAbr4fmR/rQJLN5/CvOgJaj6DOJQLhiK5oWZ5LOZc0= =ipwC -----END PGP SIGNATURE----- --HhmUBSpH2Bkg5dom-- --===============6690444335724945724== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6690444335724945724==--