From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Chen Jiahao <chenjiahao16@huawei.com>
Cc: andersson@kernel.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, linux-remoteproc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
arnaud.pouliquen@foss.st.com
Subject: Re: [PATCH -next v2] remoteproc: stm32: Clean up redundant dev_err_probe()
Date: Wed, 13 Sep 2023 10:24:29 -0600 [thread overview]
Message-ID: <ZQHiPUYYLNwJ/rz1@p14s> (raw)
In-Reply-To: <20230817083336.404635-1-chenjiahao16@huawei.com>
On Thu, Aug 17, 2023 at 04:33:36PM +0800, Chen Jiahao wrote:
> Referring to platform_get_irq()'s definition, the return value has
> already been checked if ret < 0, and printed via dev_err_probe().
> Calling dev_err_probe() one more time outside platform_get_irq()
> is obviously redundant. Removing outside dev_err_probe() to
> clean it up.
>
> Besides, switch to use platform_get_irq_optional() since the irq
> is optional here.
>
> Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
> ---
> drivers/remoteproc/stm32_rproc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied.
Thanks,
Mathieu
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index 98234b44f038..1f53c672c66b 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -712,9 +712,9 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
> unsigned int tzen;
> int err, irq;
>
> - irq = platform_get_irq(pdev, 0);
> + irq = platform_get_irq_optional(pdev, 0);
> if (irq == -EPROBE_DEFER)
> - return dev_err_probe(dev, irq, "failed to get interrupt\n");
> + return irq;
>
> if (irq > 0) {
> err = devm_request_irq(dev, irq, stm32_rproc_wdg, 0,
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-09-13 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 8:33 [PATCH -next v2] remoteproc: stm32: Clean up redundant dev_err_probe() Chen Jiahao
2023-08-30 12:36 ` [Linux-stm32] " Arnaud POULIQUEN
2023-09-13 16:24 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQHiPUYYLNwJ/rz1@p14s \
--to=mathieu.poirier@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=chenjiahao16@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).