From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C8C5CA553C for ; Wed, 13 Sep 2023 16:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xNNO0lrEdSABDWErvaFv5VD9XLQtgt2RoJsFLGasYFI=; b=bZvXUZS9UW77gr 1MbFvCZckh3yILGYl90Gyaer3fGm+w/TKo3fKitZJWk8WtQUlKjpAwUwGJMy8+k2+ACIoIPODn5pn he9AX7FB0MDWM5xc3eJ9fEIiPtn0Dx8n2pNyH9hyEG9miMdO5a6vg45jMOxKloq+T0verY0AOzbqP Y3cbX3nknKT/PQPdSnzyUxaBiQIorp+t9OBVduiIGzeh9tTuI7+QtvJMdU16ZMJcMJLergGjofka0 uSPGBPbrV/XvzEZOmlONfr3cFqFU7HfZjQS/iXAIZFmVdNRIVY7zsS929wup6uKBcphxUv/+CnqXR nN5LRsAX2Bc7ZXMm4y1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgSfO-006Jke-1m; Wed, 13 Sep 2023 16:24:38 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qgSfL-006Jio-0l for linux-arm-kernel@lists.infradead.org; Wed, 13 Sep 2023 16:24:37 +0000 Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-26d1e5f2c35so7485a91.2 for ; Wed, 13 Sep 2023 09:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694622273; x=1695227073; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T8zYJ0RCDSzCvH0QmeVklyy3iTRroJs+iiHGO8/+f8I=; b=r1Og+Y+6cQSOXbSA3+bEUco3Bk13xwMxE/bc0WmGP5xipZZNZmBEDQBfpJ58Zwh3Qr mnajdlDsbjrJYezosMawgnPKXaBKcUj0qNTHAtCqZ0ORUkvnlpSYYFbfNsdXQu2ZejG8 j8X837sFfBL/CVIA+jz4884ms/lDKjs9M0DJ7j0Qr151WRAC7TSKZzni9Av6roni+wd2 bu3H+VXgWCWJUkqo+1kZxwbvGVcgo+mkauxBB7wFcDJRZWry/Xm6zzHvlR7GtaveqqO3 hhsjiy54dOn7fl5fXi5ofTsAr43aBCCI46PRuoRSmaUkJSYoD+eeAJSsxvJc9os9F8M4 WN2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694622273; x=1695227073; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T8zYJ0RCDSzCvH0QmeVklyy3iTRroJs+iiHGO8/+f8I=; b=f4gTOf6QuzLOXTgzTomXiKUnsNMjN6P96nhmNyVpL9J/Or25H6Er+NSOoS3tv1H2VB Gi119nkzzFgbcDjJyaVkDwzyHzmT2TOOQf+EhVitYZ/IXMrisgfvIcpvLyqmOzw0/BBD ovFqivj1nmDOZiV0SbDxvwHCaZeX7CCwD+NJqwpHi32I+/nOuqka2vCgHKr+dN8tmbBF xuiqlrPe0vnLxpc0mKnxg5oyzcwrpB63vCAYRq3dh6/DQ2PqXIpYnt0miH7auz2Sk0Pz MVmlD/2Nnb3Hmf+51jWgASZEPxe93XizUexGRBGuop+WJhlhIGDeTRYETS/R0o4zzick OQcQ== X-Gm-Message-State: AOJu0Yyj48vSkzhV5q6XFxf9TzUjLKOwQiUw+lW7xiskyU6LaBixxoxQ EGOLanS5FEngmfY9WJ+RBGExUg== X-Google-Smtp-Source: AGHT+IHWgvdtB+C/HoVawZpYur0vnXtpwb+tKQOBHfzGcJms7pMWVUlPNPLiwp+O2MlPn4j6G7TlYg== X-Received: by 2002:a17:90b:4c4f:b0:268:1068:4464 with SMTP id np15-20020a17090b4c4f00b0026810684464mr2548211pjb.30.1694622272676; Wed, 13 Sep 2023 09:24:32 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:d880:f5d9:a2c5:d083]) by smtp.gmail.com with ESMTPSA id gj19-20020a17090b109300b002680ef05c40sm1668280pjb.55.2023.09.13.09.24.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 09:24:32 -0700 (PDT) Date: Wed, 13 Sep 2023 10:24:29 -0600 From: Mathieu Poirier To: Chen Jiahao Cc: andersson@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, linux-remoteproc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, arnaud.pouliquen@foss.st.com Subject: Re: [PATCH -next v2] remoteproc: stm32: Clean up redundant dev_err_probe() Message-ID: References: <20230817083336.404635-1-chenjiahao16@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230817083336.404635-1-chenjiahao16@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230913_092435_321542_801E34EF X-CRM114-Status: GOOD ( 19.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 17, 2023 at 04:33:36PM +0800, Chen Jiahao wrote: > Referring to platform_get_irq()'s definition, the return value has > already been checked if ret < 0, and printed via dev_err_probe(). > Calling dev_err_probe() one more time outside platform_get_irq() > is obviously redundant. Removing outside dev_err_probe() to > clean it up. > > Besides, switch to use platform_get_irq_optional() since the irq > is optional here. > > Signed-off-by: Chen Jiahao > --- > drivers/remoteproc/stm32_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied. Thanks, Mathieu > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c > index 98234b44f038..1f53c672c66b 100644 > --- a/drivers/remoteproc/stm32_rproc.c > +++ b/drivers/remoteproc/stm32_rproc.c > @@ -712,9 +712,9 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev, > unsigned int tzen; > int err, irq; > > - irq = platform_get_irq(pdev, 0); > + irq = platform_get_irq_optional(pdev, 0); > if (irq == -EPROBE_DEFER) > - return dev_err_probe(dev, irq, "failed to get interrupt\n"); > + return irq; > > if (irq > 0) { > err = devm_request_irq(dev, irq, stm32_rproc_wdg, 0, > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel