From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91CBEEDE9A3 for ; Thu, 14 Sep 2023 10:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PwWSTj5LXX4D72DCM7uKCUpYLFoodmC/7mECBUxSNwY=; b=S8c0+XTmJ8kQcB AnEsLi/0bT7mqSDpOA3gfPuuOcrYFXfhjMdsdnFw4+TJcqII4eJJsTkCvLat09OTTDG1+Ma4Lum0Y 8dLymT3RZG3sywhU1qLKnpQRzLNovshk6NZcdAXkT1YT7pvec3+6AkV9HtsVfOwzOgkpeK34oCVWm peDTAToSwzttsL4xt52p6b9OkG8im9rlnjoqD9tfp6rnoXlnV15aEEHRXW92p9nXcOlHzUSwOMoKC 4n3qWnBbIqFbim9TtCt0GYP2NnqJjbkrClCe4sEMaXm6durBlT2T6E/fOMXnQNSWy5AHShaSmRQxA FUlc2EHbLBE16Z62wO5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgjtl-00818K-1S; Thu, 14 Sep 2023 10:48:37 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qgjth-00817Z-3B for linux-arm-kernel@lists.infradead.org; Thu, 14 Sep 2023 10:48:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=oV9oQ1VRKSIKluOnin5VgDD4lkOGDwwApmkI0eUm+80=; b=ihtLgeR6kg4kieAKjdNPojw8Lz Jl4BK16mRHAdB+u7Wz92ZKFqfRCCDUprT6UiNa1rI7rIm1hfkddMsV7VqIO1yTxKu99YCYHKkBY/h Ms3jfYtAArZLnCPEELQHi4fdLt3sGTLOT5vrf5ud/7NEVs3MaTSO7Zb8FZAs/Ce4NhfvVar7Og69x NaMSpathWXinroHecseWstpna5NzRo1mEFJriKoXJ8dsmXZP92Vy+iEht+gsKyrsUk49KPmxB5mwY TYu7okkinm9sffWV/6gKRp2WLEqobetmYch2pr7jx68t/ABANSIoaKimH+gmLnl4E4aeYSABCw+h6 PMy+kw6Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41838) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qgjtO-0003uu-1q; Thu, 14 Sep 2023 11:48:14 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qgjtK-0004hV-MT; Thu, 14 Sep 2023 11:48:10 +0100 Date: Thu, 14 Sep 2023 11:48:10 +0100 From: "Russell King (Oracle)" To: Serge Semin Cc: Jose Abreu , Alexandre Torgue , Alexei Starovoitov , "bpf@vger.kernel.org" , Daniel Borkmann , "David S. Miller" , Emil Renner Berthing , Eric Dumazet , Fabio Estevam , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , "linux-arm-kernel@lists.infradead.org" , "linux-stm32@st-md-mailman.stormreply.com" , Maxime Coquelin , "netdev@vger.kernel.org" , NXP Linux Team , Paolo Abeni , Pengutronix Kernel Team , Samin Guo , Sascha Hauer , Shawn Guo Subject: Re: [PATCH net-next 1/6] net: stmmac: add platform library Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230914_034834_398267_345477B8 X-CRM114-Status: GOOD ( 41.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 14, 2023 at 01:42:19PM +0300, Serge Semin wrote: > On Wed, Sep 13, 2023 at 03:21:10PM +0100, Russell King (Oracle) wrote: > > On Wed, Sep 13, 2023 at 03:14:47PM +0100, Russell King (Oracle) wrote: > > > On Wed, Sep 13, 2023 at 03:56:07AM +0300, Serge Semin wrote: > > > > On Tue, Sep 12, 2023 at 06:08:23PM +0100, Russell King (Oracle) wrote: > > > > > On Tue, Sep 12, 2023 at 12:32:40PM +0300, Serge Semin wrote: > > > > > > On Tue, Sep 12, 2023 at 07:59:49AM +0000, Jose Abreu wrote: > > > > > > > From: Russell King (Oracle) > > > > > > > Date: Mon, Sep 11, 2023 at 16:28:40 > > > > > > > > > > > > > > > Add a platform library of helper functions for common traits in the > > > > > > > > platform drivers. Currently, this is setting the tx clock. > > > > > > > > > > > > > > > > Signed-off-by: Russell King (Oracle) > > > > > > > > --- > > > > > > > > > > > > > > drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- > > > > > > > > .../ethernet/stmicro/stmmac/stmmac_plat_lib.c | 29 +++++++++++++++++++ > > > > > > > > .../ethernet/stmicro/stmmac/stmmac_plat_lib.h | 8 +++++ > > > > > > > > > > > > > > Wouldn't it be better to just call it "stmmac_lib{.c,.h}" in case we need to add > > > > > > > more helpers on the future that are not only for platform-based drivers? > > > > > > > > > > > > What is the difference between stmmac_platform.{c,h} and > > > > > > stmmac_plat_lib.{c,h} files? It isn't clear really. In perspective it > > > > > > may cause confusions like mixed definitions in both of these files. > > > > > > > > > > > > Why not to use the stmmac_platform.{c,h} instead of adding one more > > > > > > file? > > > > > > > > > > > > > > Is stmmac_platform.{c,h} used by all the drivers that are making use of > > > > > this? I'm not entirely sure. > > > > > > > > > > If it is, then yes, it can go in stmmac_platform.[ch]. If not, then I > > > > > don't think we'd want the bloat of forcing all of stmmac_platform.[ch] > > > > > onto drivers that only want to use this one function. > > > > > > > > With a few exceptions almost all the STMMAC/DW*MAC glue drivers use > > > > the methods from the stmmac_platform.c module including the bits > > > > touched by your patchset. AFAICS semantically both stmmac_platform.c > > > > and stmmac_plat_lib.c look the same. They don't do anything on its own > > > > but provide some common methods utilized by the glue drivers for some > > > > platform-specific setups. So basically stmmac_platform.[ch] is already > > > > a library of the common platform methods. There is no need in creating > > > > another one. > > > > > > I'm not questioning whether it should be merged, I'm questioning whether > > > all drivers that I'm touching make use of stmmac_platform.c, so your > > > long winded answer was entirely unnecessary. All you needed to do was > > > answer the question I asked, rather than teach me how to suck eggs. > > > > > So what about the name of the function? Are you happy that it's called > > "dwmac_set_tx_clk_gmii" rather than "stmmac_set_tx_clk_gmii" ? > > Not really. I would suggest to preserve the local naming convention: > 1. Generic names have stmmac_ prefix. > 2. DW *MAC IP-core-specific names have dw(xg|xlg)?mac(100|1000|2|4|5)?_ prefixes. > Alas it was violated in some places (like norm_desc and enh_desc.c > files) but is still mainly preserved in the driver especially in the > stmmac_platform.c which is concerned in this case. Thanks... so now I have you down as a single-issue reviewer - you spot something, you comment on it, and that's as far as you go. You don't seem to bother continuing the review and raising other points - which leads to lots of wasted time, and lots of patch set iterations, lots of email on mailing lists, etc. Do you think you could review the other patches before I go to the trouble of spinning a v2 please? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel