From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81E4EC46CA1 for ; Mon, 18 Sep 2023 17:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+VGHEoInT6i1jYH+sdnW6/uP92qywJEQtRHuPwIbYyg=; b=IbOCehQr2Xy6gCMgBIvYT0TkiA JRnG6hnAf/18mOCF/iBkiyRqXeoOlM1RfNgwFoJNDa9t+4wak1kQVzEf3Gmfz8HAt5l/bwqjdu2N1 ASDNxyRn6xnR1am0unci2sSwKBNbsu+kJYNXSixjxnooED+Au9lN5iCe85tYEzxq3N8iPmJ124fLX X9i0HZswRy0iSSrr+bdUzwKN4y7MBQtf9Gv5F6CUGwWVq/Sdt3rvYfamHvUQHalS2xC6zt3UeQZXk bgsdyQEEacb6EmP3vw3S3Pb4oWO7PyPCwIHMPw+ndZcunVX9fTbwKR/M/QoyykCvLMXbvopAUA87P kivsZMJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qiI2d-00FzLh-0W; Mon, 18 Sep 2023 17:28:11 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qiI2a-00FzKe-0W for linux-arm-kernel@lists.infradead.org; Mon, 18 Sep 2023 17:28:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 98DBDB80ED5; Mon, 18 Sep 2023 17:28:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01D89C433C7; Mon, 18 Sep 2023 17:28:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695058085; bh=eyW6d2pjl5JU+Oz+ApgrqSfhAmLNl4BcssGT7YSphc4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IbB1z5mkBAWHsfRvsZjvsxYzLRw0rJ3dlSLzqGZnFL0OiHGKU3XT0Ar4D1kXG4XD7 xFhrMDdEpKDXiHg6+K0ZGUdAZluvjGTxJrf3FHpDD+OP0fVavsq2DCxh7xTcgDg7Gg u1DgU/jXP8TnhGe7nQ4bpE9xGBEeqxo2+lypfx/Dhk3H3XXNSwQ3ZrQHscqeavAkXl nPz4N6yoaiRK/1ob/iNTjYnWCI7Th9DJdC/D+JtX3EbwSSrstUNkWdFe3gVdWSwv+z nSoOBPoE+Cc3NjcINchZDJ9IUvvPlk9+ByFtJVC0QGLh1UyAlAZiRmAVMrvMqezNZJ XnVkn/8Z+6KEA== Date: Mon, 18 Sep 2023 13:28:02 -0400 From: Sasha Levin To: Mark Brown Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jernej Skrabec , Daniel Lezcano , anarsoul@gmail.com, tiny.windzz@gmail.com, rafael@kernel.org, wens@csie.org, samuel@sholland.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Greg Kroah-Hartman Subject: Re: [PATCH AUTOSEL 6.5 6/6] thermal/drivers/sun8i: Free calibration nvmem after reading it Message-ID: References: <20230909011254.3581788-1-sashal@kernel.org> <20230909011254.3581788-6-sashal@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230918_102808_331366_0B36C28E X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 09, 2023 at 01:37:19PM +0100, Mark Brown wrote: >On Fri, Sep 08, 2023 at 09:12:54PM -0400, Sasha Levin wrote: >> From: Mark Brown >> >> [ Upstream commit c51592a95f360aabf2b8a5691c550e1749dc41eb ] >> >> The sun8i thermal driver reads calibration data via the nvmem API at >> startup, updating the device configuration and not referencing the data >> again. Rather than explicitly freeing the nvmem data the driver relies >> on devm_ to release it, even though the data is never referenced again. >> The allocation is still tracked so it's not leaked but this is notable >> when looking at the code and is a little wasteful so let's instead >> explicitly free the nvmem after we're done with it. > >This is a minor cleanup which as with so much of what's come in today's >backports seems very questionable for stable. I'll drop this, thanks! -- Thanks, Sasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel