From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Laura Nao <laura.nao@collabora.com>
Cc: Project_Global_Chrome_Upstream_Group@mediatek.com,
andersson@kernel.org, angelogioacchino.delregno@collabora.com,
conor+dt@kernel.org, devicetree@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-remoteproc@vger.kernel.org, matthias.bgg@gmail.com,
robh+dt@kernel.org, tinghan.shen@mediatek.com,
kernel@collabora.com
Subject: Re: [PATCH v17 00/14] Add support for MT8195 SCP 2nd core
Date: Mon, 18 Sep 2023 19:14:17 -0600 [thread overview]
Message-ID: <ZQj16b1NvkDlij+H@p14s> (raw)
In-Reply-To: <20230918103141.126271-1-laura.nao@collabora.com>
On Mon, Sep 18, 2023 at 12:31:41PM +0200, Laura Nao wrote:
> > Other than patch 2 and 14, I have applied this set. The remaining patches will
> > have to be resent to Matthias.
>
> > Thanks,
> > Mathieu
>
> Hello,
>
> With patch 2 missing, the SCP is not probed correctly anymore on asurada (MT8192) and kukui (MT8183). The mtk-scp driver relies on the existence of the `cros-ec-rpmsg` node in the dt to determine if the SCP is single or multicore. Without patch 2 the driver wrongly assumes the SCP on MT8192 and MT8183 are multicore, leading to the following errors during initialization:
>
> 10696 04:33:59.126671 <3>[ 15.465714] platform 10500000.scp:cros-ec: invalid resource (null)
> 10697 04:33:59.142855 <3>[ 15.478560] platform 10500000.scp:cros-ec: Failed to parse and map sram memory
> 10698 04:33:59.149650 <3>[ 15.486121] mtk-scp 10500000.scp: Failed to initialize core 0 rproc
>
> The issue was caught by KernelCI, complete logs can be found here:
> - asurada: https://storage.kernelci.org/next/master/next-20230914/arm64/defconfig+arm64-chromebook+videodec/gcc-10/lab-collabora/baseline-nfs-mt8192-asurada-spherion-r0.html
> - kukui: https://storage.kernelci.org/next/master/next-20230914/arm64/defconfig+arm64-chromebook+videodec/gcc-10/lab-collabora/baseline-nfs-mt8183-kukui-jacuzzi-juniper-sku16.html
>
> Reporting the issue so that patch 2 and 14 can be resent and merged soon.
>
Apologies for the trouble here, the error is mine.
I have applied and pushed patch 02 - please confirm that things are working as
expected now. Matthias will need to either ack patch 14 or pick it up himself.
> Best,
>
> Laura
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-19 1:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 8:09 [PATCH v17 00/14] Add support for MT8195 SCP 2nd core Tinghan Shen
2023-09-01 8:09 ` [PATCH v17 01/14] dt-bindings: remoteproc: mediatek: Improve the rpmsg subnode definition Tinghan Shen
2023-09-01 8:09 ` [PATCH v17 02/14] arm64: dts: mediatek: Update the node name of SCP rpmsg subnode Tinghan Shen
2023-09-01 8:09 ` [PATCH v17 03/14] dt-bindings: remoteproc: mediatek: Support MT8195 dual-core SCP Tinghan Shen
2023-09-01 8:09 ` [PATCH v17 04/14] remoteproc: mediatek: Add MT8195 SCP core 1 operations Tinghan Shen
2023-09-01 8:09 ` [PATCH v17 05/14] remoteproc: mediatek: Extract SCP common registers Tinghan Shen
2023-09-07 10:49 ` AngeloGioacchino Del Regno
2023-09-01 8:09 ` [PATCH v17 06/14] remoteproc: mediatek: Revise SCP rproc initialization flow for multi-core SCP Tinghan Shen
2023-09-05 7:46 ` AngeloGioacchino Del Regno
2023-09-01 8:09 ` [PATCH v17 07/14] remoteproc: mediatek: Probe SCP cluster on single-core SCP Tinghan Shen
2023-09-05 7:48 ` AngeloGioacchino Del Regno
2023-09-01 8:09 ` [PATCH v17 08/14] remoteproc: mediatek: Probe SCP cluster on multi-core SCP Tinghan Shen
2023-09-01 8:09 ` [PATCH v17 09/14] remoteproc: mediatek: Remove dependency of MT8195 SCP L2TCM power control on dual-core SCP Tinghan Shen
2023-09-05 7:46 ` AngeloGioacchino Del Regno
2023-09-01 8:09 ` [PATCH v17 10/14] remoteproc: mediatek: Setup MT8195 SCP core 1 SRAM offset Tinghan Shen
2023-09-01 8:09 ` [PATCH v17 11/14] remoteproc: mediatek: Handle MT8195 SCP core 1 watchdog timeout Tinghan Shen
2023-09-01 8:09 ` [PATCH v17 12/14] remoteproc: mediatek: Report watchdog crash to all cores Tinghan Shen
2023-09-05 7:46 ` AngeloGioacchino Del Regno
2023-09-01 8:09 ` [PATCH v17 13/14] remoteproc: mediatek: Refine ipi handler error message Tinghan Shen
2023-09-01 8:09 ` [PATCH v17 14/14] arm64: dts: mediatek: mt8195: Add SCP 2nd core Tinghan Shen
2023-09-04 17:48 ` Mathieu Poirier
2023-09-04 17:50 ` [PATCH v17 00/14] Add support for MT8195 " Mathieu Poirier
2023-09-05 7:46 ` AngeloGioacchino Del Regno
2023-09-13 17:50 ` Mathieu Poirier
2023-09-18 10:31 ` Laura Nao
2023-09-18 10:44 ` Chen-Yu Tsai
2023-09-19 1:17 ` Mathieu Poirier
2023-09-19 5:07 ` Chen-Yu Tsai
2023-09-20 8:51 ` TingHan Shen (沈廷翰)
2023-09-19 1:14 ` Mathieu Poirier [this message]
2023-09-19 8:45 ` Laura Nao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQj16b1NvkDlij+H@p14s \
--to=mathieu.poirier@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laura.nao@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tinghan.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).