From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56B7FC05025 for ; Wed, 20 Sep 2023 21:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=O6Luv2Zt/TCI2U7QO6acytKEPYvHcNsCL/FuLERcrps=; b=0OrFvJCd9KITDBFxP2zhq44q3H M5Co2wnlKc3rtJ/ROqurAD77aZvlNG4e49o2nyOvQwSeIEmfrRfh5MZ3nW14PAZjEAe2AmoBO0/m3 ud4hEFsVF/Lq7HXxmOeaQKRvfvG4+Oo3asBTfmrIamBRAXeTL6n/p+qFvJecIRLBrEUY3RwACB9AT AGANNVbWfh6HBwG2O3/p0rfnhanB5ZDGsdQGMX84r0aVJ8+NfWtWhnI0mdG7cSBaF3brcCmaziJWA J5mqa9JkDyxBcI/q3EeZwBZi3DKbkftr7rqmhliYJ9XxCVaCUu2aR1cpqzKDL3vm4q2+49IiEvRUk 15T6WQFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qj4MX-004DN8-03; Wed, 20 Sep 2023 21:03:57 +0000 Received: from mail-pl1-x649.google.com ([2607:f8b0:4864:20::649]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qj4MT-004DJR-07 for linux-arm-kernel@lists.infradead.org; Wed, 20 Sep 2023 21:03:55 +0000 Received: by mail-pl1-x649.google.com with SMTP id d9443c01a7336-1c448ba292dso1833905ad.3 for ; Wed, 20 Sep 2023 14:03:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695243830; x=1695848630; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QFTXI1M20f8gmG6BvRAdcxEpoXePrbyr+CokqbvWBWc=; b=I5qTKbcYogYoCX5R4GsrkIKSmblmgYmC2WbbNnsi5ajueBGrk6fStU2BRMv/EkNyHh euavse/28IhfKNyBKgW0bQ6TJHbJmjbxARNFhuKsY4XSWUeQ3ZWP8fqdkr2IJgzOZ7la Y6XY7ApbFwkEKf6W0nMePuX6i51mZgIdUGHX3uwiE0BxjbvVoNuyTrQpKkgdWthjKjmx 3zXuoqpsqUlOe/j5lSHtqBGy8wwOSWqAy7pELB86fA3LoEPDadYIxvrhJlIAKTNxrHFB Qy2dyQMkm9d5SpxkMaCb04bW1JWytVvsStUjzUjhXqdmEIVeGZZE6cPgFcGn+XVthPhk oS7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695243830; x=1695848630; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QFTXI1M20f8gmG6BvRAdcxEpoXePrbyr+CokqbvWBWc=; b=Mg9b0n9Qn1EbHAwGBdCC14FpA1eBlUWuA5Z4D54PuFdmoWZSXtecSzVzV2yLl/9Vv2 8Bqx8ZBUM7QtvXDTUX2lXPEy/MfzkcxmZdUu+Fy4nRQ2Xsk95AFOsMvG1dITAoUIOpDf rMkGbKGwHObKiYqkd3m0aG2cYdvofd4lgbchX5vI9bD1dAWq/hYrNk+gfnxwkSlnVKGV hb5+DIduIvdRloVNBz5Un0iYm9BIU/d0vM/y+846jY1nqKppWjejQQEZ34BH3y/POLhE Kvc+3Zva540mxwEiuA7EDWUAAJiHAPrhyBhAyVK7JRYxMRZ0tOzMxTmrCOhF/UwZAjsB nRiA== X-Gm-Message-State: AOJu0YxlNsVsEieeTlhzxU+ecRzQRUZDnkQWnl3e16yuVH50RGYeJztE bOkF5yCldCNIp504s2Hb78Yz9bkG4Zg= X-Google-Smtp-Source: AGHT+IH5QBEwnaGAG6ouJVZQG2FiwG4z7ywKiDhgLSOOF+0VMXfLus6G3HR8pg7XpQjZrIgu3wnPZ1Tf/l8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:c407:b0:1c3:411c:9b7c with SMTP id k7-20020a170902c40700b001c3411c9b7cmr51568plk.13.1695243830643; Wed, 20 Sep 2023 14:03:50 -0700 (PDT) Date: Wed, 20 Sep 2023 14:03:49 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-12-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v12 11/33] KVM: Introduce per-page memory attributes From: Sean Christopherson To: Binbin Wu Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , Xu Yilun , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230920_140353_076301_E865CF52 X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 18, 2023, Binbin Wu wrote: > > > On 9/14/2023 9:55 AM, Sean Christopherson wrote: > > From: Chao Peng > [...] > > +#ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES > > +/* > > + * Returns true if _all_ gfns in the range [@start, @end) have attributes > > + * matching @attrs. > > + */ > > +bool kvm_range_has_memory_attributes(struct kvm *kvm, gfn_t start, gfn_t end, > > + unsigned long attrs) > > +{ > > + XA_STATE(xas, &kvm->mem_attr_array, start); > > + unsigned long index; > > + bool has_attrs; > > + void *entry; > > + > > + rcu_read_lock(); > > + > > + if (!attrs) { > > + has_attrs = !xas_find(&xas, end); > IIUIC, xas_find() is inclusive for "end", so here should be "end - 1" ? Yes, that does appear to be the case. Inclusive vs. exclusive on gfn ranges has is the bane of my existence. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel