From: Andy Shevchenko <andy@kernel.org>
To: Huqiang Qin <huqiang.qin@amlogic.com>
Cc: linus.walleij@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
neil.armstrong@linaro.org, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
brgl@bgdev.pl, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/3] pinctrl: Add driver support for Amlogic T7 SoCs
Date: Thu, 21 Sep 2023 13:00:18 +0300 [thread overview]
Message-ID: <ZQwUMqPG2Z+Y/FTF@smile.fi.intel.com> (raw)
In-Reply-To: <20230921083407.1167510-4-huqiang.qin@amlogic.com>
On Thu, Sep 21, 2023 at 04:34:07PM +0800, Huqiang Qin wrote:
> Add a new pinctrl driver for Amlogic T7 SoCs which share
> the same register layout as the previous Amlogic S4.
...
> +static const char * const uart_ao_a_groups[] = {
> + "uart_ao_a_rx_c", "uart_ao_a_tx_c", "uart_ao_a_tx_w2",
> + "uart_ao_a_rx_w3", "uart_ao_a_tx_w6", "uart_ao_a_rx_w7",
> + "uart_ao_a_tx_w10", "uart_ao_a_rx_w11", "uart_ao_a_tx_d0",
> + "uart_ao_a_rx_d1",
> +
Redundant blank line.
> +};
With that fixed,
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-21 10:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 8:34 [PATCH V2 0/3] Add pinctrl driver support for Amlogic T7 SoCs Huqiang Qin
2023-09-21 8:34 ` [PATCH V2 1/3] dt-bindings: pinctrl: Add compatibles " Huqiang Qin
2023-09-21 9:19 ` Conor Dooley
2023-09-21 9:43 ` Huqiang Qin
2023-09-21 8:34 ` [PATCH V2 2/3] pinctrl: Add driver support " Huqiang Qin
2023-09-21 10:00 ` Andy Shevchenko [this message]
2023-09-21 8:34 ` [PATCH V2 3/3] arm64: dts: Add pinctrl node " Huqiang Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQwUMqPG2Z+Y/FTF@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=huqiang.qin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox