From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C9EAE71096 for ; Thu, 21 Sep 2023 16:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Usc+mgGmPLFNYXmvwNRod6cyZR5811zoUymyxabfirU=; b=gd0T7jBEONq1Eq Cfp89BrLzgi4e1SAuZvICnkkre9UOZnbSsxkWACaUC7iv7Ny2HjOjcCNGJcQCTiuIUiUnWGeQh/9s llVV3AujZ5tKk4J7oHm+6PzW8P5csGQhz7LM9NzK89WeLA6xdj4KK4PqFcB9ItvRfmma0cRX7cXER ttu0Y9wdBlxznAdkhA9VdXrT8bcr62bdKaQyjZ3mc5Zsbdw0o14dyRSMl0VoqNckhGCD51mmtJiZR uuZVUDp/ekWXpbV3ywyPSJvh7dJQij40w+AOsssHWmgz6jMluMiTTj+hVePhUXBBCW4qsg0rDf1Rf 7cK3rWM8fSPBIdrdmpqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjMtK-006Yen-0z; Thu, 21 Sep 2023 16:51:02 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qjMtI-006YeW-2q for linux-arm-kernel@bombadil.infradead.org; Thu, 21 Sep 2023 16:51:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j4AF8gjB4l2BdpPb72TCju0epRbS+NFWnqNtNSH46BA=; b=FgRWrncY+xNeARFq1y6WGfnz/m hGQTbZV2ibap6GlwCf8jutPJ9wRUfSEweop1OBDY4s88rQz1eTMVGzZ2uMK/O1TdzwCA6AjISnhEH cmpcD41dZoepAmRBPD+fpU81AX0LnORmNhGGNMNB2GlRl9Vtu/4qzINcXYrNpzNAlwGszLrBiqa4O FID9aBcwYl9DXK3Z/xR7NP6DaxoQnyL4sMiBK0p7Q0K2PW6p0IhY9TiYPytECJ0kPIc4VlbuYQw6x WTi8+qenIUIPGXH/4gEHm8Nm2b9D1swgkiKknnt0YHjIetlAwg3Nyyp2d7Lq7vaPgiy8peQDE8/uQ PbGmc5pg==; Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjMtD-00FWC8-3C for linux-arm-kernel@lists.infradead.org; Thu, 21 Sep 2023 16:50:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A15DF1A25; Thu, 21 Sep 2023 09:51:28 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.36.171]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0778C3F5A1; Thu, 21 Sep 2023 09:50:48 -0700 (PDT) Date: Thu, 21 Sep 2023 17:50:46 +0100 From: Mark Rutland To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org, bertrand.marquis@arm.com, boris.ostrovsky@oracle.com, catalin.marinas@arm.com, daniel.lezcano@linaro.org, james.morse@arm.com, jgross@suse.com, maz@kernel.org, oliver.upton@linux.dev, pcc@google.com, sstabellini@kernel.org, suzuki.poulose@arm.com, tglx@linutronix.de, vladimir.murzin@arm.com, will@kernel.org Subject: Re: [PATCH 11/37] arm64: Rename SVE/SME cpu_enable functions Message-ID: References: <20230919092850.1940729-1-mark.rutland@arm.com> <20230919092850.1940729-12-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230921_175057_729264_9A841437 X-CRM114-Status: GOOD ( 17.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 19, 2023 at 11:52:47AM +0100, Mark Brown wrote: > On Tue, Sep 19, 2023 at 10:28:24AM +0100, Mark Rutland wrote: > > The arm64_cpu_capabilities::cpu_enable() callbacks for SVE, SME, SME2, > > and FA64 are named with an unusual "${feature}_kernel_enable" pattern > > rather than the much more common "cpu_enable_${feature}". Now that we > > only use these as cpu_enable() callbacks, it would be nice to have them > > match the usual scheme. > > Reviewed-by: Mark Brown > > However: > > > This patch renames the cpu_enable() callbacks to match this scheme. At > > the tsame time, the existing comments regarding ordering requirements > > Typo. Thanks; fixed. > > are turned into build-time assertions, matching what we do for > > can_use_gic_priorities() and has_gic_prio_relaxed_sync(), and the newly > > redundant comments are removed. > > This should really be a separate commit. Sure -- I've split this into a first patch which adds the assertions, and a second which does the rename. Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel