From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FDBBE8FDCC for ; Wed, 4 Oct 2023 06:55:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sbeNhaxWAmPB7LFusPfkcXaxiz71hW0HonSgC+Qv+gU=; b=x6o5BmgSukw3/A EuW21beo3mQPdHGuOFsG9Nx8MHOJXzNRA+ZuH67l1leAFS0HVqRaNM3OmRzkHuDzx0i4Z6PL/EK7s OeN6LKq1mM7fCroikn1WMQGZqPSE/6r6D0BfxqBdzY9rXZ2N6MauEuYPVFXnJW4EaFHdo4gz0Tk7L mDm0NIXxk6RrlF/i5dTv2E7wlYOJpfoOyR4pXp7ZNK7Msk+jEvV8hpnsie1XykeHuiHziR79Fe8Gz H8AvHrQbisrkUPLQB+FWWkZyuDmzWKdDhxz3j0OiY9tFR9te4gNZnTf7ZQLDUQOYlSjvd9kb2HZDY ruwFppGcm9/9PEl/ltTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnvmN-00GUq8-1B; Wed, 04 Oct 2023 06:54:43 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnvmL-00GUok-12 for linux-arm-kernel@lists.infradead.org; Wed, 04 Oct 2023 06:54:42 +0000 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-690fe1d9ba1so363856b3a.0 for ; Tue, 03 Oct 2023 23:54:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696402479; x=1697007279; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=6YbF45exUihM3V8J++Yr9N+b7S0JorXYJc7FhvfdAn8=; b=x9XbKEQ6gh66hhi/E/abxatjqMSDIHeA5uNkGZE4dFeEALwhp63vdMJyw5Va2hJugc aJAJ3AzppOGktQDiXA1i8YWZD68ZV3SKKL++L2xmdXHtMjUtYus9B7gaTL2HuPBeA3JC 65q1Na2i1L+LMVekLDDLAJGi3HQ2TM0PY89H93c9yBaRhSbsRd10IJBHfN9LwgFoY5tO TgoldvVbVjdHeN/Q3fcYkVFNBxGzNuY+4pFi41T7JgGhjCQBMr/UAkybF8SAedytHc41 jjb4G3Mam8puzesePMhjXnm3F8MK9r3EwmLT8tCGFYjpVrWMBCjb9jKP+lk4lhxW5ZxH hlKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696402479; x=1697007279; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6YbF45exUihM3V8J++Yr9N+b7S0JorXYJc7FhvfdAn8=; b=N1zF6qasGguRWweOLce0OvK9ORrtUYo+ATJWZY86hXPtb0Fr2x33giUWj9e7F+yOm+ f4E0hduRoxa9z0Nl2vhy/wn1cZyoJiLBIcInBwd01zP/UPRkvPc6yTd96bfjlhZvFKxf 3cQczqRFlvd65bacq2/Edl+ZhziCEDP1PenXqdPApNtC4GOtolqwPx+cWFJNH8WYldO+ gW4lZTmAeEsfRKgIN/9DTur8+o3wM+fgEFHXlYWtUqT2Dr6c67mUdnaJ1PZs/mmwEHHV 5e1lCg6XtaCFOzwEol7KiGhZ3wJbxTWQkz2f79lVGLHW73eFro1EUsZL3xkKBqzIJp/O f91g== X-Gm-Message-State: AOJu0YwDMRsiIvHTG8a6/tGQDS0Q4Hn32U8g8Fo1RsFjiHU7KU0GmMMq nXAPz78dqPEh1UDExHmCWHHshA== X-Google-Smtp-Source: AGHT+IEDXNokAKn8nzCNvCbNOIUSolppsI+K2w+sGFIw9BHV5d5Ibkooq38MxAM5oAiTWM73Hlc0Tw== X-Received: by 2002:a17:903:244d:b0:1c5:cd01:d846 with SMTP id l13-20020a170903244d00b001c5cd01d846mr1709840pls.3.1696402479192; Tue, 03 Oct 2023 23:54:39 -0700 (PDT) Received: from octopus ([2400:4050:c3e1:100:81c4:ac5:bfc9:67a3]) by smtp.gmail.com with ESMTPSA id y5-20020a1709029b8500b001b54d064a4bsm2815058plp.259.2023.10.03.23.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 23:54:38 -0700 (PDT) Date: Wed, 4 Oct 2023 15:54:33 +0900 From: AKASHI Takahiro To: Linus Walleij Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Oleksii_Moisieiev@epam.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [RFC 1/4] pinctrl: define PIN_CONFIG_INPUT Message-ID: Mail-Followup-To: AKASHI Takahiro , Linus Walleij , sudeep.holla@arm.com, cristian.marussi@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Oleksii_Moisieiev@epam.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20231002021602.260100-1-takahiro.akashi@linaro.org> <20231002021602.260100-2-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231003_235441_362119_BDAB92A3 X-CRM114-Status: GOOD ( 18.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 03, 2023 at 10:49:10PM +0200, Linus Walleij wrote: > Hi Takahiro, > > On Mon, Oct 2, 2023 at 4:17???AM AKASHI Takahiro > wrote: > > > This allows for enabling SCMI pinctrl based GPIO driver to obtain > > an input gpio pin. > > > > Signed-off-by: AKASHI Takahiro > (...) > > + * @PIN_CONFIG_INPUT: This will obtain a value on an input pin. The returned > > + * argument indicates the value. > > We need to specify that this is the inverse of @PIN_CONFIG_OUTPUT, > that setting a line into *input mode* requires the use of > @PIN_CONFIG_INPUT_ENABLE, so the config can never be set > but should return an error on set, and that the argument returned is 1 for > logic high and 0 for logic low. I will add more as you suggest. -Takahiro Akashi > Otherwise I think this is fine! > > Yours, > Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel