From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB718E8FDD4 for ; Wed, 4 Oct 2023 07:08:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KMp8dZIrrYM0zAWa+RnLi7YCmo9HgvHaYpdavuRsXEg=; b=rvtmQ8ZXf8Gr8L 2OQF5dqamEBCwHxFkE3Po1Iv9DbLHeRKgRsh0Zmxb8Hh1KZDPlufGFbWaEmr8hPr90YXXzAE7Ld6t zIz2Wlh8yKK6ltrT6LLZZy64906V8oPtTL4KJRTQ/afZaQBE9OHee3Df8Gn+c2v39FsRq7W34L86z 9TToa7cPC6JXkPDldFvAB0HADAti5OWkAnmGbfao0d7qRo6KngZhkyieUmSkr+n/lo0IvazciI77L 4SOm0HJq5foA2sjuFjbknDo7f77pn0nRGr1nTmUdGZSF3x4WN24rOvXkfBrePG7Pf8APrEV2+5cid AOAFvgflpur5IhX+oPBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnvzm-00GXcR-2o; Wed, 04 Oct 2023 07:08:34 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnvzj-00GXaS-0o for linux-arm-kernel@lists.infradead.org; Wed, 04 Oct 2023 07:08:33 +0000 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1c5faa2af60so1865375ad.0 for ; Wed, 04 Oct 2023 00:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696403308; x=1697008108; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=t+HNamXx8KNnqMjBVvxVHxCmQqxpGZi0a4VnllDCQ5M=; b=q+L0UTBnMLjLCBzzJm3pZYYWvzCMjwBkKOVsV0StoldfCWp/7yUIYy+ja9kPnxC0m0 ktNslI4qXWazDurPiPDBCAOtLbneR2Te2R6sbbOc8De4RvSpBWsUtmwrumQIfYHBbzka g2dDsEHoy7OUsWwnYnnkEcectxI+z+hi/BM1IZHz5qRHRpvSuJ5wUPvK5Fig2+vhO0u4 bHulnffxTM3mG9iOK1nDc/BufhKWOehuZecgZp0zjUi486mEEfpks3DJ3k6vZfZB4gVI h+YfUI1m08s9L3845x6aNii9wDjhk4IW4Q1w+6EtlGGdXdlyCPn/JSCQ8vYJLwNQqn+C M7mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696403308; x=1697008108; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t+HNamXx8KNnqMjBVvxVHxCmQqxpGZi0a4VnllDCQ5M=; b=KgBZdVHjhR8qddTFXfCR2fAKFWOFFyWZjdT641I35i95I7dyTS/yXiho1X7U4G3fNU QrLNgcXYOeIV3fXLS6foEFZkomwDx/eqO9nqMvctRhg2UJgOlpnCNuMomouFikiUpzpx dKjQnfFwomtgTo/VovNowfAK3P8vhTIim7uPT0BPAKoxkzRbFFN0nRRizq9RmS+sVqOW wiqOqxSnTSsTqYET5TkGBTeW422LWD7Rzj8rYBCIlAIxk4zxT3ES4Y1SvH8i5kiQVpQs 3WB90ks6lA+Q3M9kuy1Jp9ND8qThSh0jWRmL4vL7zxHZ12XuxQ0McxURn4g9ypUOQ4xl QNEA== X-Gm-Message-State: AOJu0Yz0BsVFTje/160fW56knfcDMJDgDHNOpc6jfjhphIDXZ6Q8YdOK H2jY75s1Hj5itW/1GT25rAMrDw== X-Google-Smtp-Source: AGHT+IG9Sl5KymtbHuRT8tP6Uk0OFio8plzOQlpu4XZA2P8W7Fbb/mUXcRCply6qxt878PPQR8VPJQ== X-Received: by 2002:a17:902:dac8:b0:1bf:1a9e:85f7 with SMTP id q8-20020a170902dac800b001bf1a9e85f7mr1785477plx.1.1696403308115; Wed, 04 Oct 2023 00:08:28 -0700 (PDT) Received: from octopus ([2400:4050:c3e1:100:81c4:ac5:bfc9:67a3]) by smtp.gmail.com with ESMTPSA id e4-20020a170902d38400b001c3f7fd1ef7sm2873333pld.12.2023.10.04.00.08.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 00:08:27 -0700 (PDT) Date: Wed, 4 Oct 2023 16:08:23 +0900 From: AKASHI Takahiro To: Linus Walleij Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Oleksii_Moisieiev@epam.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [RFC 4/4] dt-bindings: gpio: Add bindings for SCMI pinctrl based gpio Message-ID: Mail-Followup-To: AKASHI Takahiro , Linus Walleij , sudeep.holla@arm.com, cristian.marussi@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Oleksii_Moisieiev@epam.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20231002021602.260100-1-takahiro.akashi@linaro.org> <20231002021602.260100-5-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231004_000831_291470_751AB21D X-CRM114-Status: GOOD ( 25.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 03, 2023 at 03:16:49PM +0200, Linus Walleij wrote: > Hi Takahiro, > > first, thanks for working on this important and crucial driver! > > I'll try to clarify and also explain something of what the others > are saying (unless I misunderstand them...) Ah, thank you. > On Mon, Oct 2, 2023 at 4:17???AM AKASHI Takahiro > wrote: > > > A dt binding for SCMI pinctrl based gpio driver is defined in this > > commit. It basically conforms to generic pinctrl-gpio mapping framework. > > > > Signed-off-by: AKASHI Takahiro > > I think like Christian says that SCMI maybe has nothing to do > with this binding? It is just one possible use case (though we don't know > of any others.) The resource it is using is generic functionality that exist > in any pin controller that provides ways to drive lines high and low > etc. > > Would it be named a generic pin control-based GPIO? If you like :) As I said, I was not confident that the driver be applicable to other pinctrl-gpio cases. > (...) > > +++ b/Documentation/devicetree/bindings/gpio/arm,scmi-gpio.yaml > (...) > > +$id: http://devicetree.org/schemas/gpio/arm,scmi-gpio.yaml# > > So no ARM, no scmi, just pin-control-gpio.yaml, be bold! I'm not so ambitious. > (I like this long unabbreviated name) > > > +title: SCMI pinctrl based generic GPIO controller > > Pin control-based generic GPIO controller > > Add > > description: > The pin control-based GPIO will facilitate a pin controllers ability > to drive electric lines high/low and other generic properties of a > pin controller to perform general-purpose one-bit binary I/O. > > (At least I think this is the idea, I hope I understand correctly.) Okay. > > +properties: > > + $nodename: > > + pattern: "^scmi_gpio(@[0-9a-f]+)$" > > These nodes are always just named gpio@... > the resource marker is "this is a GPIO" that's all it means. By following other gpio drivers' bindings, I will drop this rule. > > + compatible: > > + const: arm,scmi-gpio-generic > > const: pin-control-gpio > > Other than that I am aboard with the solution! Hope that the driver works on real hardware :) -Takahiro Akashi > Yours, > Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel