From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CCC2E8FDDB for ; Wed, 4 Oct 2023 08:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hh5MOhn7PuwHC9JIecvUWdy4S8NfsoXtOhd+aMRLx6g=; b=k0LsgxCD19nNwq tDfRp/RR186hNynBRbOm3HRbLMeaR6J2j1y0Z0HFKGIRuckbCGgiQ39RnbLqVAKwOq4wRd1rlrlZe oCLYpaMDBfBhOxRTvliZuxArNz+OLb/RDWkN0XlZm76g9wglvVDjN6FP9p+hL0AnSFWInB6LSMSEw trdiAL8pD5Uw+e3NzVtp10Rzs9LfT2m/TUBu4W5PdMRi0JsQ+1dQCGbIYt7AsodzLNRfWEoYt2IbK fKxVs3UGSzaOSeowxH8QTn9TqnSOjiM8+lYeRyp0Y3Df/qcnau3r56u9uZw/LmukB0JKmxPlAomZK eeZbujaAiD6X4jVlR9Ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnxGD-00GpB5-2R; Wed, 04 Oct 2023 08:29:37 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnxG9-00Gp9W-2W for linux-arm-kernel@lists.infradead.org; Wed, 04 Oct 2023 08:29:35 +0000 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5230a22cfd1so3188179a12.1 for ; Wed, 04 Oct 2023 01:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696408170; x=1697012970; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jnNSTFNXYMGhiBE5TTn8XlAm70fbHnUZa7Uv0OEiDKY=; b=KBq9OI0NLn8eUaK68QEIaRVSv96/ZZ/8QHDXyz+HHpXXuLFSm2GOXkmY1j33VyF7OU 0ZG+xT653X5kWYCw0IpOVpUJV1BXPpa7x88YHE6rFuOLzgLhi2+kT1Znnygty1HdEsPp o31pmcjHygVGPgELdf7mfdvhhPF+NWq5SzHP5ThFqfNK3niSXbI3HOCVHzbx2d26plyj WXOvTLa1O6ANJMb8LKz+Evbs3CgO2xxhTOaoRrruGKJ4iKU4dwFCo1LXZr0wg1K7s/Jo HUhVi1SKdkRfIodJzX0ZVMOkHpxGV+pYPXJ0IRqXLcFpQvKArbIWRCpqHzmUjCr8tywj GyDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696408170; x=1697012970; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jnNSTFNXYMGhiBE5TTn8XlAm70fbHnUZa7Uv0OEiDKY=; b=QFjJKv8FXqkF+ykqd55gNaKQ/ghY3CsnktfXsV+SZjdFpOqftTqnx74AnGXc2cwCO2 t8nGr+zgWtd6JJqIIFHc79fcJxX9jdcgeU+5t3f2LxQnb7wHI0gfuJkVfOrOPpGVgLsn 3F96+AcxINp3pu6TmjEDKlTtKKNUjiK9aikIPszZjFOSvVKHobRTiquv7vc0i2RN8kFn zDJf01KYXREsVWPAtPAcXvkq7g3ziHnyjDxbQxhxV2tBxvyj+ULffX3+PhdBrX/JnWl9 4WFGvzkECmZqPawmyfHq98YWTu2VglZifvfWKUadKrbROSLf61rx2qh8rtK67SwfFoUL vtyg== X-Gm-Message-State: AOJu0YyD+Bf3Stf97bTz7nthPLg/J5z8AyWG91k4mM8+cVZxfMly5YTW eRYlwZ5iOxEZVA37tgJJYzx/O1vL1bo/snBSyEM= X-Google-Smtp-Source: AGHT+IEouVepWQWLdQeh/NMGAzc47HjCU0/MoBhFC47e/nw7G0peD322pC5n9Skvs0n93OtTDlR4hA== X-Received: by 2002:aa7:c907:0:b0:534:7b49:9036 with SMTP id b7-20020aa7c907000000b005347b499036mr1303715edt.12.1696408170018; Wed, 04 Oct 2023 01:29:30 -0700 (PDT) Received: from linaro.org ([86.123.99.172]) by smtp.gmail.com with ESMTPSA id s7-20020aa7c547000000b0052595b17fd4sm2043606edr.26.2023.10.04.01.29.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 01:29:29 -0700 (PDT) Date: Wed, 4 Oct 2023 11:29:28 +0300 From: Abel Vesa To: Dan Carpenter Cc: Shengjiu Wang , Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/2] clk: imx: imx8: Fix an IS_ERR() vs NULL check in clk_imx_acm_attach_pm_domains() Message-ID: References: <44bacaba-848b-4e62-908c-16538330d4dd@moroto.mountain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <44bacaba-848b-4e62-908c-16538330d4dd@moroto.mountain> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231004_012933_826407_FD62BCD4 X-CRM114-Status: GOOD ( 16.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23-10-02 10:01:51, Dan Carpenter wrote: > The device_link_add() function returns NULL on error. It doesn't return > error pointers. Fix the check accordingly. > > Fixes: d3a0946d7ac9 ("clk: imx: imx8: add audio clock mux driver") > Signed-off-by: Dan Carpenter > --- LGTM. Reviewed-by: Abel Vesa However, this doesn't apply for some reason. Can you rebase and resend? > drivers/clk/imx/clk-imx8-acm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8-acm.c b/drivers/clk/imx/clk-imx8-acm.c > index 1e82f72b75c6..83019b986622 100644 > --- a/drivers/clk/imx/clk-imx8-acm.c > +++ b/drivers/clk/imx/clk-imx8-acm.c > @@ -287,9 +287,9 @@ static int clk_imx_acm_attach_pm_domains(struct device *dev, > DL_FLAG_STATELESS | > DL_FLAG_PM_RUNTIME | > DL_FLAG_RPM_ACTIVE); > - if (IS_ERR(dev_pm->pd_dev_link[i])) { > + if (!dev_pm->pd_dev_link[i]) { > dev_pm_domain_detach(dev_pm->pd_dev[i], false); > - ret = PTR_ERR(dev_pm->pd_dev_link[i]); > + ret = -EINVAL; > goto detach_pm; > } > } > -- > 2.39.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel