From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C04CE7B60D for ; Wed, 4 Oct 2023 12:42:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1Dl+GszJ7HBnJbP35pLs2TfsLFxpDeb9CtH7S3ky38A=; b=WgtvL7jEH4IWjq NC8tionQB1LpKczyVcVTD0eyBqOELsrM3/D+QC0oTaGrBHV36Pk6nFuA2sq3XLOzHQMPNbU+joKc1 gbse9XgzVx2NoW2Ig/t6fxV8Mhs4TQkCjXB7EnBX6R6BYTeFiGwZaJizzw/EEIk2/0vScKZqcuAET rlLlDA+NMQzN0oaZ/QbBhcWvJ6UCUyoE1t6jLvxZTq7yN9qHCpY4t8gzi7Ujylax1M0HTeiigc3ja 2HRqUi1iqicY3F3pAaPKLnnssFUg4LZTH9ZSHQ+S5O8HKmO0JRxBPm2h+2hjzApbgTihFbEYuYyv3 ytDPkGzOuxYzQc8qKLCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qo1CO-0001tS-17; Wed, 04 Oct 2023 12:41:56 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qo1CL-0001sz-32 for linux-arm-kernel@lists.infradead.org; Wed, 04 Oct 2023 12:41:55 +0000 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5335725cf84so3430919a12.2 for ; Wed, 04 Oct 2023 05:41:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696423310; x=1697028110; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YDhaQgPXjq3b5cu7EVRm2WZ4T3jBC6bUKmu7zNMCCx8=; b=NuDW1kuPCYnCGNPbXriNykLQ+y9Jg57DRwCK57n3eNCG5ovnYLcvnWghmsrNKtzmW2 Q94ysNzNVO1UFwCKCbfEZgw1/efsZF1KWl4yxGVSmlVCzDc1L3dZlQ2bkxqg3lqZKvy6 kQ9AlAHn1on91GnQRRSB4o1pnUJnK5mLrq42K1VHa8ev5WCOLAmPOIq2Vk+0nXjt/AcY rtWi1/grTNMZmMh8ZqjnFb83bDMDjQH8xnKxAdWp1tb0miYPyH7p1KiIzPtczv5f+ONL tjpfrgRxmyb06WqADoHfQpVUwsOa8Ym2P6WNU41MY4mRgksEdojwm+YbpqPTNSGx2frN LvOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696423310; x=1697028110; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YDhaQgPXjq3b5cu7EVRm2WZ4T3jBC6bUKmu7zNMCCx8=; b=Z0wdpwkU9Kt9MXXotKx1MDn7LDe+6UCR1J8Wc/bXWXQjwYd8ffBhaiXvlSBkxqAAcQ Ysapk2a6ToDSo5Jz/WKm7ImUjwZQszRuaP7OKR99ZMIourYjrDWTTPzJFq7VB0CeIDwI /k7M9Ke9CMXxOmG4nzAbGXztvOaptde9yfujIU0hq4rR/Q/Zb/UBgKmrXzfHWyHmdZF4 IAEvnYDs7EFpHvkLrSO9uXuWXfqPhyjkdamuhYW/BA9fe+46h05dA+qWb+Hwp63C1v67 m+WavEgHi1e8pHdCQz5hT4Qr3xV7x5YjfCpIgL5RAqAgwQhyr42OVKFzXcCK4pZXjAq6 mJkw== X-Gm-Message-State: AOJu0YxI9DPZY7V+Gww+VHUQNuaEjRDu53f197cb88dq4+G8/KWHpRgQ uKBT6fLFJLVMbDclC5zaYRGxmQ== X-Google-Smtp-Source: AGHT+IGUSjewbg+oyz2vcruD1eShmUAeujLqL60+TMBOMCitcBwDvAQiZBU1TYfRnaDbo6ITIu+Kxw== X-Received: by 2002:a05:6402:60c:b0:531:35c4:8ca2 with SMTP id n12-20020a056402060c00b0053135c48ca2mr1578047edv.42.1696423309955; Wed, 04 Oct 2023 05:41:49 -0700 (PDT) Received: from linaro.org ([86.123.99.172]) by smtp.gmail.com with ESMTPSA id c11-20020aa7df0b000000b00533dd4d2947sm2401974edy.74.2023.10.04.05.41.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 05:41:49 -0700 (PDT) Date: Wed, 4 Oct 2023 15:41:48 +0300 From: Abel Vesa To: Fabio Estevam Cc: abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, kernel@pengutronix.de, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabio Estevam Subject: Re: [PATCH RESEND v4] clk: imx: imx6sx: Allow a different LCDIF1 clock parent Message-ID: References: <20231004123458.2251635-1-festevam@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231004123458.2251635-1-festevam@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231004_054154_012493_D89E34BF X-CRM114-Status: GOOD ( 22.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23-10-04 09:34:58, Fabio Estevam wrote: > From: Fabio Estevam > > It is not a good idea to hardcode the LCDIF1 parent inside the > clock driver because some users may want to use a different clock > parent for LCDIF1. One of the reasons could be related to EMI tests. > > Remove the harcoded LCDIF1 parent when the LCDIF1 parent is described > via devicetree. > > Old dtb's that do not describe the LCDIF1 parent via devicetree will > use the same PLL5 clock as parent to keep the original behavior. > > Signed-off-by: Fabio Estevam > Reviewed-by: Abel Vesa I applied already the first v4 you sent. https://lore.kernel.org/all/169642294508.713950.12324349089481800725.b4-ty@linaro.org/ Thanks. > --- > Changes since v3: > - Check for the presence of 'assigned-clock-parents'. (Stephen) > > drivers/clk/imx/clk-imx6sx.c | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx6sx.c b/drivers/clk/imx/clk-imx6sx.c > index 3f1502933e59..69f8f6f9ca49 100644 > --- a/drivers/clk/imx/clk-imx6sx.c > +++ b/drivers/clk/imx/clk-imx6sx.c > @@ -121,6 +121,7 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node) > { > struct device_node *np; > void __iomem *base; > + bool lcdif1_assigned_clk; > > clk_hw_data = kzalloc(struct_size(clk_hw_data, hws, > IMX6SX_CLK_CLK_END), GFP_KERNEL); > @@ -498,9 +499,16 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node) > clk_set_parent(hws[IMX6SX_CLK_EIM_SLOW_SEL]->clk, hws[IMX6SX_CLK_PLL2_PFD2]->clk); > clk_set_rate(hws[IMX6SX_CLK_EIM_SLOW]->clk, 132000000); > > - /* set parent clock for LCDIF1 pixel clock */ > - clk_set_parent(hws[IMX6SX_CLK_LCDIF1_PRE_SEL]->clk, hws[IMX6SX_CLK_PLL5_VIDEO_DIV]->clk); > - clk_set_parent(hws[IMX6SX_CLK_LCDIF1_SEL]->clk, hws[IMX6SX_CLK_LCDIF1_PODF]->clk); > + np = of_find_node_by_path("/soc/bus@2200000/spba-bus@2240000/lcdif@2220000"); > + lcdif1_assigned_clk = of_find_property(np, "assigned-clock-parents", NULL); > + > + /* Set parent clock for LCDIF1 pixel clock if not done via devicetree */ > + if (!lcdif1_assigned_clk) { > + clk_set_parent(hws[IMX6SX_CLK_LCDIF1_PRE_SEL]->clk, > + hws[IMX6SX_CLK_PLL5_VIDEO_DIV]->clk); > + clk_set_parent(hws[IMX6SX_CLK_LCDIF1_SEL]->clk, > + hws[IMX6SX_CLK_LCDIF1_PODF]->clk); > + } > > /* Set the parent clks of PCIe lvds1 and pcie_axi to be pcie ref, axi */ > if (clk_set_parent(hws[IMX6SX_CLK_LVDS1_SEL]->clk, hws[IMX6SX_CLK_PCIE_REF_125M]->clk)) > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel