From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BC98E7B60F for ; Wed, 4 Oct 2023 13:23:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yjZGEv/dmj1zIlKkkPNAUYANBamH8+ROi4fZbDUK0pU=; b=j4rwEbrR0uc0RV Pjv88nNqQiV9hf17KOdnsHo7LJtcLAeudWpZK1zkezhS05vm7l77sdsfuW4VGm48RQD+Rk82YGqyW d3WkC5zLBzZkWHKUv8uzNcqJ6QHJWSruH1r9VS6W9K3qvI7idfWAUWg09IyQvEHvahkwcFIQk8VwT nrkPuiFwoI3tlmtgApJB7HH7EyEm6XuXnPFN0mwzA0qjlpeKlkWOLRSC+W759RF5D9+cah6erVIAz vo9sqmD7U5zv/ESr32RAoor0mXmp4QnRvzoFNxgT35faX1T/Aqj04cHMTuAFr/A8tkFO6l00h9Oae KWXIjMk8hexUJ20ACEaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qo1pl-0007Br-1D; Wed, 04 Oct 2023 13:22:37 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qo1pi-0007Ah-0W for linux-arm-kernel@lists.infradead.org; Wed, 04 Oct 2023 13:22:36 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E2C2DA7; Wed, 4 Oct 2023 06:23:07 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3B7B83F59C; Wed, 4 Oct 2023 06:22:27 -0700 (PDT) Date: Wed, 4 Oct 2023 14:22:24 +0100 From: Sudeep Holla To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Marc Bonnici , Sudeep Holla , Jens Wiklander , Coboy Chen , Lorenzo Pieralisi , Olivier Deprez , Oliver Upton , Will Deacon , Quentin Perret Subject: Re: [PATCH v3 14/17] KVM: arm64: FFA: Remove access of endpoint memory access descriptor array Message-ID: References: <20230929-ffa_v1-1_notif-v3-0-c8e4f15190c8@arm.com> <20230929-ffa_v1-1_notif-v3-14-c8e4f15190c8@arm.com> <86leciog2w.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <86leciog2w.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231004_062234_294176_83341DF1 X-CRM114-Status: GOOD ( 29.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 04, 2023 at 11:08:23AM +0100, Marc Zyngier wrote: > On Fri, 29 Sep 2023 16:03:03 +0100, > Sudeep Holla wrote: > > > > FF-A v1.1 removes the fixed location of endpoint memory access descriptor > > array within the memory transaction descriptor structure. In preparation > > to remove the ep_mem_access member from the ffa_mem_region structure, > > provide the accessor to fetch the offset and use the same in FF-A proxy > > implementation. > > > > The accessor take the boolean argument that indicates if the memory access > > descriptor versions is v1(old format) or not. Currently it is set true as > > FF-A proxy supports only v1.0 > > > > Cc: Marc Zyngier > > Cc: Oliver Upton > > Cc: Will Deacon > > Cc: Quentin Perret > > Signed-off-by: Sudeep Holla > > --- > > arch/arm64/kvm/hyp/nvhe/ffa.c | 8 ++++++-- > > include/linux/arm_ffa.h | 6 ++++++ > > 2 files changed, 12 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/kvm/hyp/nvhe/ffa.c b/arch/arm64/kvm/hyp/nvhe/ffa.c > > index 6e4dba9eadef..5f956f53e6bf 100644 > > --- a/arch/arm64/kvm/hyp/nvhe/ffa.c > > +++ b/arch/arm64/kvm/hyp/nvhe/ffa.c > > @@ -423,6 +423,7 @@ static __always_inline void do_ffa_mem_xfer(const u64 func_id, > > DECLARE_REG(u32, fraglen, ctxt, 2); > > DECLARE_REG(u64, addr_mbz, ctxt, 3); > > DECLARE_REG(u32, npages_mbz, ctxt, 4); > > + struct ffa_mem_region_attributes *ep_mem_access; > > struct ffa_composite_mem_region *reg; > > struct ffa_mem_region *buf; > > u32 offset, nr_ranges; > > @@ -452,7 +453,8 @@ static __always_inline void do_ffa_mem_xfer(const u64 func_id, > > buf = hyp_buffers.tx; > > memcpy(buf, host_buffers.tx, fraglen); > > > > - offset = buf->ep_mem_access[0].composite_off; > > + ep_mem_access = (void *)buf + ffa_mem_desc_offset(buf, 0, true); > > + offset = ep_mem_access->composite_off; > > if (!offset || buf->ep_count != 1 || buf->sender_id != HOST_FFA_ID) { > > ret = FFA_RET_INVALID_PARAMETERS; > > goto out_unlock; > > @@ -504,6 +506,7 @@ static void do_ffa_mem_reclaim(struct arm_smccc_res *res, > > DECLARE_REG(u32, handle_lo, ctxt, 1); > > DECLARE_REG(u32, handle_hi, ctxt, 2); > > DECLARE_REG(u32, flags, ctxt, 3); > > + struct ffa_mem_region_attributes *ep_mem_access; > > struct ffa_composite_mem_region *reg; > > u32 offset, len, fraglen, fragoff; > > struct ffa_mem_region *buf; > > @@ -528,7 +531,8 @@ static void do_ffa_mem_reclaim(struct arm_smccc_res *res, > > len = res->a1; > > fraglen = res->a2; > > > > - offset = buf->ep_mem_access[0].composite_off; > > + ep_mem_access = (void *)buf + ffa_mem_desc_offset(buf, 0, true); > > + offset = ep_mem_access->composite_off; > > /* > > * We can trust the SPMD to get this right, but let's at least > > * check that we end up with something that doesn't look _completely_ > > diff --git a/include/linux/arm_ffa.h b/include/linux/arm_ffa.h > > index 748d0a83a4bc..7be240e37f36 100644 > > --- a/include/linux/arm_ffa.h > > +++ b/include/linux/arm_ffa.h > > @@ -357,6 +357,12 @@ struct ffa_mem_region { > > #define CONSTITUENTS_OFFSET(x) \ > > (offsetof(struct ffa_composite_mem_region, constituents[x])) > > > > +static inline u32 > > +ffa_mem_desc_offset(struct ffa_mem_region *buf, int count, bool mem_desc_v1) > > +{ > > + return COMPOSITE_OFFSET(0); > > +} > > If the goal of this patch is to introduce some versioning, why not > define this last parameter as an actual version number, PSCI style > (with a minor and major, each on a 16bit field)? > Fair enough. I am being optimistic that the memory descriptor format doesn't change with each FF-A version. And the v2 of the memory descriptor format is quite flexible to provide backward compatibility for some time(I agree that is controversial :)) > Even the name is pretty misleading, as both FFA versions are v1 (v1.0 > vs v1.1...). > I was referring to the memory descriptor format version. The intention was to keep it separate from the FF-A version. But if using FF-A version makes things simpler I can go for that. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel