From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F54EE8FDC3 for ; Thu, 5 Oct 2023 09:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A3R8KDaB5ij+YbUAsiIe2VE5TrvGbtAh9zRec73NQD4=; b=qiBRmUSElnidRU Ghsmq1m7nsfvZFH3bQxJLsbr19ReoinJrOpgiOg4+NOmL5SzsADBCVnkNvK3qIQyVgi+y64Q410qe PLIBT3PrKJkS3GyljVY9mseifyLC10wEdbmd/PD1NdMCy0iWQ8EYX4a90yoGq9XLORp7b5bUbRX+S TjdSFsbJ25i9DrPnMCzpDnSzmRoWTqX0ndkqAOQ5BOdcNKhXFCZ56Vk2OkTewlLZHrIQAVoMbsX04 cusmqqIu5tPTG3MzX02R++MJJvwV/evLWros3Tfv3/5Wjce/60Pdf7UgdeLp+pUTrsqexgpsteSAV 0UykXbMVWSHndFIg/Hwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qoKlj-001m3l-2o; Thu, 05 Oct 2023 09:35:43 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qoKlg-001m3M-35 for linux-arm-kernel@lists.infradead.org; Thu, 05 Oct 2023 09:35:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2714B1516; Thu, 5 Oct 2023 02:36:16 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.94.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E24783F5A1; Thu, 5 Oct 2023 02:35:34 -0700 (PDT) Date: Thu, 5 Oct 2023 10:35:32 +0100 From: Mark Rutland To: Kristina Martsenko Cc: ardb@kernel.org, bertrand.marquis@arm.com, boris.ostrovsky@oracle.com, broonie@kernel.org, catalin.marinas@arm.com, daniel.lezcano@linaro.org, james.morse@arm.com, jgross@suse.com, maz@kernel.org, oliver.upton@linux.dev, pcc@google.com, sstabellini@kernel.org, suzuki.poulose@arm.com, tglx@linutronix.de, vladimir.murzin@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 37/37] arm64: Remove cpus_have_const_cap() Message-ID: References: <20230919092850.1940729-1-mark.rutland@arm.com> <20230919092850.1940729-38-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231005_023541_072499_15874380 X-CRM114-Status: GOOD ( 14.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 03, 2023 at 06:20:25PM +0100, Kristina Martsenko wrote: > On 19/09/2023 10:28, Mark Rutland wrote: > > There are no longer any users of cpus_have_const_cap(), and therefore it > > can be removed. > > > > Remove cpus_have_const_cap(). At the same time, remove > > __cpus_have_const_cap(), as this is a trivial wrapper of > > alternative_has_cap_unlikely(), which can be used directly instead. > > Nit: The comment above __system_matches_cap() still mentions > cpus_have_const_cap(): > > /* > * This helper function is used in a narrow window when, > * - The system wide safe registers are set with all the SMP CPUs and, > * - The SYSTEM_FEATURE system_cpucaps may not have been set. > * In all other cases cpus_have_{const_}cap() should be used. > */ Thanks! I missed that when grepping for cpus_have_const_cap(). Given we have a number of ways to check the cpucaps, I've deleted the last line in its entirety. Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel