From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: "jk@codeconstruct.com.au" <jk@codeconstruct.com.au>,
Brendan Higgins <brendan.higgins@linux.dev>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andrew Jeffery <andrew@aj.id.au>,
Philipp Zabel <p.zabel@pengutronix.de>,
Wolfram Sang <wsa@kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Jean Delvare <jdelvare@suse.de>,
William Zhang <william.zhang@broadcom.com>,
Tyrone Ting <kfting@nuvoton.com>,
Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>,
Conor Dooley <conor.dooley@microchip.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"=linux-kernel@vger.kernel.org" <=linux-kernel@vger.kernel.org>,
Andi Shyti <andi.shyti@kernel.org>
Subject: Re: [PATCH v12 2/2] i2c: aspeed: support ast2600 i2c new register mode driver
Date: Thu, 5 Oct 2023 14:56:16 +0300 [thread overview]
Message-ID: <ZR6kYMOB67+WJonG@smile.fi.intel.com> (raw)
In-Reply-To: <SEZPR06MB52699EC5463397F4BFF244DBF2CAA@SEZPR06MB5269.apcprd06.prod.outlook.com>
On Thu, Oct 05, 2023 at 06:21:35AM +0000, Ryan Chen wrote:
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Sent: Tuesday, September 5, 2023 7:55 PM
> > On Tue, Sep 05, 2023 at 06:52:37AM +0000, Ryan Chen wrote:
> > > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > Sent: Friday, July 14, 2023 4:55 PM
> > > > On Fri, Jul 14, 2023 at 03:45:22PM +0800, Ryan Chen wrote:
...
> > > divisor = DIV_ROUND_UP(base_clk[3],
> > i2c_bus->timing_info.bus_freq_hz);
> > > for_each_set_bit(divisor, &divisor, 32) {
> >
> > This is wrong.
> >
> > > if ((divisor + 1) <= 32)
> > > break;
> >
> > > divisor >>= 1;
> >
> > And this.
> >
> > > baseclk_idx++;
> >
> > > }
> >
> > for_each_set_bit() should use two different variables.
>
> Will update by following.
>
> for_each_set_bit(bit, &divisor, 32) {
> divisor >>= 1;
> baseclk_idx++;
> }
It's unclear what you are trying to achieve here as the code is not equivalent
to the above.
> > > } else {
> > > baseclk_idx = i + 1;
> > > divisor = DIV_ROUND_UP(base_clk[i],
> > i2c_bus->timing_info.bus_freq_hz);
> > > }
> > > }
...
> > > divisor = min_t(unsigned long, divisor, 32);
> >
> > Can't you use min()? min_t is a beast with some subtle corner cases.
> >
> Will update to
> divisor = min(divisor, (unsigned long)32);
No, the idea behind min() is that _both_ arguments are of the same type,
the proposed above is wrong.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-05 11:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 7:45 [PATCH v12 0/2] Add ASPEED AST2600 I2Cv2 controller driver Ryan Chen
2023-07-14 7:45 ` Ryan Chen
2023-07-14 7:45 ` [PATCH v12 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Ryan Chen
2023-07-14 7:45 ` Ryan Chen
2023-07-14 7:45 ` [PATCH v12 2/2] i2c: aspeed: support ast2600 i2c new register mode driver Ryan Chen
2023-07-14 7:45 ` Ryan Chen
2023-07-14 8:03 ` Krzysztof Kozlowski
2023-07-14 8:08 ` Ryan Chen
2023-07-14 8:56 ` Andy Shevchenko
2023-07-14 8:57 ` Krzysztof Kozlowski
2023-07-14 8:55 ` Andy Shevchenko
2023-08-31 6:04 ` Ryan Chen
2023-08-31 14:18 ` Andy Shevchenko
2023-09-05 6:52 ` Ryan Chen
2023-09-05 11:55 ` Andy Shevchenko
2023-10-05 6:21 ` Ryan Chen
2023-10-05 11:56 ` Andy Shevchenko [this message]
2023-10-11 7:36 ` Ryan Chen
2023-10-11 8:17 ` Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZR6kYMOB67+WJonG@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc==linux-kernel@vger.kernel.org \
--cc=andi.shyti@kernel.org \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=brendan.higgins@linux.dev \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jdelvare@suse.de \
--cc=jk@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=kfting@nuvoton.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=phil.edworthy@renesas.com \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=tharunkumar.pasumarthi@microchip.com \
--cc=william.zhang@broadcom.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).