From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD7F9CE7A81 for ; Mon, 25 Sep 2023 12:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kPcg7IsU5/Ch35ErQuuHiSSln/Ilsle+/Lhnbu0yNMM=; b=0cNNjXZv7PThny XUNhCC8SD8mKZazeq9K5xxD0f5vLnbeofiIWpHBC87vI+KCn3xZY+0fLQpxD7LUoeL9SYGbmj7aFA dJL4jgQBLmos+4lLP1So8WYLzf0RH47L49xofhhhSQUNIQH9TJh+uFSVDlItXxm+MbIIAjraV/06P 44Izu1HP94DKVbtVjK1gNG2SKEwtx+sK7p8fGTLmhXkziGfVE+UawXZHS8Bpsho4JVigah/rFLIzo +Ch1VHPOC0JULHhfaMgaH0EgWZ2Pg/nq8wBctq2IncjEldWrXTB/0JrqvkTw8ujgWxIeTq846zDhc 5UJx/Za6m4E22Q4y11uA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkkcX-00EFKd-03; Mon, 25 Sep 2023 12:23:25 +0000 Received: from mgamail.intel.com ([134.134.136.100]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkkcU-00EFJq-0a for linux-arm-kernel@lists.infradead.org; Mon, 25 Sep 2023 12:23:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695644602; x=1727180602; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=U3cmCcOFZtDa3Y2ZK/TkeGbMFs8jv8OQbBC9obIBuKM=; b=BiTKe9A+nPV2lFzWjPSuVbebbBztYfMMxMktIrSkhWT/fBTKDBSZ5tbV dCjwGReopMSHgRZ4RkEh7GgP4kZqxurjieMHz8rxwIvwdV/hlcQOQfB8G tK81ClYBj6+4svpTUoz1RgEHcD7nXfoOPac0ttxxo2cH+WOREBptYffZK ErrcH79DipBgAlGA1gVn2pLILJ3JeWUlXf3Tjpsd3lsaNhqavKXfAiP98 9PRiJWsSbg5iCjYxm5NZCUNsP7YlWBOpqivaJeVwwdfHzNsLm7uQjM3XX BMCyBs2lo5K7Mg1JrCwUOQhEEhIjuEkHQavhdRZAUEIxUFjAzeg+Sf2Ml Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="447726114" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="447726114" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 05:23:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="724978754" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="724978754" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 05:23:15 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qkkcJ-00000000LLO-2C8M; Mon, 25 Sep 2023 15:23:11 +0300 Date: Mon, 25 Sep 2023 15:23:11 +0300 From: Andy Shevchenko To: Alexander Potapenko Cc: catalin.marinas@arm.com, will@kernel.org, pcc@google.com, andreyknvl@gmail.com, linux@rasmusvillemoes.dk, yury.norov@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eugenis@google.com, syednwaris@gmail.com, william.gray@linaro.org Subject: Re: [PATCH v5 2/5] lib/test_bitmap: add tests for bitmap_{read,write}() Message-ID: References: <20230922080848.1261487-1-glider@google.com> <20230922080848.1261487-3-glider@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_052322_266925_289E7683 X-CRM114-Status: GOOD ( 13.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 25, 2023 at 02:16:37PM +0200, Alexander Potapenko wrote: ... > > +/* > > + * Test bitmap should be big enough to include the cases when start is not in > > + * the first word, and start+nbits lands in the following word. > > + */ > > +#define TEST_BIT_LEN (1000) > > Dunno why this didn't fire previously, but CONFIG_CPU_BIG_ENDIAN=y > kernel reports mismatches here, presumably because the last quad word > ends up partially initialized. Hmm... But if designed and used correctly it shouldn't be the issue, and 1000, I believe, is carefully chosen to be specifically not dividable by pow-of-2 value. > The easiest fix is to make TEST_BIT_LEN divisible by 64 (e.g. 1024) Wouldn't it hide the real issue somewhere? -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel