From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0F2FCE79A7 for ; Mon, 25 Sep 2023 23:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FU6nT7oBHCrVSwt3ZfWZzNZy3MWKqRsasGDXuHMTXSE=; b=hfhkUmck2RUG9h 4bHXD0A7Z4wpqb8aPoWUnZOHWDnAq/W3aqxmhsDrx3dybiUtcFsBWxyjeU7Anac+taqp5nz+0pXGy K+f4+oxoswBq3Fxu/rIDnUCZOw4v3IgQKrWldBTCCJGYfmfrZ6L10j0C5641Id7sYph9ReAC2d6jf okcDjKDMvDq6afEADo87CykaNXVIRkoqWtUpwKnHGs+D88U0Ru4NisQbiOBmkLUU4RgqfLXPHprua 8aan4ONx6Gr74pG7jYE82Njwg3qmw1ACm8SIEEjAYFptbZSJNW8JeaDejIa0mwVDlri9RJ6NsJ7Ly LXcQZJShWGDwGv7u1iOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkupf-00FCov-1p; Mon, 25 Sep 2023 23:17:39 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkupb-00FCnk-1u for linux-arm-kernel@lists.infradead.org; Mon, 25 Sep 2023 23:17:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lK9wsOQ0X+liH8Gj+buTBXV/sF1bkg6KdP4DvULH538=; b=zxMH/KaHAkwdrC1+MS43+Ar/0c rF9M5PWf4SI63IOtDUMqPRSW6tx0l0M4RgxdATupJXkPwvbD4Vjve6+5Pnpd2m8XxJLTvGA6jBcps CrAAAsUI+8oEAzcWtoOUIl+cadXKxUnz7Nor3Qk2xr1D8zH2rTVem6vEVssyMUQuXeIfDYeBoFS58 n2uyCGUlyi+MjdH1aveQezpB6xzm5Xcb1HMIJU++NkCaZ/iWZtjdq/0Atrt63PgrvLM5Y0+a084ZP P8gAGwISZUzUKkQkmiZTlTZKWibCLuKxDD0MK4wnuWO1yGiZujLHgPNDabuGLmfu5dJ9P/WBEBMxY VbEzIwOw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:40444) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qkupO-0001gn-1S; Tue, 26 Sep 2023 00:17:22 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qkupL-0008F5-Vw; Tue, 26 Sep 2023 00:17:20 +0100 Date: Tue, 26 Sep 2023 00:17:19 +0100 From: "Russell King (Oracle)" To: Gavin Shan Cc: Thomas Gleixner , linux-acpi@vger.kernel.org, James Morse , loongarch@lists.linux.dev, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com, Borislav Petkov , Dave Hansen , x86@kernel.org, Salil Mehta , "H. Peter Anvin" , Peter Zijlstra , linux-ia64@vger.kernel.org Subject: Re: [PATCH] cpu-hotplug: provide prototypes for arch CPU registration Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_161735_636125_7C482A4D X-CRM114-Status: GOOD ( 25.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 26, 2023 at 09:04:46AM +1000, Gavin Shan wrote: > Hi Russell, > > On 9/26/23 02:28, Russell King (Oracle) wrote: > > Provide common prototypes for arch_register_cpu() and > > arch_unregister_cpu(). These are called by acpi_processor.c, with > > weak versions, so the prototype for this is already set. It is > > generally not necessary for function prototypes to be conditional > > on preprocessor macros. > > > > Some architectures (e.g. Loongarch) are missing the prototype for this, > > and rather than add it to Loongarch's asm/cpu.h, lets do the job once > > for everyone. > > > > Since this covers everyone, remove the now unnecessary prototypes in > > asm/cpu.h, and we also need to remove the 'static' from one of ia64's > > arch_register_cpu() definitions. > > > > Signed-off-by: Russell King (Oracle) > > --- > > Changes since RFC v2: > > - drop ia64 changes, as ia64 has already been removed. > > > > arch/x86/include/asm/cpu.h | 2 -- > > arch/x86/kernel/topology.c | 2 +- > > include/linux/cpu.h | 2 ++ > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > In Linux 6.6.rc3, the prototypes are still existing in arch/ia64/include/asm/cpu.h. Correct, but I have been told that IA64 has been removed, so I removed those changes from my patch. > They may have been dropped in other ia64 or x86 git repository, which this patch > bases on. I have no idea which repository they have been dropped from. I only know what tglx told me, and despite asking the question, I never got any answer. So I've done the best I can with this patch. If kernel devs want to state things in vague terms, and then go silent when asked questions to elaborate, then that leads to guessing. Maybe someone else should adapt this patch to apply to whatever tree it is going to end up being applied to - because I have no idea _which_ tree it'll end up being applied to. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel