From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80271E7D0C5 for ; Tue, 26 Sep 2023 05:55:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zBaKR4QZpVInCNJGqzOtWi98wVba6kd2AZI/6/yJ8R4=; b=xX4AAInTlJ81yx tUI3z7lsNutVjeEMaNdUAcgGDBk763Ijdvw7+TyjLqYRNDAUwh4Mz1sOgSH5cXeHJd+cGVVETvSlo bDN3aR4744dPiTTyPBd2zCKFvlQ2mIZKOi8/WhnuvIan+/mbH7Mg1tqs2E4b45A0nry8ztbCJdQdk C11+aYbNV2ziUFpofmJ+FYHlZr9Tt5VSzODIPbYyaflC7z+99MPqstYmwGRtoVhT4tasbTgPqrNQH sGfShv/KIk9QpIZColc193YS7vWS5EIdSrdH56SmeDApBd1LarryO2iQKMpjh5oswTty8bE7bi5ts 0uaXON/akMxeTsMrpWww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ql11u-00Feno-2S; Tue, 26 Sep 2023 05:54:42 +0000 Received: from mail-pg1-f178.google.com ([209.85.215.178]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ql11r-00FenI-1s for linux-arm-kernel@lists.infradead.org; Tue, 26 Sep 2023 05:54:40 +0000 Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-53fbf2c42bfso6011017a12.3 for ; Mon, 25 Sep 2023 22:54:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695707677; x=1696312477; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3dY4iQ05Jpgj0v/7/dnf9FZuuddQ+ufy0Lt0k1nc7Hs=; b=NgR/gVp0t0QJ9oq6CPpH71D59mIj0mlgEkvwyGUDUGNOINcQFZvrJ8bhnkLygagYdS v5GkV8hlOWhQlbbasLyI9ilJcjauquS/Izw9n08lbQZwpfx8TTi47mmBC9QK6cjnAeQG n6Cvnntrrg87rAvxC+/uO3XOHhwPWZeRGPABxIUgBtiLsoKXykiUF/DdrnQAN6TYR1Ae Z4rThjwDaOlLEtuN5sKAECDCTVdFKVd+vnBpJymm2rXKfZ4fCro7CpscZXeO2kx7+EhB N8aSrjK+DdSitPG5VHR8C1uAWiwZXI/qpkzG51PGkI6BZRRh0IW3LSv7q0zGyh3G8qLK R46Q== X-Gm-Message-State: AOJu0Yxd82UnCq5LI2RNWyJ++JWOm7468TMo576NFT6KlMb5oN8fB630 gpDzFv02VYVUNq5xBRY9pf0= X-Google-Smtp-Source: AGHT+IFgn3+5rJgRk2N+N182GTYklfIHuPGT/K/du1PYKJBfSqVicqb6ZgalhcdlSnKCzbYuLscRDA== X-Received: by 2002:a05:6a20:918a:b0:153:5366:dec1 with SMTP id v10-20020a056a20918a00b001535366dec1mr10756399pzd.15.1695707676866; Mon, 25 Sep 2023 22:54:36 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([20.69.120.36]) by smtp.gmail.com with ESMTPSA id n6-20020a170903110600b001c60c0dbb97sm4684819plh.17.2023.09.25.22.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 22:54:36 -0700 (PDT) Date: Tue, 26 Sep 2023 05:54:34 +0000 From: Wei Liu To: Greg KH Cc: Nuno Das Neves , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, patches@lists.linux.dev, mikelley@microsoft.com, kys@microsoft.com, wei.liu@kernel.org, haiyangz@microsoft.com, decui@microsoft.com, apais@linux.microsoft.com, Tianyu.Lan@microsoft.com, ssengar@linux.microsoft.com, mukeshrathor@microsoft.com, stanislav.kinsburskiy@gmail.com, jinankjain@linux.microsoft.com, vkuznets@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, will@kernel.org, catalin.marinas@arm.com Subject: Re: [PATCH v3 15/15] Drivers: hv: Add modules to expose /dev/mshv to VMMs running on Hyper-V Message-ID: References: <1695407915-12216-1-git-send-email-nunodasneves@linux.microsoft.com> <1695407915-12216-16-git-send-email-nunodasneves@linux.microsoft.com> <2023092342-staunch-chafe-1598@gregkh> <2023092630-masculine-clinic-19b6@gregkh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2023092630-masculine-clinic-19b6@gregkh> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_225439_637769_E8AA609B X-CRM114-Status: GOOD ( 19.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 26, 2023 at 06:52:46AM +0200, Greg KH wrote: > On Mon, Sep 25, 2023 at 05:07:24PM -0700, Nuno Das Neves wrote: > > On 9/23/2023 12:58 AM, Greg KH wrote: > > > Also, drivers should never call pr_*() calls, always use the proper > > > dev_*() calls instead. > > > > > > > We only use struct device in one place in this driver, I think that is the > > only place it makes sense to use dev_*() over pr_*() calls. > > Then the driver needs to be fixed to use struct device properly so that > you do have access to it when you want to print messages. That's a > valid reason to pass around your device structure when needed. Greg, ACRN and Nitro drivers do not pass around the device structure. Instead, they rely on a global struct device. We can follow the same. Nuno, I checked our code. We already have a misc device. We can use that for dev_* calls. Something like this: dev_warn(mshv_dev.this_device, "this is a warning message"); This should resolve Greg's concern. Thanks, Wei. > > thanks, > > greg k-h > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel