From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42F44E7D27A for ; Tue, 26 Sep 2023 10:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VHvjxQp1byWdoeZlQMHznynYbV6GEmgNnnpCzhDQXzY=; b=aIA5SQN/yXRd0c CssN+Q+qq+h05WJK8YKL+fmiB4HJ3Bgv29JszhYVPzYRbvS5cabiKsM18JV60ThGYMbV3cbCLUMmO 0j7ac24CbH/VK7WEmNqpwmpAxyfNuAeoyoch/B2aTbofloOdIQCwQXmoBrHLziKAvXPUwSzxLIaKu skjY0krC/mD3yBzP3v7xJsrzKTnFZGW4Y2xluy11spM2A2UpZPLEjjJSP6Qq+O7gZBNxF76b0r0S4 GUC2dbQ2q4EXoNWOXCSS5WCNNdi+N8lBEVMjQdPk6Q0AhqL8+SJZBIokjj3saTGd8N9z8b7l6UQCv fNihs0ibNe69wZOPrn+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ql5TL-00G8ma-2a; Tue, 26 Sep 2023 10:39:19 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ql5TI-00G8hj-0Z for linux-arm-kernel@lists.infradead.org; Tue, 26 Sep 2023 10:39:18 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1c60778a3bfso43904275ad.1 for ; Tue, 26 Sep 2023 03:39:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695724753; x=1696329553; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DqkfgDw2PK66GKZCRSP4E6cVu5Z/Fe5/oZEh2SKe/Uk=; b=XO7SjO+mQJ14FAz2uut1aaxSD4GNqcBNeOtfTinNsvqDe6TQVb+73s1GyyPvydYyu7 0aJmyjFWXz8mXxFwPeLTPBhxL6AvVECaeQ2ygxKVxiqrERuC1SK1J6yTezxXFxlwXLl7 cPXXMAeWxHqz8Cea9u+EFmp5TV+fVPCCitCNY3xrcDyxPiOIr0T7VseR6MbKjTFvP6em CkOeBNWGqHSYWzjUFjYv3Rtx/go7HD/qBkGmhA3VlktIzBrruM8+gjVTG3agS0CNes/h kasEdgCFgjdWuACDP5YcHY7AtE6eGMvKOaUTwJwAAU9i2tvDvDfT3jZXyy4Rnq+WEiqa Fa1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695724753; x=1696329553; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DqkfgDw2PK66GKZCRSP4E6cVu5Z/Fe5/oZEh2SKe/Uk=; b=NH8AMdavkJ5+zohmVtG2qgt+grNKMuqMvepTBOm5v02NZP6MDEVZug/mSnu2BH+PnR 78VAqoVcyG3voQhomnCfSyc+8k2UlbQbDt351geYeVHjYlcXFrMh7P2vGAEOFlC9b/pk tfvY4DbjESywUDMJf9iusRwssPs0kTmUcp7lFqnTSY9WpJvSzLrdT7sthzaolT4Qv2TW R5+s1YBMxmwXcKZ1usx/MqW5X32i2AThGY0O14UEPf6rT5e0fAiVpTYO2BTCapR7x/CQ B1z/mifw2X164CWajBvjtJbnAWpg5ODYkm27L8r3kvDft+kSkcDNd2AFXBqOEjuZCAxu 0I3g== X-Gm-Message-State: AOJu0YyZ51cGBVJPWGgE34PGXtqX/JHKLQVcfyHo4dJfiE3i/XTH5aLe RaLU2YBb9fbzjZABso4RZQDA7wstnhNDLA== X-Google-Smtp-Source: AGHT+IHmt/OtGw/gPKEbf/bxmyKVUqTK2AMmKRi90DpjP8Bvziiio5AuV7mTpjjPuvBArBZUrhkKuQ== X-Received: by 2002:a17:902:82c4:b0:1c5:f4c7:b4d5 with SMTP id u4-20020a17090282c400b001c5f4c7b4d5mr10698300plz.34.1695724753178; Tue, 26 Sep 2023 03:39:13 -0700 (PDT) Received: from sol (14-201-140-18.tpgi.com.au. [14.201.140.18]) by smtp.gmail.com with ESMTPSA id u5-20020a170902b28500b001c62b9a51a4sm1702079plr.239.2023.09.26.03.39.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 03:39:12 -0700 (PDT) Date: Tue, 26 Sep 2023 18:39:05 +0800 From: Kent Gibson To: Andy Shevchenko Cc: Linus Walleij , Bartosz Golaszewski , Yury Norov , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Bartosz Golaszewski , Andy Shevchenko , Rasmus Villemoes , Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH v1 1/5] lib/test_bitmap: Excape space symbols when printing input string Message-ID: References: <20230926052007.3917389-1-andriy.shevchenko@linux.intel.com> <20230926052007.3917389-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230926_033916_219900_B289D90F X-CRM114-Status: GOOD ( 25.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 26, 2023 at 06:35:40PM +0800, Kent Gibson wrote: > On Tue, Sep 26, 2023 at 08:20:03AM +0300, Andy Shevchenko wrote: > > test_bitmap_printlist() prints the input string which contains > > a new line character. Instead of stripping it, escape that kind > > of characters, so developer will see the actual input string > And "Excape" -> "Escape" - didn't notice until my reply was sending. Cheers, Kent. > Grammar nit: > > "that kind of characters" -> "those kinds of characters" or "that kind > of character" or "such characters" or ... > > > that has been used. Without this change the new line splits > > the string to two, and the first one is not guaranteed to be > > followed by the first part immediatelly. > > immediately > > And the second "first" should be "second"?? > > "the second part is not guaranteed to immediately follow the first" is > clearer (and hopefully what you mean), IMHO. > > Cheers, > Kent. > > > > > Signed-off-by: Andy Shevchenko > > --- > > lib/test_bitmap.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c > > index f2ea9f30c7c5..1f2dc7fef17f 100644 > > --- a/lib/test_bitmap.c > > +++ b/lib/test_bitmap.c > > @@ -523,7 +523,7 @@ static void __init test_bitmap_printlist(void) > > goto out; > > } > > > > - pr_err("bitmap_print_to_pagebuf: input is '%s', Time: %llu\n", buf, time); > > + pr_err("bitmap_print_to_pagebuf: input is '%*pEs', Time: %llu\n", ret, buf, time); > > out: > > kfree(buf); > > kfree(bmap); > > -- > > 2.40.0.1.gaa8946217a0b > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel