From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87EEDE7E621 for ; Tue, 26 Sep 2023 11:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ww7Zx1V1ERtNYMrg5MZhm1VB13Ed0Oy24sxBFFqagww=; b=2EZNcCwTCPV5MS 5cMilgYVRraZSUZiZ330kDh7CtE98CG4d96Wam+kjRXXKZlW7rOdvtNKuSvXhbsKeCXuFUguJak8v Q4D2yYYd7NDCt5bhj3SkA3jAyZEucleY90dHPQ0/lv7GwyEPtDKoqUJ9pwflsxv6ntAuh6ZgfKza9 kosz+TQM2B9SlN8T5Pv0474dRwhXE3M9oUHOa7grAAh1aF3Q3RZ5nBaQeP0ue7hXiVSFPgi6YfI21 4MeOw0F8nZkZkJF+t3alSKtTP08+v/SL1qzooUfLmjAvRvno0OQD3A26L0BacVzIwNaGh+cxTAzWw XxA6bv2WKyKUXUx6M7BA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ql64t-00GF1q-2V; Tue, 26 Sep 2023 11:18:07 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ql64p-00GF0b-2q for linux-arm-kernel@lists.infradead.org; Tue, 26 Sep 2023 11:18:06 +0000 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-691c05bc5aaso7266486b3a.2 for ; Tue, 26 Sep 2023 04:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695727080; x=1696331880; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZWBGxa76m7aeagTgko1i4QtCRID1/zltTLr5CfyYfo0=; b=ddArsEPWj88haeUkjBqClZ+2OFsP9LcpjrR/W1eblP7KF47aaEUAR9YwmWQnnLbprM /Q5JGLkznE6lhoX3FqXVpAJa8jFo2GNDcpFbDKn/7wv5RzLxeZ7NrnllnsnbBQv3NhJf fEqjIFd9aTWMedkZEKXIxGNvM5xrMY0OutcGxrpntGcn/6SCgrlp4C+MEq47VKGfgAu+ hZ1mMgO6Zx2To9u/ZKO+hg9x4uO7T+vbQcuPirqPL6nOH5VfvGbXkjA+Mj/RJg/5GY2A ilQ5b3PnXK1gYga4/PTJuRCxzrMwzV7MSNAaFGzVW1ha+qx/WxhYw4YfSXpA8zGCMl1D 71cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695727080; x=1696331880; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZWBGxa76m7aeagTgko1i4QtCRID1/zltTLr5CfyYfo0=; b=RX0+usLptpDRQ64gssrTBZGsqiQwLnD52GYBX1o1xuhE3ZY6yicr9HQFFnHDTzW/Zg VC6Dl0RqaL88SKUne+6EI18+AY9Auys8VWJjzOb+jC78+J1CrKQC/MzbQd/wdPDKtQeu 1tQjbh8hjWPclyu8Cf3Lg5GcVx2tJTtZzhphqrTqM7Z3s1qvH9KFP4kO9iJy4Bq9UW9q YxASWplEPjAENekWHzyxPSM4N6+PDD71fZN7RPfyHfMRmIHVe/j7hDB9JzEO86ILxdgj wSU4FcPQS8KlOrnCDkjRr0jexuMZ087DFDXJ6MroJWm4QDRlY3tqIBiFWDHbZCqmv4/C YzWw== X-Gm-Message-State: AOJu0Yw5eH+5nIXqShirafbWkObWSipukF3ZNJwVSQORzYJ7HAxNUKdZ ySUXtBZkNgwurF3TDDVr4+E= X-Google-Smtp-Source: AGHT+IGlxqmWKwg1Nds/ON39ID63GQjhIr13e4Wxhk4DX4WRVDLkvJrfHCMgPjn59wIuLIw8meGpmQ== X-Received: by 2002:aa7:8893:0:b0:690:2ecd:a597 with SMTP id z19-20020aa78893000000b006902ecda597mr9672823pfe.21.1695727080615; Tue, 26 Sep 2023 04:18:00 -0700 (PDT) Received: from sol (60-242-83-31.tpgi.com.au. [60.242.83.31]) by smtp.gmail.com with ESMTPSA id l22-20020a62be16000000b0068fe9c7b199sm5814518pff.105.2023.09.26.04.17.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 04:18:00 -0700 (PDT) Date: Tue, 26 Sep 2023 19:17:52 +0800 From: Kent Gibson To: Andy Shevchenko Cc: Linus Walleij , Bartosz Golaszewski , Yury Norov , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Bartosz Golaszewski , Rasmus Villemoes , Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH v1 4/5] gpio: xilinx: Replace bitmap_bitremap() calls Message-ID: References: <20230926052007.3917389-1-andriy.shevchenko@linux.intel.com> <20230926052007.3917389-5-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230926_041803_915299_E9F3B796 X-CRM114-Status: GOOD ( 23.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 26, 2023 at 02:11:14PM +0300, Andy Shevchenko wrote: > On Tue, Sep 26, 2023 at 06:41:00PM +0800, Kent Gibson wrote: > > On Tue, Sep 26, 2023 at 08:20:06AM +0300, Andy Shevchenko wrote: > > > We have sparse and dence masks of the line mappings based on > > > > dense > > > > > the view point (Linux numbering or hardware numbering). Since > > > the Linux side uses sequential bits for the mask, we can simply > > > convert a Linux number to the hardware one and vise versa by > > > > vice > > > > > counting set bits in the respective mask. Hence replace > > > bitmap_bitremap() calls by simpler equivalents. > > > > > > With this done the dence mask is not needed and thus dropped. > > > > And dense again. > > Thank you, Kent, I really appreciate your help with my poor English, > nevertheless it would be nice if you can look at the last patch and > maybe even test it, so we have a bit of confidence that it works > as expected. > Well that is the plan, but I haven't been in the GPIO space for a while so I need to pull my test setup out of mothballs first - so don't hold your breath. > (The spelling will be fixed in the next version.) > Those I can spot without needing to compile anything ;-). Cheers, Kent. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel