From: Christoph Hellwig <hch@infradead.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: christophe.jaillet@wanadoo.fr, bhelgaas@google.com,
hch@infradead.org, imx@lists.linux.dev, kw@linux.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, lpieralisi@kernel.org,
minghuan.Lian@nxp.com, mingkai.hu@nxp.com, robh@kernel.org,
roy.zang@nxp.com
Subject: Re: [PATCH v2 1/1] PCI: layerscape-ep: set 64-bit DMA mask
Date: Tue, 26 Sep 2023 00:27:32 -0700 [thread overview]
Message-ID: <ZRKH5CTucrT5BFwC@infradead.org> (raw)
In-Reply-To: <20230922042836.3311689-1-Frank.Li@nxp.com>
> + /* set 64-bit DMA mask and coherent DMA mask */
> + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
The comment is a bit silly :)
> + if (ret)
> + return ret;
Also no need to check the return value when setting a 64-bit mask,
but I guess it desn't hurt here.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-26 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 4:28 [PATCH v2 1/1] PCI: layerscape-ep: set 64-bit DMA mask Frank Li
2023-09-26 7:27 ` Christoph Hellwig [this message]
2023-09-26 14:00 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRKH5CTucrT5BFwC@infradead.org \
--to=hch@infradead.org \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=imx@lists.linux.dev \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lpieralisi@kernel.org \
--cc=minghuan.Lian@nxp.com \
--cc=mingkai.hu@nxp.com \
--cc=robh@kernel.org \
--cc=roy.zang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).