* [PATCH v2 1/1] PCI: layerscape-ep: set 64-bit DMA mask
@ 2023-09-22 4:28 Frank Li
2023-09-26 7:27 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Frank Li @ 2023-09-22 4:28 UTC (permalink / raw)
To: christophe.jaillet
Cc: Frank.li, bhelgaas, hch, imx, kw, linux-arm-kernel, linux-kernel,
linux-pci, linuxppc-dev, lpieralisi, minghuan.Lian, mingkai.hu,
robh, roy.zang
From: Guanhua Gao <guanhua.gao@nxp.com>
Set DMA mask and coherent DMA mask to enable 64-bit addressing.
Signed-off-by: Guanhua Gao <guanhua.gao@nxp.com>
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Notes:
change from v1 to v2
- Remove 32bit DMA mask set.
drivers/pci/controller/dwc/pci-layerscape-ep.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
index de4c1758a6c33..026bf08611e13 100644
--- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
+++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
@@ -249,6 +249,11 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
pcie->big_endian = of_property_read_bool(dev->of_node, "big-endian");
+ /* set 64-bit DMA mask and coherent DMA mask */
+ ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
+ if (ret)
+ return ret;
+
platform_set_drvdata(pdev, pcie);
ret = dw_pcie_ep_init(&pci->ep);
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] PCI: layerscape-ep: set 64-bit DMA mask
2023-09-22 4:28 [PATCH v2 1/1] PCI: layerscape-ep: set 64-bit DMA mask Frank Li
@ 2023-09-26 7:27 ` Christoph Hellwig
2023-09-26 14:00 ` Frank Li
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2023-09-26 7:27 UTC (permalink / raw)
To: Frank Li
Cc: christophe.jaillet, bhelgaas, hch, imx, kw, linux-arm-kernel,
linux-kernel, linux-pci, linuxppc-dev, lpieralisi, minghuan.Lian,
mingkai.hu, robh, roy.zang
> + /* set 64-bit DMA mask and coherent DMA mask */
> + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
The comment is a bit silly :)
> + if (ret)
> + return ret;
Also no need to check the return value when setting a 64-bit mask,
but I guess it desn't hurt here.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] PCI: layerscape-ep: set 64-bit DMA mask
2023-09-26 7:27 ` Christoph Hellwig
@ 2023-09-26 14:00 ` Frank Li
0 siblings, 0 replies; 3+ messages in thread
From: Frank Li @ 2023-09-26 14:00 UTC (permalink / raw)
To: Christoph Hellwig
Cc: christophe.jaillet, bhelgaas, imx, kw, linux-arm-kernel,
linux-kernel, linux-pci, linuxppc-dev, lpieralisi, minghuan.Lian,
mingkai.hu, robh, roy.zang
On Tue, Sep 26, 2023 at 12:27:32AM -0700, Christoph Hellwig wrote:
> > + /* set 64-bit DMA mask and coherent DMA mask */
> > + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
>
> The comment is a bit silly :)
>
> > + if (ret)
> > + return ret;
>
> Also no need to check the return value when setting a 64-bit mask,
> but I guess it desn't hurt here.
>
You are right, let me remove check.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-26 14:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-22 4:28 [PATCH v2 1/1] PCI: layerscape-ep: set 64-bit DMA mask Frank Li
2023-09-26 7:27 ` Christoph Hellwig
2023-09-26 14:00 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).