From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 550F1E7D240 for ; Tue, 26 Sep 2023 07:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4Xp+bPZ5rjxB+vDF21w+taduZSPTs3jhiRekAMleUy4=; b=sj0K0ujei1Ksgo wEe4sJDYraGvh2q48LcUGtOfkiBCwhVhTWcxJv1Hc+r7Z+BERyLzVgyy5RyjbheFT+v30fqdEG6V9 wHYKQVLMBxQQvY6yYA4HdueKZiNKdZumkI4gk+lkCwOGQOuaazFhU8WTvuT/eE6DvNZj7fxcXGtzf KwGgEBGLZxQsGYJ4XpDoKtBHPtH/b7Q8CdqrdsibdpNul46RfSreQxuOezE3kEpGqPjYqNyxbKl0y 5wDDKCS0O+0OyogboBj9z5o0c64g7ZmaXHyshF0I3cWAbQaZpzmG3FuDwerIAgQmW5m5Z20VRrvza b4gmdeKt8ozaKXNMPhXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ql2Tm-00FnL5-0U; Tue, 26 Sep 2023 07:27:34 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1ql2Tk-00FnKk-0i; Tue, 26 Sep 2023 07:27:32 +0000 Date: Tue, 26 Sep 2023 00:27:32 -0700 From: Christoph Hellwig To: Frank Li Cc: christophe.jaillet@wanadoo.fr, bhelgaas@google.com, hch@infradead.org, imx@lists.linux.dev, kw@linux.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, lpieralisi@kernel.org, minghuan.Lian@nxp.com, mingkai.hu@nxp.com, robh@kernel.org, roy.zang@nxp.com Subject: Re: [PATCH v2 1/1] PCI: layerscape-ep: set 64-bit DMA mask Message-ID: References: <20230922042836.3311689-1-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230922042836.3311689-1-Frank.Li@nxp.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > + /* set 64-bit DMA mask and coherent DMA mask */ > + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); The comment is a bit silly :) > + if (ret) > + return ret; Also no need to check the return value when setting a 64-bit mask, but I guess it desn't hurt here. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel