From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0BFFE80A9E for ; Wed, 27 Sep 2023 07:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sExmocmb26dvE8q8dsvmguTfBkvo/n+lOKvnoKfRWtQ=; b=qcmXo67QUCahzO /Eref9GdMWU6BHbSbdvftRgMDMh4arlHWXr2Y/KHJFsGfLJ9R4Ks2pFeQjvJDaL2t1EPdpolZxS4c DFDTXOWKyzdgosC/vWXXfRV7UZ/Jz6zZ9x9rOe0ovwSq7SDRgr4mWHZLBRJAN86buWFdKt+E3UjAQ /+BLh58RLaFDi6JzFvsj+5bO/sggs1d7zxJhj006KU9MfaHFNsZ4sGt0QqHhVmTsX1/4ERmi2vVCj 5OtYUa+GGCsYsdXHjjvSzqqNlbIVJED3plvdCw5JQpyfseZbBVVOhf7D367odBeY1wOsTgReHH5oQ b6PzZCo+2B8h5YZq832w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qlOqI-000AoI-0x; Wed, 27 Sep 2023 07:20:18 +0000 Received: from out-201.mta0.migadu.com ([91.218.175.201]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qlOqF-000Amw-0G for linux-arm-kernel@lists.infradead.org; Wed, 27 Sep 2023 07:20:16 +0000 Date: Wed, 27 Sep 2023 07:20:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1695799209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nGDgK4VkvdFAx70kBHbL2YmWBTskOTw97TfFkrlXPyk=; b=neLjQ4JI688mTQAjht0Ctbp0QlIehUE7T2xwuoGERCmpFiBgb0BIwfA5D+sjKMohlgziAE me806sT1qbnX64i8d4r2FrzfhPC1sb82VLvyuCFk5vZhrfHXv44z2Pk1KhZ+rx3UGY6Tb9 RGL3ByQ7EzVs7hwTsJuT9bxUSMVvVoc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Ryan Roberts Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Suzuki K Poulose , James Morse , Zenghui Yu , Ard Biesheuvel , Anshuman Khandual , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v3 08/13] KVM: arm64: Insert PS field at TCR_EL2 assembly time Message-ID: References: <20230918065740.3670662-1-ryan.roberts@arm.com> <20230918065740.3670662-9-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230918065740.3670662-9-ryan.roberts@arm.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230927_002015_525129_E55D0275 X-CRM114-Status: UNSURE ( 7.09 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org 'Assembly' is overloaded in this context, I had to reread the shortlog to make sense of it. Maybe: KVM: arm64: Prepare TCR_EL2.PS in cpu_prepare_hyp_mode() On Mon, Sep 18, 2023 at 07:57:35AM +0100, Ryan Roberts wrote: [...] > tcr &= ~TCR_T0SZ_MASK; > tcr |= TCR_T0SZ(hyp_va_bits); > + tcr |= kvm_get_parange(mmfr0) << TCR_EL2_PS_SHIFT; nit: FIELD_PREP() is slightly more defensive than shifting an unmasked value. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel