From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EEFFE810CC for ; Wed, 27 Sep 2023 10:58:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dWyiAgL+6ja3K4CCIT4y2xmbpng2rsWTIpzmTy1cR7k=; b=3Zc/24dHKh5AQy +UEY5+ftUB2cax8gshvyenOU0BiFTNaV+865iLzvCJM/uXDfWX7dIn7yjGPxQZin6kyFvF2YFX+OF Vx8dBYvvHuJR/1/pR3H1YCjjQKjcSz/tH6u3VOiL+k8XsnXyWlvSiHum2CENPPxITQ5cGiabbYUqC 6EKdTfYVEyxyaQZN7RQlkRRo3ZYjLCT6xrcnSHFnAZSQN7MprT+BFNe1N/z1o4uihINHqJiqFowvB hd86YXzggiS4UU4ycD/sfyL9/+qbj9mZGOQfhs3Cd97iLxBuTUVj8VSnp2zmBB8QZIwmhdtmp35eb BataNLGV0qsGlNzV/0Wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qlSEt-000lSC-1g; Wed, 27 Sep 2023 10:57:55 +0000 Received: from mgamail.intel.com ([134.134.136.31]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qlSEp-000lQy-1I for linux-arm-kernel@lists.infradead.org; Wed, 27 Sep 2023 10:57:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695812271; x=1727348271; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jb2Av0IYJPI3zJ+2i+bD1UoqIPdVABtXYLj8arBzUFQ=; b=VumbvK/NwTV9+QKXy9o44qJLbyraouzsN7LQDkhbtJU9FecyV2YEJb4x xbOrHpArMW46Cepb5amJD8Ae7PZFXDWLzXmB2Uh+yXOskrsB1B4ASOxry QL/1QjVNdvrl9ajRBUZ0GHQ1IL/HKC/D9xkpTlv4Ug3vwU0yYiyWOWpL9 ebCAFCXFU1blJrWwqhxkYR4cYLOIKYfuVxGYRYRAoeQ+rDHZRbhFbf0LN zkpW78NqhZiWheYnN6ei33jxNp6e7PeGBCWuBR6bDAENEKX22uWkx9Wi7 MuuSzytzTsC5ykZrLZizqUXx5HBN8EYHATeREGTV1eaGZ1kR9kKiePIPX w==; X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="445930012" X-IronPort-AV: E=Sophos;i="6.03,179,1694761200"; d="scan'208";a="445930012" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2023 03:57:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="749161810" X-IronPort-AV: E=Sophos;i="6.03,179,1694761200"; d="scan'208";a="749161810" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2023 03:57:47 -0700 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 00EDC11F94F; Wed, 27 Sep 2023 13:48:28 +0300 (EEST) Date: Wed, 27 Sep 2023 10:48:28 +0000 From: Sakari Ailus To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , Arnd Bergmann , Mauro Carvalho Chehab , linux-media@vger.kernel.org, Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] media: sunxi: a83-mips-csi2: also select GENERIC_PHY Message-ID: References: <20230927040438.5589-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230927040438.5589-1-rdunlap@infradead.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230927_035751_525365_3D93D404 X-CRM114-Status: GOOD ( 20.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Randy, Thanks for the patch. On Tue, Sep 26, 2023 at 09:04:38PM -0700, Randy Dunlap wrote: > When selecting GENERIC_PHY_MIPI_DPHY, also select GENERIC_PHY to > prevent kconfig warnings: > > WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY > Depends on [n]: GENERIC_PHY [=n] > Selected by [y]: > - VIDEO_SUN8I_A83T_MIPI_CSI2 [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && VIDEO_DEV [=y] && (ARCH_SUNXI || COMPILE_TEST [=y]) && PM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=y] > > Fixes: 94d7fd9692b5 ("media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Closes: lore.kernel.org/r/ZQ/WS8HC1A3F0Qn8@rli9-mobl > Cc: Arnd Bergmann > Cc: Sakari Ailus > Cc: Mauro Carvalho Chehab > Cc: linux-media@vger.kernel.org > Cc: Chen-Yu Tsai > Cc: Jernej Skrabec > Cc: Samuel Holland > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-sunxi@lists.linux.dev > --- > drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig > --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig > +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig > @@ -8,6 +8,7 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2 > select VIDEO_V4L2_SUBDEV_API > select V4L2_FWNODE > select REGMAP_MMIO > + select GENERIC_PHY Could GENERIC_PHY_MIPI_DPHY select GENERIC_PHY instead of depending it? There seem to be a few other drivers that appear to have the same issue. > select GENERIC_PHY_MIPI_DPHY > help > Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY. -- Regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel