From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4580E810CB for ; Wed, 27 Sep 2023 11:01:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5A6rk67OALOA7vpTo32TBEDmx0HJ9FHlwdMbCENDtLg=; b=pTbLguEJmgP3He Qrun3meOGqGrIQ6kH5lk1TatT86O0730+lZRtGMJNZ3FASkoNTXAb2s1ekeirqiKExl3/0MFoW9qM LZelpJq3KQwThhg0PbAYDFhkMIZBUQQ7g3wcvqfQmSbMlEgBnEKhAScDx7nukNGHKlvgqG701KBty 60VPmKXW6P1JelV473PV1Wi3lYTkd6124ZaSCOsu78EGPsLrsjljgSnGJvY11lTsljCks6gW7m5hu KKrMonPvodOLceP+QF3OpKFwpokr13EW69/1GtzVrd8jUt0M/gxXQMDKMkaHzi4G8gZkGNp4LmlCm 68ljli0C4oeV+O2nOk/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qlSHV-000liV-1a; Wed, 27 Sep 2023 11:00:37 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qlSHR-000lhb-26 for linux-arm-kernel@lists.infradead.org; Wed, 27 Sep 2023 11:00:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D88BA1FB; Wed, 27 Sep 2023 04:01:03 -0700 (PDT) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 611DF3F5A1; Wed, 27 Sep 2023 04:00:25 -0700 (PDT) Date: Wed, 27 Sep 2023 12:00:23 +0100 From: Cristian Marussi To: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] firmware: arm_scmi: Do not use !! on boolean when setting msg->flags Message-ID: References: <20230921085257.3125744-1-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230921085257.3125744-1-sudeep.holla@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230927_040033_757095_FDA1E831 X-CRM114-Status: UNSURE ( 8.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 21, 2023 at 09:52:57AM +0100, Sudeep Holla wrote: > Both pc->async_powercap_cap_set and ignore_dresp are already boolean. > Use of !! on them is obviously dubious. > > Sparse reports: > drivers/firmware/arm_scmi/powercap.c:363:17: warning: dubious: x & !y > drivers/firmware/arm_scmi/powercap.c:363:17: warning: dubious: x & !y > Hi, LGTM, indeed I was seeing that report too since a while, just I did not realize why. Reviewed-by: Cristian Marussi Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel