public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: arm_scmi: Rename scmi_{msg_,}clock_config_{get,set}_{2,21}
Date: Wed, 27 Sep 2023 12:15:16 +0100	[thread overview]
Message-ID: <ZRQOxGmR8NQVMrwi@pluto> (raw)
In-Reply-To: <20230925101557.3839860-1-sudeep.holla@arm.com>

On Mon, Sep 25, 2023 at 11:15:57AM +0100, Sudeep Holla wrote:
> It is very confusing to use *_v2 for everything applicable until SCMI
> clock protocol version v2.0 including v1.0 for example. So let us rename
> such that *_v2 is used only for SCMI clock protocol v2.1 onwards. Also
> add comment to indicate the same explicitly.
> 

Hi Sudeep,

looking back at this, indeed, I remember being unsure if it was better
to use the v2/v21 naming scheme or the one that this patch propose.

Revisiting this now, I have to say that I agree with you, but why you
have also renamed _v21 to v2 ? The idea was to match the exact protocol
version ( I see that you added a comment anyway...)

IOW, the day some further new non-backward compatible features will be
possibly introduced (say clock v3), we could go like:

 - _config_set_v21: only v2.1 (the one you have renamed to v2)
 - _config_set_v3: only v3
 - _config_set : everything else, i.e. up to v2.0 (as you've renamed
   now)

I have no string opinions anyway, so I am fine also with this version of
the patch...better than the original brain-dead naming scheme that I had
chosen indeed :P

Thanks,
Cristian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-09-27 11:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25 10:15 [PATCH] firmware: arm_scmi: Rename scmi_{msg_,}clock_config_{get,set}_{2,21} Sudeep Holla
2023-09-27 11:15 ` Cristian Marussi [this message]
2023-09-27 11:50   ` Sudeep Holla
2023-09-27 12:43     ` Cristian Marussi
2023-09-27 12:51       ` Sudeep Holla
2023-09-27 13:06 ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZRQOxGmR8NQVMrwi@pluto \
    --to=cristian.marussi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox