From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AE60E810D0 for ; Wed, 27 Sep 2023 11:15:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V9GJj9uHxDvByrW9/LCBJ+K/PhRA9Lu4xTid5hi7bpc=; b=CkqRPZrh3lsvqy Mics7RMP+/yWuZ4/Pr/3emeu0z2HTd9GPXzBg76yHNSoaUWuuTj6/NJkAMBZda9YV8Y1P4Ea+rucA TAufIpXU470pr0OjavCmc2Wh7X7TGosZNdWrAYSgMVXKu1rJIHD4xZnLazcpprN4AHJ6+z32GUQGZ brVLc4ucQA3oy9fUK/pWZ80gdJHU0i1DOvr4hHFSzqo4RxpeJrNYxUDThSBcA7LsgE1LvPBG68C1a lIBtsDcins/47b80j2yZf1ivGN/O4TMMxx8Owl/rODRVFs3u2ppWOq2OkcWK1+IUopj78ar5ihbst 1jkTuAmvV2+l1g+Bt0QA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qlSVy-000n3b-0b; Wed, 27 Sep 2023 11:15:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qlSVv-000n2U-2s for linux-arm-kernel@lists.infradead.org; Wed, 27 Sep 2023 11:15:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F92A1FB; Wed, 27 Sep 2023 04:16:05 -0700 (PDT) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DAAEB3F5A1; Wed, 27 Sep 2023 04:15:26 -0700 (PDT) Date: Wed, 27 Sep 2023 12:15:16 +0100 From: Cristian Marussi To: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] firmware: arm_scmi: Rename scmi_{msg_,}clock_config_{get,set}_{2,21} Message-ID: References: <20230925101557.3839860-1-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230925101557.3839860-1-sudeep.holla@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230927_041531_975260_D09DE004 X-CRM114-Status: GOOD ( 13.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 25, 2023 at 11:15:57AM +0100, Sudeep Holla wrote: > It is very confusing to use *_v2 for everything applicable until SCMI > clock protocol version v2.0 including v1.0 for example. So let us rename > such that *_v2 is used only for SCMI clock protocol v2.1 onwards. Also > add comment to indicate the same explicitly. > Hi Sudeep, looking back at this, indeed, I remember being unsure if it was better to use the v2/v21 naming scheme or the one that this patch propose. Revisiting this now, I have to say that I agree with you, but why you have also renamed _v21 to v2 ? The idea was to match the exact protocol version ( I see that you added a comment anyway...) IOW, the day some further new non-backward compatible features will be possibly introduced (say clock v3), we could go like: - _config_set_v21: only v2.1 (the one you have renamed to v2) - _config_set_v3: only v3 - _config_set : everything else, i.e. up to v2.0 (as you've renamed now) I have no string opinions anyway, so I am fine also with this version of the patch...better than the original brain-dead naming scheme that I had chosen indeed :P Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel