From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5B76CE7B09 for ; Thu, 28 Sep 2023 07:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eMlxuf6rYQU0s3lKa/bcsWKUpXNJOsslXz7L0CuQBi0=; b=ldE7ax99c5mOJB Tpjz3+iOgByBLARo6fqV9CfBT9Q3/ikPMEt0eHgeSUCqdhj9ESKTBPVI75IArn2tykHo6XiP8XYxk fI/8ow64Lp9dHBh3k0YaIbb2tlGCVhRfVl6oczz7CcxougrMhfTgl8V6/mm05WtnlVZJvbO63fHre y8GgpnHseG+62S1YcdbUwE1F5sayLylVmgR2RGE0curMstVIhcoAttKJ9SXOhiYErGIy6J+UpLC81 3ApltjefOCGbl1yHm6GkyiD8HqHyaleRwW1/LHKX1hZO23hZBOd4o8mppSfztMzhhPnbKKka/74a6 VRp0hgST3D/meXSOE8sQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qllkH-002YYB-2v; Thu, 28 Sep 2023 07:47:37 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qllkE-002YXa-0O for linux-arm-kernel@lists.infradead.org; Thu, 28 Sep 2023 07:47:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C6325CE1C45; Thu, 28 Sep 2023 07:47:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 527E8C433C8; Thu, 28 Sep 2023 07:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695887251; bh=jZr3m3nYQp75gFwOQ2csGb3/m9Y1zYNLh0lKYPrPVzg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nx2xwpP6CMPxbmaX+RFEbFZq4QhCw7PbFMU1E3kVrAnwQ96Ra7MKbLb80zsvht3qC eKhmmj+K3V+P00WHMkr0jIBijkm7d6H9psOwcR9o5yTrYwhlQjRsT0PRsAPjilyp1G bcSf6QkrkigDlyM4kmnCqhbTW1AupodA2b7CzpXCiGAqcf+gafsvbUrcIjDxBK1tOt uiuRPXE7TIropYMR4FeS9tNs+AM+BWhV3d7t27UXzrKEGDG1IwYNaV2JnfsUdi0PFB 1OuBCtRbEe6WSBMmbnHosTAnUScjIkHOx+qg7+43U9S2t3+OM0uGNUwagE41nGjMoL c6DoF19cgxuqg== Date: Thu, 28 Sep 2023 13:17:27 +0530 From: Vinod Koul To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: "Pandey, Radhey Shyam" , Rob Herring , Peter Korsgaard , Liu Shixin , "kernel@pengutronix.de" , "dmaengine@vger.kernel.org" , "Simek, Michal" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 57/59] dma: xilinx: xilinx_dma: Convert to platform remove callback returning void Message-ID: References: <20230919133207.1400430-1-u.kleine-koenig@pengutronix.de> <20230919133207.1400430-58-u.kleine-koenig@pengutronix.de> <20230928072711.k63x7snqdfiholxg@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230928072711.k63x7snqdfiholxg@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230928_004734_388327_96AB6BE2 X-CRM114-Status: GOOD ( 17.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28-09-23, 09:27, Uwe Kleine-K=F6nig wrote: > = > Good catch, I should add that to my pre-send checks. I fixed it in my > tree, so an eventual v2 will be good. I'll wait a bit before resending. > = > @Vinod: If you pick up this series, feel free to skip this patch or > fixup with = > = > diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_= dma.c > index 0c363a1ed853..e40696f6f864 100644 > --- a/drivers/dma/xilinx/xilinx_dma.c > +++ b/drivers/dma/xilinx/xilinx_dma.c > @@ -3242,8 +3242,6 @@ static int xilinx_dma_probe(struct platform_device = *pdev) > /** > * xilinx_dma_remove - Driver remove function > * @pdev: Pointer to the platform_device structure > - * > - * Return: Always '0' > */ > static void xilinx_dma_remove(struct platform_device *pdev) > { > = > or apply as is (in which case I will follow up with a separate patch to > fix this). Follow up patch is easier to handle Thanks -- = ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel