From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53968E748E9 for ; Mon, 2 Oct 2023 15:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mf+ygKfGkyMmxM8kVMFTMzkAcfWtPkEhqRaKrBLwpm8=; b=nYVWcDrroILgOo RHzYNWvSzfc6Q+5V1GoFJ4n3MeW1NsB6lBhS0iPPK76AwI2lE3yrzRF+Z9GYUT0oggs6frQNje1RI fvA9bXjaTiR0pZOS9SLFXmGZoVa1i9NwcmwjKm/0WDgl7fal1XtMBRMSiGZV0swVkcgiFixbIvmqN mXkwDqpDMYkw6nuEcMuLAhBqrMFCoI9QA8NLZDFN286OQYPFpP19zrSA78cUFF2Nl+FlIjU/LWwyK jtbux0mM9ZSqEaLG43g+nv1JW562aQQ4EuZaKz/+SGgkR62cPdu5CvuRKVa6PXahiOVo2KBRPQmAX 6T+r2HI9o6Tmsw7PoMOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnLGX-00D1ai-1P; Mon, 02 Oct 2023 15:55:25 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnLGT-00D1a6-3B for linux-arm-kernel@lists.infradead.org; Mon, 02 Oct 2023 15:55:23 +0000 Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-2774874c3daso9999240a91.1 for ; Mon, 02 Oct 2023 08:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696262119; x=1696866919; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/TliF0IcnDDut/Hmb+cIXBD25FLUVIAU119XJHwJn24=; b=eWC1vfbGpNuIf/54zHB43KzGBafwKw3TYIgnjkjUUacQS3kS8tbB8zIfMWTmCl4HlZ Ym1y0xvUZHMuWljY+bhVvJC5YX+F+5vv8Zs5MCw1bDiXIuM53T9DeCdygGfrodDfc0Y/ /e16+HIKb7qNVtiL1fWSvrys68qfDI+B/n+iKP2+Bc2eciwO3cYyi2YlwTTuZ8I6E927 PzztZEFBUkfrtAgHT6cGzxVVhTfzn/jHdYpbD9B7yY0WwB/kAbj58+CNDnipisiItelE WloOBmdznmmJfKLtCmGJiyXmqSm+jTRGQkCWLnA/HLXiOgvb5CEVjTxP2lvuZz+Fqy/h IedA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696262119; x=1696866919; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/TliF0IcnDDut/Hmb+cIXBD25FLUVIAU119XJHwJn24=; b=kxfaWg7dtWB4jrdxY1MAL1jdfG7SY5H7abmsfE5jaHHf6lKO8ieOjAr2L9wSPws8u7 CZPJLy26gIbLJEEvJY3EAFqWBBcX9/uxg3QwXXOEyV65eZtM7E1aixm/9WDZh9FSuT5s NrBRwx2//04vM/MPq3rAeH+kEAOgzHSPPIDet5DseNLTa8xUurZrpWwJ4seqWsg9A+wO WgDuVMq/n9gPweDWjej6sXc8QHCnqDITlKUma2D13GdH14M/G2BJ7vvGVttVH8PSnrQF XDe5g3ITFaBpKKZsMaq71RWXVoD7o1F10kmxDMIieNUpW1ycaQLJKLN8+rtAD8sywmAL HuEA== X-Gm-Message-State: AOJu0YxpwnNK5tWPUr/vEoKSuMm+6zltZEjTdTXx1wf7dFQ6LO26wMVQ 3P+uz/QABhWk58JidMv2QwDRcw== X-Google-Smtp-Source: AGHT+IGokh6jvr3Bmxk6tUGV+zrXHR9d1b+yagVVS76bh5D/AqXdhn98ZRv039FQnPEyA/a7vnzfdg== X-Received: by 2002:a17:90a:e409:b0:268:ca76:64a with SMTP id hv9-20020a17090ae40900b00268ca76064amr5335954pjb.49.1696262119332; Mon, 02 Oct 2023 08:55:19 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:fa62:edba:ab23:c762]) by smtp.gmail.com with ESMTPSA id ch23-20020a17090af41700b002790423f66fsm6465259pjb.26.2023.10.02.08.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 08:55:18 -0700 (PDT) Date: Mon, 2 Oct 2023 09:55:16 -0600 From: Mathieu Poirier To: Tanmay Shah Cc: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, michal.simek@amd.com, radhey.shyam.pandey@amd.com, ben.levinsky@amd.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 2/4] dts: zynqmp: add properties for TCM in remoteproc Message-ID: References: <20230928155900.3987103-1-tanmay.shah@amd.com> <20230928155900.3987103-3-tanmay.shah@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230928155900.3987103-3-tanmay.shah@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231002_085522_065525_4B3932E4 X-CRM114-Status: GOOD ( 16.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 28, 2023 at 08:58:58AM -0700, Tanmay Shah wrote: > Add properties as per new bindings in zynqmp remoteproc node > to represent TCM address and size. This patch configures > RPU in split mode and adds TCM information accordingly. > Why is this changed from lockstep to split mode? What about all the people out there that are expecting a lockstep mode? > Signed-off-by: Tanmay Shah > --- > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 28 ++++++++++++++++++++------ > 1 file changed, 22 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > index b61fc99cd911..01e12894c88e 100644 > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > @@ -247,19 +247,35 @@ fpga_full: fpga-full { > ranges; > }; > > - remoteproc { > + remoteproc@ffe00000 { > compatible = "xlnx,zynqmp-r5fss"; > - xlnx,cluster-mode = <1>; > + xlnx,cluster-mode = <0>; > > - r5f-0 { > + #address-cells = <2>; > + #size-cells = <2>; > + > + ranges = <0x0 0x0 0x0 0xffe00000 0x0 0x10000>, > + <0x0 0x20000 0x0 0xffe20000 0x0 0x10000>, > + <0x1 0x0 0x0 0xffe90000 0x0 0x10000>, > + <0x1 0x20000 0x0 0xffeb0000 0x0 0x10000>; > + > + r5f@0 { > compatible = "xlnx,zynqmp-r5f"; > - power-domains = <&zynqmp_firmware PD_RPU_0>; > + reg = <0x0 0x0 0x0 0x10000>, <0x0 0x20000 0x0 0x10000>; > + reg-names = "atcm", "btcm"; > + power-domains = <&zynqmp_firmware PD_RPU_0>, > + <&zynqmp_firmware PD_R5_0_ATCM>, > + <&zynqmp_firmware PD_R5_0_BTCM>; > memory-region = <&rproc_0_fw_image>; > }; > > - r5f-1 { > + r5f@1 { > compatible = "xlnx,zynqmp-r5f"; > - power-domains = <&zynqmp_firmware PD_RPU_1>; > + reg = <0x1 0x0 0x0 0x10000>, <0x1 0x20000 0x0 0x10000>; > + reg-names = "atcm", "btcm"; > + power-domains = <&zynqmp_firmware PD_RPU_1>, > + <&zynqmp_firmware PD_R5_1_ATCM>, > + <&zynqmp_firmware PD_R5_1_BTCM>; > memory-region = <&rproc_1_fw_image>; > }; > }; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel