From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92A0BE7490C for ; Mon, 2 Oct 2023 18:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F4sHIaumABgteTWzrBoK90eipd8PiW8f98hSF8yGzIc=; b=Tup3y6HVi061eH lU06SdS76s5HeIbx0t+En4KMkr5MZRDxRHsl3OCb9J8BUkrfbxJhrZGD9qbJfQcf9pxzWOoNS3PJt y10mEXbmynKRl0xw8PF8wVdo/Il1YEoFhREf7lhWp6lsE8I/oycF7SkzEVsk2hxU1nSsWvIQc8nVv X/yN5+sJXrLpG5FkdZAGrM/Vnp8c2pFeOUgTq2gkVeGy0+4yLO60XuvSChPoszZPnyIB4JpLbqRlD PvBoNrlofvxdgpQzC4oMLKK/jaYcmlDBJGbjtg5mBdiyxzSMGhhMFtptB2baBNp07y2CbV+3ANkDr DjlSCf9Zr7vebJhddroQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnNp6-00DE70-25; Mon, 02 Oct 2023 18:39:16 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnNp3-00DE5i-2s for linux-arm-kernel@lists.infradead.org; Mon, 02 Oct 2023 18:39:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696271953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WYt6bra2fRdXu2dkXwuYoSR3Jxl4VEKHXbPW5NpZljc=; b=VvWYoGv44K35EgvD1M3NkSBpJMtNS+hEvEnGUBfqerJ3jWTF0Y9KDftv5bFgjioJOo9mRQ Ghn9gLrUtLed5kmcZPmDWKsAkRsj62zWhYieM82jggyMPjTZDZAhGhCkMfFNmbg9EHWKtv xYTPgqKk+QPPjwcXQDNLtTcd8pjcUOI= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-LAEcInxyOCq-DGremTvMZw-1; Mon, 02 Oct 2023 14:39:11 -0400 X-MC-Unique: LAEcInxyOCq-DGremTvMZw-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-5a213b4d0efso1232837b3.2 for ; Mon, 02 Oct 2023 11:39:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696271951; x=1696876751; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WYt6bra2fRdXu2dkXwuYoSR3Jxl4VEKHXbPW5NpZljc=; b=J0HyZECNaC+rl37i8aCUSSzZqKFZbSSIM5JCjeLQmYd6GLUS2FflHq09wll14S7zlx 1qlScfvZQLq3dtTAJZ/ueOPshDVbwyLMfZfzL9+JqAHxDuqY8uyVeq6vKfrgSXNaYa9I lQ7w8m5i8OaY2UABuvwha3RlU+xX2oH7Y7fq/vPOsHfYUuXg1isYFY56mnSbz78o1k+o ZDizlDXnnILGql/SQJuz+Mxzk3mfMc7LUOhPjcz35fHyZn3ffGjCj9sJv6okTucxk8Cy FGqiODA0T9z6RCUwjxVrvs7knmaLD16PTR2/CuL2h9IXgaSWZe05z6BrcPuaKM2UAPZ5 oLQQ== X-Gm-Message-State: AOJu0YxpM0wKunj7yKLVAyhoaI3h3ViwlfjGI1+y4JtIuum5C5NYljXm LmGFKZfpBM0eZQxCx2yke70aOMn/zruJbMgpyAqUw2a6bWRytMEr8z6JpBgguGZVgTLgxkM+BOM fdwTnWheBLb8DT3rpSM1o9r50y4ePPANVuNQ= X-Received: by 2002:a25:8603:0:b0:d32:f2e7:7786 with SMTP id y3-20020a258603000000b00d32f2e77786mr10996421ybk.56.1696271951099; Mon, 02 Oct 2023 11:39:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFOWEC4ny8KWu3fUPvQKn4wRh0cjkvr8hu/5wFhvnGe0yZ1IUYjTdLH/xTEiyfLSuO18WFTAQ== X-Received: by 2002:a25:8603:0:b0:d32:f2e7:7786 with SMTP id y3-20020a258603000000b00d32f2e77786mr10996398ybk.56.1696271950763; Mon, 02 Oct 2023 11:39:10 -0700 (PDT) Received: from brian-x1 (c-73-214-169-22.hsd1.pa.comcast.net. [73.214.169.22]) by smtp.gmail.com with ESMTPSA id n5-20020a5b0485000000b00d911680fd10sm236158ybp.50.2023.10.02.11.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 11:39:10 -0700 (PDT) Date: Mon, 2 Oct 2023 14:39:08 -0400 From: Brian Masney To: Nikunj Kela Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v4 4/4] firmware: arm_scmi: Add qcom hvc/shmem transport support Message-ID: References: <20230718160833.36397-1-quic_nkela@quicinc.com> <20230911194359.27547-1-quic_nkela@quicinc.com> <20230911194359.27547-5-quic_nkela@quicinc.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231002_113913_998728_99D04BE9 X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 02, 2023 at 02:34:06PM -0400, Brian Masney wrote: > On Mon, Sep 11, 2023 at 12:43:59PM -0700, Nikunj Kela wrote: > > + func_id = readl((void __iomem *)(scmi_info->shmem) + size - 16); > > +#ifdef CONFIG_ARM64 > > + cap_id = readq((void __iomem *)(scmi_info->shmem) + size - 8); > > +#else > > + /* capability-id is 32 bit wide on 32bit machines */ > > + cap_id = readl((void __iomem *)(scmi_info->shmem) + size - 8); > > +#endif > > The 32 bit case is defined as a u64 in two places above. Also should the 32 bit case be 'size - 4' instead of 'size - 8'? Sorry I just noticed that as soon as I pressed send. Brian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel