From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64AC7E7AD57 for ; Tue, 3 Oct 2023 14:35:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=McHcW63K71vzOX21WfRYvF8pQAR5ePqK87JAOmCEhbU=; b=NHyfsplVjecGZg qhT0by2tmd+HUD6DXGrwC1J+LYN7eExkkVRMzg2roTkE38rOGK/JdGguodrw2jOXtJeRxYDBy3yf/ VtzfOlM+CGxxnfuMpH4rAVfBYILA5bQi74t8zRx400IKvSV5fE8wR+5qU/h1r2cP0+KD65Katy5Mf ARyw6WgWIVVqcI/UPZUr7dFu9TAZx0eL2bYcR2NinXwQVE6KfYcHHLX5+k8QEQPq/218ksn4GZXZ+ oLURHaJ5kmutTb3/p165E7DfY9/w/gnJYQsLevcQikn/WTjAVTlAjGmD+Oaq79dIHaKcbR0FNFI7L J2e+mPvBveW30SO1sLRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qngUe-00Eo5C-1R; Tue, 03 Oct 2023 14:35:24 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qngUa-00Eo4K-1f for linux-arm-kernel@lists.infradead.org; Tue, 03 Oct 2023 14:35:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XQksk7pyvzZ6898twTFuY7ew23wLu3w3rS0ARfVw3k4=; b=WlrkJSyKlNE8OwZSxon9XsxAdz ASx702dgd0uiF2J3NXC8vaNCH/q+u2wPNN+6oZVHo8cY5V8ZdankY0xk2rou5ypVnd8uNw0lVfgQ0 ZnBHFMzGxJDzYFKo23XDs5VZq4WzkkYSKYCNH8u7rErL0Nj+yCGtAgeKAoAdbyWvRJAgRvKu1i4ts ZO+Y1/kFUR+5AfRk65vlNPA9XjR/LB37rlwNrYyDBS67mgDtOEn5IqMpRecIg0GHZej5mVDilaOpU OPsTIE67HUWOn2EcQWB11jsSWIqr9q/XC1tVdmPrkntyomoSbaGo9mN/l0CdlZ4t8HDoJkWt7OJGI 9PHLc/CQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:39002) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qngUG-0001rW-1u; Tue, 03 Oct 2023 15:35:00 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qngUB-0007y5-GX; Tue, 03 Oct 2023 15:34:55 +0100 Date: Tue, 3 Oct 2023 15:34:55 +0100 From: "Russell King (Oracle)" To: Gavin Shan , Linus Torvalds Cc: Thomas Gleixner , linux-acpi@vger.kernel.org, James Morse , loongarch@lists.linux.dev, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com, Borislav Petkov , Dave Hansen , x86@kernel.org, Salil Mehta , "H. Peter Anvin" , Peter Zijlstra , linux-ia64@vger.kernel.org Subject: Re: [PATCH] cpu-hotplug: provide prototypes for arch CPU registration Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231003_073520_553502_98739B4A X-CRM114-Status: GOOD ( 33.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 26, 2023 at 12:17:19AM +0100, Russell King (Oracle) wrote: > On Tue, Sep 26, 2023 at 09:04:46AM +1000, Gavin Shan wrote: > > Hi Russell, > > > > On 9/26/23 02:28, Russell King (Oracle) wrote: > > > Provide common prototypes for arch_register_cpu() and > > > arch_unregister_cpu(). These are called by acpi_processor.c, with > > > weak versions, so the prototype for this is already set. It is > > > generally not necessary for function prototypes to be conditional > > > on preprocessor macros. > > > > > > Some architectures (e.g. Loongarch) are missing the prototype for this, > > > and rather than add it to Loongarch's asm/cpu.h, lets do the job once > > > for everyone. > > > > > > Since this covers everyone, remove the now unnecessary prototypes in > > > asm/cpu.h, and we also need to remove the 'static' from one of ia64's > > > arch_register_cpu() definitions. > > > > > > Signed-off-by: Russell King (Oracle) > > > --- > > > Changes since RFC v2: > > > - drop ia64 changes, as ia64 has already been removed. > > > > > > arch/x86/include/asm/cpu.h | 2 -- > > > arch/x86/kernel/topology.c | 2 +- > > > include/linux/cpu.h | 2 ++ > > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > > > > In Linux 6.6.rc3, the prototypes are still existing in arch/ia64/include/asm/cpu.h. > > Correct, but I have been told that IA64 has been removed, so I removed > those changes from my patch. > > > They may have been dropped in other ia64 or x86 git repository, which this patch > > bases on. > > I have no idea which repository they have been dropped from. I only know > what tglx told me, and despite asking the question, I never got any > answer. So I've done the best I can with this patch. If kernel devs want > to state things in vague terms, and then go silent when asked questions > to elaborate, then that leads to guessing. > > Maybe someone else should adapt this patch to apply to whatever tree it > is going to end up being applied to - because I have no idea _which_ > tree it'll end up being applied to. So, is this how the Linux community is now dysfunctional? Someone sends a patch. Thomas reviews, says it's a good idea and provides some feedback. Author asks questions, gets ignored. Author sends a patch taking in to account that previous feedback. Someone else replies, contradicting the previous feedback. Nothing else happens. What a bloody sorry state of affairs. Makes me wonder what the point of trying to contribute to the Linux kernel outside of the areas I actually maintain anymore is. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel