From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94A96E8FDC0 for ; Tue, 3 Oct 2023 23:30:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n/4rMP512LOH6o4IHZCSss2N/Ewtq2XL3dXl2spzNRU=; b=Cnat8Kax99Hjxw 7zlQq4e5l246hROwa58jwebBGjfRI4dtqMaus5S6Tt1L240DeiPwELU4S2vDrqWZolGLQBBoXROl6 oqEglyD87+iFNZYpEu5QCk9g9qWMFUIX69/jEaZFAHvANLfNbAyq2AIEWdEMyRK6y/J0k37p4MRzI TU6Hj65rN/FtyOzUlxOsLd2Y+5BQQ8BOqUvOY7mhHYANjvyOFOle9Vjlj1YwWxR08gVAPMV3heRLH hXYrQf5fwPyDENA4ll9Z2fB4Rp8ynqh77FGtJ/ThF3REkfpCNNuAuoLeYc4b2+DAo57Xea49Bsg4K /Cr0sW7YqxUWficMDC7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnopq-00FZCR-13; Tue, 03 Oct 2023 23:29:50 +0000 Received: from mail-pf1-f181.google.com ([209.85.210.181]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnopn-00FZBb-1K for linux-arm-kernel@lists.infradead.org; Tue, 03 Oct 2023 23:29:48 +0000 Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-690b7cb71aeso290476b3a.0 for ; Tue, 03 Oct 2023 16:29:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696375785; x=1696980585; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pBz0lRi2DC+AHJ394H0d/SpV7ukUS6MAw+MuCkAtqS8=; b=c0IM/W+/C+6Rdu7nZ0rb9XBn5nTlmjc7ICjhQp/mF7YfWZVCDeebeiYEzTm464xdLy XvzN0Ypsbr13cHLJePHbA0CMuC7qUBmqvPvrk4BmiGXPKYRHw/JvLBrCXQOc5uofCQ3X 8llpnWJnp+wcPXEXTKo3Dz8csparjbbeeDhusNsX14lR2WB2X2Mnv7GIydy+p/jOifiS IM0+1FXqIN968tuYRma+L+2JfxMAttPDmbuaCl1E6X2uIFAlika35AWQpaqp72IXdAqL OhIH3Koxme1VCdCuMirF8gmJadnozPmTcim2PnSJPBp+/tFu7xTTCExNQZqoleQW13yY 3CAw== X-Gm-Message-State: AOJu0Yxdaw0SJJkCiFQnnZKdnvgDBAHSzQYi/28voPE3l1/hu8bFjO+Y NGnt7kB9K+1h1idRVtvkHIs= X-Google-Smtp-Source: AGHT+IFDj6feRY+mcyfse2njK81rSw5tfqSmn4MKTfs0z1MOlf+i33E6HbJUJHUY6T5POArEoZjZvQ== X-Received: by 2002:a05:6a00:1310:b0:68e:2c2a:5172 with SMTP id j16-20020a056a00131000b0068e2c2a5172mr974254pfu.6.1696375784881; Tue, 03 Oct 2023 16:29:44 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([20.69.120.36]) by smtp.gmail.com with ESMTPSA id ff23-20020a056a002f5700b006875a366acfsm1925061pfb.8.2023.10.03.16.29.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 16:29:44 -0700 (PDT) Date: Tue, 3 Oct 2023 23:29:42 +0000 From: Wei Liu To: Greg KH Cc: Wei Liu , Nuno Das Neves , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, patches@lists.linux.dev, mikelley@microsoft.com, kys@microsoft.com, haiyangz@microsoft.com, decui@microsoft.com, apais@linux.microsoft.com, Tianyu.Lan@microsoft.com, ssengar@linux.microsoft.com, mukeshrathor@microsoft.com, stanislav.kinsburskiy@gmail.com, jinankjain@linux.microsoft.com, vkuznets@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, will@kernel.org, catalin.marinas@arm.com Subject: Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs Message-ID: References: <1696010501-24584-1-git-send-email-nunodasneves@linux.microsoft.com> <1696010501-24584-14-git-send-email-nunodasneves@linux.microsoft.com> <2023093057-eggplant-reshoot-8513@gregkh> <2023100154-ferret-rift-acef@gregkh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2023100154-ferret-rift-acef@gregkh> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231003_162947_455490_D0CC1A72 X-CRM114-Status: GOOD ( 35.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Oct 01, 2023 at 08:19:27AM +0200, Greg KH wrote: > On Sat, Sep 30, 2023 at 10:01:58PM +0000, Wei Liu wrote: > > On Sat, Sep 30, 2023 at 08:09:19AM +0200, Greg KH wrote: > > > On Fri, Sep 29, 2023 at 11:01:39AM -0700, Nuno Das Neves wrote: > > > > These must be in uapi because they will be used in the mshv ioctl API. > > > > > > > > Version numbers for each file: > > > > hvhdk.h 25212 > > > > hvhdk_mini.h 25294 > > > > hvgdk.h 25125 > > > > hvgdk_mini.h 25294 > > > > > > what are version numbers? > > > > These are internal version numbers for the hypervisor headers. We keep > > track of them so that we can detect if there are any breakages in the > > ABI, and thus either ask them to be fixed or we come up with ways to > > maintain compatibility. People outside of Microsoft don't need to worry > > about this. If you don't think this information belongs in the commit > > message, we can drop it. > > Internal numbers to a single company that have no relevance to anyone > else do not belong in a changelog comment. Would you want to see this > in any other kernel changelog message for any other portion of the > kernel? > Okay. They shall be removed. I agree with you. > > > > diff --git a/include/uapi/hyperv/hvgdk.h b/include/uapi/hyperv/hvgdk.h > > > > new file mode 100644 > > > > index 000000000000..9bcbb7d902b2 > > > > --- /dev/null > > > > +++ b/include/uapi/hyperv/hvgdk.h > > > > @@ -0,0 +1,41 @@ > > > > +/* SPDX-License-Identifier: MIT */ > > > > > > That's usually not a good license for a new uapi .h file, why did you > > > choose this one? > > > > > > > This is chosen so that other Microsoft developers who don't normally > > work on Linux can review this code. > > Sorry, but that's not how kernel development is done. Please fix your > internal review processes and use the correct uapi header file license. > > If your lawyers insist on this license, that's fine, but please have > them provide a signed-off-by on the patch that adds it and have it > documented why it is this license in the changelog AND in a comment in > the file so we can understand what is going on with it. > We went through an internal review with our legal counsel regarding the MIT license. We have an approval from them. Let me ask if using something like "GPL-2.0 WITH Linux-syscall-note OR MIT" is possible. Thanks, Wei. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel