From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6786CDB47E for ; Wed, 18 Oct 2023 08:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AA0P9hqx5iDCFHoTS1MJTf68X3U79KbYdPCv10uSVFA=; b=FMifLk3jhGop3T k2C2E/9387d8YOEW5FfzV6mfZgWeXZbrQQm1VrIed+C2moC/0l/PauUW4FgmEDjqjo6SYbt7gcx03 HZN4NkrgET2k8kmdoXCkRL0he3jxca35SIIgQwVaRqqhy10wMz2SnUK4nKLVPp74sQHjQg0G8R8rM nD2UATtNA99ibJHPY0xmid8bn5UZPeyf4+hDuesxfFkpXOkNHIyU8Ausfe0FAjKCdQ9Pq5wCoJ0w8 dq9Fj1G/LGsPBqQ1l0MBckT8/N4AQINWLfbjcvVINp87hY5gc24i76UWJPf+CYAchWltztVjWo/KO O4hKU3DXe3bljBnOUzmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qt28G-00EBBx-1v; Wed, 18 Oct 2023 08:42:24 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qt28D-00EBBL-1G for linux-arm-kernel@lists.infradead.org; Wed, 18 Oct 2023 08:42:23 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 596E960FAF; Wed, 18 Oct 2023 08:42:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3488C433C7; Wed, 18 Oct 2023 08:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697618540; bh=OrfcLUwCJcdGJ8Ez94xY0DGx3glfePdaB3+hm47573c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lOnHKduTHXeWOJNfkUsAPfv0A6Zvl01LjA27dhPOdPo6Swu8aMEHugieJAu3zqsYG /U0Fmc+KWiYv2sXAqRYoybeG4fYYnwJ2CG1hz0e3EZ4fstYmLCjKvbeRp3PZBbr7zF eRyw9JEdBgRbKCOOlgh4ILLAnKhDz94HDAfg1RUKRTDtfDCK+o4SdyvVKQ+HV6kcZl 6WuMOgo55ldYB2VNan+DN/x8/rwmWPOtUQDFj5tVJxmCR/PD6dhF71ZXdk1xoCcMJp aT8cqFFE5kDfEn+ZNUBYJGKjgdVHS8m+AqD/n0Qd4axXGOcP2zuFhlxrIVnfHYKUm1 uIc33Ay9WaWJg== Date: Wed, 18 Oct 2023 10:42:14 +0200 From: Lorenzo Pieralisi To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, Robin Murphy , Mark Rutland , "Rafael J. Wysocki" , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, Rob Herring , Fang Xiang Subject: Re: [PATCH v3 5/5] irqchip/gic-v3: Enable non-coherent redistributors/ITSes ACPI probing Message-ID: References: <20230905104721.52199-1-lpieralisi@kernel.org> <20231006125929.48591-1-lpieralisi@kernel.org> <20231006125929.48591-6-lpieralisi@kernel.org> <86v8b5mc5v.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <86v8b5mc5v.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231018_014221_535261_031BA0DF X-CRM114-Status: GOOD ( 43.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 17, 2023 at 05:44:28PM +0100, Marc Zyngier wrote: > On Tue, 17 Oct 2023 15:19:46 +0100, > Lorenzo Pieralisi wrote: > > > > On Fri, Oct 06, 2023 at 02:59:29PM +0200, Lorenzo Pieralisi wrote: > > > The GIC architecture specification defines a set of registers > > > for redistributors and ITSes that control the sharebility and > > > cacheability attributes of redistributors/ITSes initiator ports > > > on the interconnect (GICR_[V]PROPBASER, GICR_[V]PENDBASER, > > > GITS_BASER). > > > > > > Architecturally the GIC provides a means to drive shareability > > > and cacheability attributes signals and related IWB/OWB/ISH barriers > > > but it is not mandatory for designs to wire up the corresponding > > > interconnect signals that control the cacheability/shareability > > > of transactions. > > > > > > Redistributors and ITSes interconnect ports can be connected to > > > non-coherent interconnects that are not able to manage the > > > shareability/cacheability attributes; this implicitly makes > > > the redistributors and ITSes non-coherent observers. > > > > > > So far, the GIC driver on probe executes a write to "probe" for > > > the redistributors and ITSes registers shareability bitfields > > > by writing a value (ie InnerShareable - the shareability domain the > > > CPUs are in) and check it back to detect whether the value sticks or > > > not; this hinges on a GIC programming model behaviour that predates the > > > current specifications, that just define shareability bits as writeable > > > but do not guarantee that writing certain shareability values > > > enable the expected behaviour for the redistributors/ITSes > > > memory interconnect ports. > > > > > > To enable non-coherent GIC designs on ACPI based systems, parse the MADT > > > GICC/GICR/ITS subtables non-coherent flags to determine whether the > > > respective components are non-coherent observers and force the shareability > > > attributes to be programmed into the redistributors and ITSes registers. > > > > > > An ACPI global function (acpi_get_madt_revision()) is added to retrieve > > > the MADT revision, in that it is essential to check the MADT revision > > > before checking for flags that were added with MADT revision 7 so that > > > if the kernel is booted with ACPI tables (MADT rev < 7) it skips parsing > > > the newly added flags (that should be zeroed reserved values for MADT > > > versions < 7 but they could turn out to be buggy and should be ignored). > > > > > > Signed-off-by: Lorenzo Pieralisi > > > Cc: Robin Murphy > > > Cc: Mark Rutland > > > Cc: "Rafael J. Wysocki" > > > Cc: Marc Zyngier > > > --- > > > drivers/acpi/processor_core.c | 21 +++++++++++++++++++++ > > > drivers/irqchip/irq-gic-common.h | 8 ++++++++ > > > drivers/irqchip/irq-gic-v3-its.c | 4 ++++ > > > drivers/irqchip/irq-gic-v3.c | 9 +++++++++ > > > include/linux/acpi.h | 3 +++ > > > 5 files changed, 45 insertions(+) > > > > Hi Marc, > > > > just a quick note to ask if, from an ACPI binding POW > > I guess you mean POV. POW has an entirely different meaning... :-/ > > > this patch and related approach make sense to you. > > > > If so, we can start the process to get the ACPI changes drafted > > in: > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=4557 > > > > and deployed in this patch into the ACPI specs, I can log > > an "ACK" in the tianocoreBZ entry above (we will be able to > > rework the code as much as we want, this is just for the > > bindings). > > I'm OK with the overall shape of it. However, I wonder what the > rationale is for spreading the redistributor property all over the map > (in both GICC and GICR structures), while it could be set once and for > all in the core MADT flags (32 bits, of which only one is in use). > > It is bad enough that there are two ways of getting the GICR regions. > Why can't the properties that apply to all of the be common? I don't think we are allowed to add arch specific flags to the MADT since those, supposedly, are cross-architecture (and the only one defined is quite old, though x86 specific). The reason behind spreading the property is the nature of GICC/GICR subtables themselves - we wanted to apply flags only in subtables relevant to the components in question. We could try to add a global flag to the MADT but I would not be surprised if the ECR would be rejected then for the reason I explained above. Thanks, Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel