From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C44EFCDB47E for ; Wed, 18 Oct 2023 11:03:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bScLjNclsmoi78pUTnrBvgGpOPRAoBOVLvZCteWZdOA=; b=cX+fWLv7FsEXV7 JntxCMafXL00xR2jXRwEt8cJoEKngn/TU9DyiNg44psiPRfMb+/5Q1FuYEFOTtPdbxCJXXhMoPYq4 qHsereb/JVLoXVUBfh3PnrRO8chzzQTZ95T2t7E4AvclK8+isvF+PXhmjOrPXfUoUX+YokXdLoNQO Ikbgp7mpaNm7EeiCEhNRImxytineMIELbI8Cksn6rcjkqT/P7u3bjZudugDWGBxwWscbSd+dHx/fL dwOWgkWKzPY0+yvIJyI9KwfCfvDRaC/jtnQkD9IiuWJDFELB7rq/l+1iQVA0yoKzLiDoiVSvFgqDf D8J+85VUyLirqwTDOyqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qt4Ks-00EVLi-35; Wed, 18 Oct 2023 11:03:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qt4Kp-00EVKl-2I for linux-arm-kernel@lists.infradead.org; Wed, 18 Oct 2023 11:03:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5AC492F4; Wed, 18 Oct 2023 04:04:11 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.67.200]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 14CB23F762; Wed, 18 Oct 2023 04:03:27 -0700 (PDT) Date: Wed, 18 Oct 2023 12:03:25 +0100 From: Mark Rutland To: Douglas Anderson Cc: Marc Zyngier , Catalin Marinas , Will Deacon , Chen-Yu Tsai , D Scott Phillips , Josh Poimboeuf , Peter Zijlstra , Stephen Boyd , Thomas Gleixner , Valentin Schneider , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] Revert "arm64: smp: avoid NMI IPIs with broken MediaTek FW" Message-ID: References: <20231006151547.1.Ide945748593cffd8ff0feb9ae22b795935b944d6@changeid> <20231006151547.2.I2c5fa192e767eb3ee233bc28eb60e2f8656c29a6@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231006151547.2.I2c5fa192e767eb3ee233bc28eb60e2f8656c29a6@changeid> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231018_040331_793723_BBBE7BA6 X-CRM114-Status: GOOD ( 19.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 06, 2023 at 03:15:52PM -0700, Douglas Anderson wrote: > This reverts commit a07a594152173a3dd3bdd12fc7d73dbba54cdbca. > > This is no longer needed after the patch ("arm64: Disable GiC > priorities on Mediatek devices w/ firmware issues"). That first patch has a typo in the title: s/GiC/GIC/ This patch makes sense to me, so: Acked-by: Mark Rutland Mark. > > Signed-off-by: Douglas Anderson > --- > > arch/arm64/kernel/smp.c | 5 +---- > drivers/irqchip/irq-gic-v3.c | 2 +- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > index 16ead57a583d..f36a97a54d2b 100644 > --- a/arch/arm64/kernel/smp.c > +++ b/arch/arm64/kernel/smp.c > @@ -964,10 +964,7 @@ static void smp_cross_call(const struct cpumask *target, unsigned int ipinr) > > static bool ipi_should_be_nmi(enum ipi_msg_type ipi) > { > - DECLARE_STATIC_KEY_FALSE(supports_pseudo_nmis); > - > - if (!system_uses_irq_prio_masking() || > - !static_branch_likely(&supports_pseudo_nmis)) > + if (!system_uses_irq_prio_masking()) > return false; > > switch (ipi) { > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > index 737da1b9aabf..787ccc880b22 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -106,7 +106,7 @@ static DEFINE_STATIC_KEY_TRUE(supports_deactivate_key); > * - Figure 4-7 Secure read of the priority field for a Non-secure Group 1 > * interrupt. > */ > -DEFINE_STATIC_KEY_FALSE(supports_pseudo_nmis); > +static DEFINE_STATIC_KEY_FALSE(supports_pseudo_nmis); > > DEFINE_STATIC_KEY_FALSE(gic_nonsecure_priorities); > EXPORT_SYMBOL(gic_nonsecure_priorities); > -- > 2.42.0.609.gbb76f46606-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel