From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2DDDCDB47E for ; Wed, 18 Oct 2023 09:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uQ20odiIxOlSqeGbmqH08RQWwoEH0CiIY5TB0geLiM0=; b=2N+oxtRzKFzpIN fe1vRBKoFPh9IW0gEpztHe3jDt0jYfOOdk/EqOPHre742emHpAjYG5b/oqbHK4JPqUh7dBM3EuusB 6DD/lHhyKzQKCnoIWVDbcn4wwcIU8R62jQq+KnU9gDbHe5cgwNFzZsKvVRDptN+ip3JdHRuj86pwt 8dfI2gzPyoC5iQE8pSe0cgnW6OXEHsYY5x1mOj8kYjz7hxzuJA0pN6F2mQwrDlqdnrBok5SSt5N3N pxJMLgbJxrkMBhDzuE0fNtSiET0BDiPcDrHjDeFabv+w+oVJ2Fjc9twanhtfvP7XWmzDMUSu27sl2 chvudHx3ow6RGRkycgjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qt2yv-00EHqe-1T; Wed, 18 Oct 2023 09:36:49 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qt2yn-00EHp0-2d for linux-arm-kernel@lists.infradead.org; Wed, 18 Oct 2023 09:36:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id D3678B82252; Wed, 18 Oct 2023 09:36:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82AC6C433C7; Wed, 18 Oct 2023 09:36:37 +0000 (UTC) Date: Wed, 18 Oct 2023 10:36:35 +0100 From: Catalin Marinas To: Ryan Roberts Cc: kernel test robot , Will Deacon , Steven Price , Peter Collingbourne , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64/mm: Hoist synchronization out of set_ptes() loop Message-ID: References: <20231005140730.2191134-1-ryan.roberts@arm.com> <202310140531.BQQwt3NQ-lkp@intel.com> <1634d3e0-ac13-4f08-97e3-9b04a9202431@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1634d3e0-ac13-4f08-97e3-9b04a9202431@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231018_023642_159827_F8FCEE4B X-CRM114-Status: GOOD ( 24.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 18, 2023 at 09:21:02AM +0100, Ryan Roberts wrote: > On 17/10/2023 13:57, Catalin Marinas wrote: > > On Tue, Oct 17, 2023 at 08:36:43AM +0100, Ryan Roberts wrote: > >> On 16/10/2023 18:54, Catalin Marinas wrote: > >>> On Sat, Oct 14, 2023 at 05:15:51AM +0800, kernel test robot wrote: > >>>> kernel test robot noticed the following build warnings: > >>>> > >>>> [auto build test WARNING on arm64/for-next/core] > >>>> [also build test WARNING on arm-perf/for-next/perf arm/for-next kvmarm/next soc/for-next linus/master v6.6-rc5 next-20231013] > >>>> [cannot apply to arm/fixes] > >>>> [If your patch is applied to the wrong git tree, kindly drop us a note. > >>>> And when submitting patch, we suggest to use '--base' as documented in > >>>> https://git-scm.com/docs/git-format-patch#_base_tree_information] > >>>> > >>>> url: https://github.com/intel-lab-lkp/linux/commits/Ryan-Roberts/arm64-mm-Hoist-synchronization-out-of-set_ptes-loop/20231005-231636 > >>>> base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core > >>>> patch link: https://lore.kernel.org/r/20231005140730.2191134-1-ryan.roberts%40arm.com > >>>> patch subject: [PATCH v2] arm64/mm: Hoist synchronization out of set_ptes() loop > >>>> config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20231014/202310140531.BQQwt3NQ-lkp@intel.com/config) > >>>> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) > >>>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231014/202310140531.BQQwt3NQ-lkp@intel.com/reproduce) > >>>> > >>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of > >>>> the same patch/commit), kindly add following tags > >>>> | Reported-by: kernel test robot > >>>> | Closes: https://lore.kernel.org/oe-kbuild-all/202310140531.BQQwt3NQ-lkp@intel.com/ > >>>> > >>>> All warnings (new ones prefixed by >>): > >>>> > >>>> In file included from net/ipv4/route.c:66: > >>>> In file included from include/linux/mm.h:29: > >>>> In file included from include/linux/pgtable.h:6: > >>>>>> arch/arm64/include/asm/pgtable.h:344:65: warning: parameter 'addr' set but not used [-Wunused-but-set-parameter] > >>>> 344 | static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > >>>> | ^ > >>>> 1 warning generated. > >>> > >>> Thanks for the report. I think something like below will do (I'll test > >>> and commit as a separate patch, it's not something that Ryan's patch > >>> introduces): > >> > >> I was actually just trying to repro this and was planning to send out a v3 of my > >> patch. But if you are happy to handle it as you suggest, then I guess you don't > >> need anything further from me? > > > > If you feel like testing, please give this a go ;) > > Compile tested and observed that warning is gone with your change. Also ran mm > selftests and all looks good. So: > > Tested-by: Ryan Roberts Thanks. I'll push this patch on top of yours. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel