From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 369C5CDB474 for ; Tue, 17 Oct 2023 08:03:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pvpCQcgT+TEUUtrlok55wVksDUWT9Xk9spJBbyFs8AA=; b=SHJUZW3BcJoKr4 9bkUGhzLTL7qvabZpz3n9gVokDnAUF3iTpeEdyaN+sMtuXANrQ3Lcp6qzcEuf6bZ6jNYDJtgMWr/q JijGrp4CYIsp3PM0gXjOujLj6AzdJN6WEtulVCZTbQukpqDPKTRS6a7IW8KZ3e5XTcOubMeafNVxO 2UGMnbVHrEZShTz8xNszXqQ/1hMzn7RSNVdWEdednZ0i4et1Lmle/X2nrJ/jnyOydctflb4+w+PAM IUnU3+dAP20opXaNqddW3+C8YPrObPp19Uwtn473prK6rcjVXS6erGRzSLjN4whBt0qcb+9zT04t8 yEc3gyMb5jQMh0U6/LFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qsf2z-00Bcfj-38; Tue, 17 Oct 2023 08:03:26 +0000 Received: from out-190.mta0.migadu.com ([91.218.175.190]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qsf2w-00Bcep-1Z for linux-arm-kernel@lists.infradead.org; Tue, 17 Oct 2023 08:03:24 +0000 Date: Tue, 17 Oct 2023 08:03:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1697529798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X41/o5bczvtn2r8r9l6vgC27CyrOUvCR36syb0XC5bs=; b=UM5zdtV751wdwKI/Wqjsx9D6o9Ry46UF+LP/DwUf+aJ3hMmNjco/o3FyR68ou4P+IDOxqL PJB3/NrbCLGk/n6EWyRDvB7ts1fy4wHu38hWOk7TaX5IdJKUjiEKpajU5M6w7s9wHh3sBa LCA9ccbRxTh6daV0+xAJocAcyFtH8MY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Cornelia Huck Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Mark Brown , Jing Zhang , Zenghui Yu , Suzuki K Poulose , James Morse , Marc Zyngier , Paolo Bonzini , Adrian Hunter , Ian Rogers , Namhyung Kim , Jiri Olsa , Alexander Shishkin , Mark Rutland , Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH v3 5/5] KVM: arm64: selftests: Test for setting ID register from usersapce Message-ID: References: <20231011195740.3349631-1-oliver.upton@linux.dev> <20231011195740.3349631-6-oliver.upton@linux.dev> <87fs2aegap.fsf@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87fs2aegap.fsf@redhat.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231017_010322_671001_AC7390D4 X-CRM114-Status: GOOD ( 24.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 16, 2023 at 05:30:06PM +0200, Cornelia Huck wrote: > On Wed, Oct 11 2023, Oliver Upton wrote: > > > From: Jing Zhang > > > > Add tests to verify setting ID registers from userspace is handled > > correctly by KVM. Also add a test case to use ioctl > > KVM_ARM_GET_REG_WRITABLE_MASKS to get writable masks. > > > > Signed-off-by: Jing Zhang > > Signed-off-by: Oliver Upton > > --- > > tools/testing/selftests/kvm/Makefile | 1 + > > .../selftests/kvm/aarch64/set_id_regs.c | 479 ++++++++++++++++++ > > 2 files changed, 480 insertions(+) > > create mode 100644 tools/testing/selftests/kvm/aarch64/set_id_regs.c > > (...) > > > +static void test_user_set_reg(struct kvm_vcpu *vcpu, bool aarch64_only) > > +{ > > + uint64_t masks[KVM_ARM_FEATURE_ID_RANGE_SIZE]; > > + struct reg_mask_range range = { > > + .addr = (__u64)masks, > > + }; > > + int ret; > > + > > + /* KVM should return error when reserved field is not zero */ > > + range.reserved[0] = 1; > > + ret = __vm_ioctl(vcpu->vm, KVM_ARM_GET_REG_WRITABLE_MASKS, &range); > > + TEST_ASSERT(ret, "KVM doesn't check invalid parameters."); > > I think the code should first check for > KVM_CAP_ARM_SUPPORTED_REG_MASK_RANGES -- newer kselftests are supposed > to be able to run on older kernels, and we should just skip all of this > if the API isn't there. Ah, thanks! I'll apply the following on top: diff --git a/tools/testing/selftests/kvm/aarch64/set_id_regs.c b/tools/testing/selftests/kvm/aarch64/set_id_regs.c index 5c0718fd1705..bac05210b539 100644 --- a/tools/testing/selftests/kvm/aarch64/set_id_regs.c +++ b/tools/testing/selftests/kvm/aarch64/set_id_regs.c @@ -452,6 +452,8 @@ int main(void) uint64_t val, el0; int ftr_cnt; + TEST_REQUIRE(kvm_has_cap(KVM_CAP_ARM_SUPPORTED_REG_MASK_RANGES)); + vm = vm_create_with_one_vcpu(&vcpu, guest_code); /* Check for AARCH64 only system */ -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel