From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C80DACDB474 for ; Tue, 17 Oct 2023 10:36:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NxXyJeZDKlA8+hYGDfKeeXuYNXrUIiDZ2lr/5ITDNr4=; b=d2kRidDJQDHz3p AlSHDttxc2rHPksm/p1RrEjNkhOUHrT4CpWdqnV0KhE0aRA0OfwAc4SI+6uk81Fbw6yHtJ1fWDUAq uWJ8L8cSxN618g43wfesgF4MwgzmTLykwxfa17EBxWW2irWCAE2bSwIoiQNT7Qq0nkdxgaQ1J6xIY +xQWpdgKY8bJ0DMT903admuCoLYE0eTAlYoJzcytzdHAe4ESVn/fQcMnUKtFkzHCHdgITN/xsUAvq uqUH2V1iXdJT7HQGemQki6lu5jDFqAySaAZO/YktNcleGHV/OX70a2fKMwRX6gIX92N9XWt1rXoIF QAkoAbOm2Fgzgw/poAQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qshQZ-00C6F3-1I; Tue, 17 Oct 2023 10:35:55 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qshQV-00C6EG-27 for linux-arm-kernel@lists.infradead.org; Tue, 17 Oct 2023 10:35:53 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 869872F4; Tue, 17 Oct 2023 03:36:28 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.68.232]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A2D843F762; Tue, 17 Oct 2023 03:35:46 -0700 (PDT) Date: Tue, 17 Oct 2023 11:35:44 +0100 From: Mark Rutland To: Gavin Shan Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, suzuki.poulose@arm.com, anshuman.khandual@arm.com, shan.gavin@gmail.com Subject: Re: [PATCH] arm64: Remove system_uses_lse_atomics() Message-ID: References: <20231017005036.334067-1-gshan@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231017005036.334067-1-gshan@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231017_033551_744769_882F1DD6 X-CRM114-Status: GOOD ( 17.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 17, 2023 at 10:50:36AM +1000, Gavin Shan wrote: > There are two variants of system_uses_lse_atomics(), depending on > CONFIG_ARM64_LSE_ATOMICS. The function isn't called anywhere when > CONFIG_ARM64_LSE_ATOMICS is disabled. It can be directly replaced > by alternative_has_cap_likely(ARM64_HAS_LSE_ATOMICS) when the kernel > option is enabled. > > No need to keep system_uses_lse_atomics() and just remove it. > > Signed-off-by: Gavin Shan I had meant to remove this already, so: Acked-by: Mark Rutland Mark. > --- > arch/arm64/include/asm/lse.h | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/arch/arm64/include/asm/lse.h b/arch/arm64/include/asm/lse.h > index cbbcdc35c4cd..3129a5819d0e 100644 > --- a/arch/arm64/include/asm/lse.h > +++ b/arch/arm64/include/asm/lse.h > @@ -16,14 +16,9 @@ > #include > #include > > -static __always_inline bool system_uses_lse_atomics(void) > -{ > - return alternative_has_cap_likely(ARM64_HAS_LSE_ATOMICS); > -} > - > #define __lse_ll_sc_body(op, ...) \ > ({ \ > - system_uses_lse_atomics() ? \ > + alternative_has_cap_likely(ARM64_HAS_LSE_ATOMICS) ? \ > __lse_##op(__VA_ARGS__) : \ > __ll_sc_##op(__VA_ARGS__); \ > }) > @@ -34,8 +29,6 @@ static __always_inline bool system_uses_lse_atomics(void) > > #else /* CONFIG_ARM64_LSE_ATOMICS */ > > -static inline bool system_uses_lse_atomics(void) { return false; } > - > #define __lse_ll_sc_body(op, ...) __ll_sc_##op(__VA_ARGS__) > > #define ARM64_LSE_ATOMIC_INSN(llsc, lse) llsc > -- > 2.41.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel