From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2DF6E95A8E for ; Mon, 9 Oct 2023 14:33:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d4J1zXjiIS/PBpDUS8QfYAvsQD03N4WI8uYZG4Rbxug=; b=FS5Vr4W5LWT3+K 8VPAvtjMtcGFkdKaLMOL9JU3AD4eFBjhNpVVKcShZcwcTf/NJ/QU5wLFSEAwiY2puqx4hrLseT8YL HKQRbshxeJRfZOwGBfg2Ve/ByBye3QfTpRdt4z+GykK3jpH90vQAsPbP4KG/SOsbFSEXXyrim3PIb 8s3/bQ2l6QtI2+I3BtDL3NNM4YZ7sosEaisLMpQELA162Wg7x5apDgszS0isVF07vsfdzGbzILwgn TPhDvUdt/nkcJ/4kWht2hNwUsFcn7s831gjjBRADLTPVP5WG8aRP3y5mFi8GP+1jkxH+OjVMxe2fB qZ9ICJk/PPnS2Y9FtG/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qprJh-00AwW0-0u; Mon, 09 Oct 2023 14:33:05 +0000 Received: from esa4.hgst.iphmx.com ([216.71.154.42]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qprJc-00AwT3-36 for linux-arm-kernel@lists.infradead.org; Mon, 09 Oct 2023 14:33:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1696861980; x=1728397980; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=rkVt3ztR2twS1HBsfcA3gWwcWNs+5ICdIqBhASlpNHI=; b=pCaInYJGfE+Kc5olGbQc1zv6PIYx1HyzDp3UBeknuw/gitE49/ugIAE5 va5cvVk06E8VxwVhKCcbeIAmUlWZJ/2OQSbuZ7VIrkwsOqyeFgIjNHWxK jVHW0Hma0ntjsDb9FFESzX2WvJrTCCQubCmMN03rGzgJg7OMp0PDeqDOB 9ydMgQ0GVrg6pv9r3Ia1s041yablaHMLDpZzsqkQMhKxfDTEXtISyAfxw pNgrtNDz++qnsclfRE138WvLD9AxGv6fUrLQhjor1Q8U/5brz6iBPPL4b Dzhjv0f10wajFuq+xSEEHkyHywqUDvk6iIaj+GNWG1WF6+IMgMQfY2VaV A==; X-CSE-ConnectionGUID: 57xtZDrGSey0+TBy834U1g== X-CSE-MsgGUID: 3ZT/6rJ6Rs+gKDuvovEnHA== X-IronPort-AV: E=Sophos;i="6.03,210,1694707200"; d="scan'208";a="244209660" Received: from mail-dm6nam10lp2101.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.101]) by ob1.hgst.iphmx.com with ESMTP; 09 Oct 2023 22:32:55 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K3QGn4JJRS0i0hxkLCyYmVyNtbFpnvqyjk7b0ge9a0vutXvENpzpr24fiL73iXfvxeBlr8BJcFoGhJh4ccBXbNO4fAcUc3jKVqhNAzLDZ3lHajILlAC5ud3i1An3r193TojVXHAbF3AZuSy546uRVgMddmXyOtcUUO1fI7qxsBm8K7YCd4aHtYlpFbKN8AbIxkrFFqR4GGRq4h9iyftICxXut74ifk/eQYRXQ7aZ1BhSQYbS7Ky0ZBYYjJdEwxjVoPy90WN4FpteajNxygseeM+CjBj/hCHYRvCNDhf1nRlxNQ1h1a0GOUsEWExDh23qIffMND/VzzlRyGziAcdHyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oo5sydePOBgyE+jspN5YhQB7+N+GhA2SqT02slDBiUY=; b=QI0FqsF+/v0D85Py2V8NM4GE6H3Ut16MQys9QQLy2akrXC5ETbQKI6u6ixufgWZ97Rj0W1E19+HQ5HbEggIB4kswD6r6jJ/BFYWmD12OUUO6NZqNW118+/e8he3v1EOJep0a6fbw7bsAezzI2mfTXrOcNMgJ74YzpNgzXHba3cpWqy+VsSN3E/T+xE40TOqmj/pDHBviaft+e3s5AwrLrk4YE5747kXTWixBc+wyAXLmTyrN5UqumCXfQMHGvqldsZoXIS0+KVvI8pQwsNkz79n7AqX+m62j5SwZDmOQsfQ+imlDUn8dmH+w6iNSQ0tSHnVr2paCqb1ZS+tFBBKkGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oo5sydePOBgyE+jspN5YhQB7+N+GhA2SqT02slDBiUY=; b=RwMxEoxRde4Y5skuGUbRa9icFh5quZ77T8Uo8z42Xmn8gLMM/si0a8DtzGDSlM8fXcesUCxHDlsCFcpej5p2Kuv3iPYpNYnDL5dnJ4uQcl3dnZPWnKcNN1/vvvg136VaUhPOHiqoLbO4rUOgsAvSpxWowDO3CUSCpIIRhwnXgI8= Received: from MN2PR04MB6272.namprd04.prod.outlook.com (2603:10b6:208:e0::27) by BN0PR04MB8078.namprd04.prod.outlook.com (2603:10b6:408:15d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Mon, 9 Oct 2023 14:32:53 +0000 Received: from MN2PR04MB6272.namprd04.prod.outlook.com ([fe80::6fb5:ecb:1ea0:3b1d]) by MN2PR04MB6272.namprd04.prod.outlook.com ([fe80::6fb5:ecb:1ea0:3b1d%6]) with mapi id 15.20.6863.032; Mon, 9 Oct 2023 14:32:53 +0000 From: Niklas Cassel To: Rob Herring CC: Damien Le Moal , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , "linux-ide@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ata: imx: Use device_get_match_data() Thread-Topic: [PATCH] ata: imx: Use device_get_match_data() Thread-Index: AQHZ+r18FCvS8aA15UaFAdH3fkfrTA== Date: Mon, 9 Oct 2023 14:32:52 +0000 Message-ID: References: <20231006214442.339890-1-robh@kernel.org> In-Reply-To: <20231006214442.339890-1-robh@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wdc.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR04MB6272:EE_|BN0PR04MB8078:EE_ x-ms-office365-filtering-correlation-id: 78ed62bd-4110-42fb-a9ab-08dbc8d49f0f wdcipoutbound: EOP-TRUE x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PGmTepDq/4FWAakk6gx3TFYZELAIg+752r4vAEfzGAR+7rcIUZZU4J0TqMczOW5Vc2ECVN2meO25m1htBj3iaJnLuyjpQzkOxLVmxqph6RbK9CukOnEtsQivrh4z/NpbYYVztkjeECoASRv4vhpHokSz4JEMYrEpGcRAlsZ4qblNULdZIuHQAePaDD72ONCO1IrzZMBAUgEbHKsELCee1UliU4rfcgihlVbtqF61PAlLb6/F/nTynsVgmFi6wpEd3YqwU+yigPs7bs5f9ejmxuARvva1bMaMamSRp6BYIzhOUmAFeX8dYcJXaTQUh5YioRkN+2/w7sxAF08K+hL8B6bz0CHb4kmxXHk7U8HFsYgWuOyRvcMYDwVBAeRVfybGbFIdaOti8YRrlA9dC4I9lJ6nSapps0rg7h3KL/yGc7Tn6NlGHRPUdNcB8K/w3CS4yNBfST1suscMzMT+qdtI1W7lD3NJv3nKSMZWPa+vwk4Vn7FkwY4E7nJlh7ieBNkkINjPF9mZRHoWZEs0tF5kEE5hI4y9+WU1ORqym2bcYkQ3AvPDUKVGFh6VUypNZiZNHSsceUUTnKymr/zIi4gP49rM6B15rO6c6lpx+SShxfstbDmtjXjij/wBBJSnW9SD x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR04MB6272.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7916004)(136003)(376002)(396003)(346002)(39860400002)(366004)(230922051799003)(64100799003)(186009)(451199024)(1800799009)(83380400001)(6512007)(38070700005)(9686003)(71200400001)(122000001)(82960400001)(26005)(6506007)(38100700002)(6486002)(33716001)(41300700001)(91956017)(76116006)(66476007)(478600001)(66556008)(316002)(64756008)(66446008)(66946007)(6916009)(54906003)(5660300002)(8936002)(86362001)(4326008)(8676002)(7416002)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ht95MvpXF/M7mLJzdVuU1Fn82k+tkILMQ8nloQfrxg849NzkcKi2SjFWLbKH?= =?us-ascii?Q?PBQb9zSNyalVKURJ+hlvRkt5bxhCa6YkeeI0Fj8HGttz81r/y64hJZT/owYg?= =?us-ascii?Q?bbf27yHjZ/ZA6s8dkB4BpYe1NpVtxSz2vgPnCGGw5/D/hAxUuyQtVEMf1Oso?= =?us-ascii?Q?yQGuh2a7ZerBBoS/JcpXiktCbvRy+3wvaEHg+fwQo6Gi/wzO/8JsnSYkK9Aq?= =?us-ascii?Q?8UjS922FLX6MBcEUVTmwoo8aeZ3cFTRMwIi7FEMJB08YEyxeaAGDJr4nbYqL?= =?us-ascii?Q?4Ei2PXOaxL0vEtfJXAW6bune1PZ6qPQci6J93HodEHgf3n6lrCjTQdWF6Ax9?= =?us-ascii?Q?NC97ZZ27cg+ebsqVIqbJ6i3w7rRHUf0Yh/359eSCp4xOQ6aBql3Z0ZASz6v/?= =?us-ascii?Q?ZAqvaitB5dBY7f0OckqT30SttASrlLsW9zDmSVR2JXScvSqngMC0yXAoytyY?= =?us-ascii?Q?tD+I4QNMI04xTdd/9577hxRBsCPUcoIt0ZzYlSx4ow9OHCDt7BKMzQ2bAlCT?= =?us-ascii?Q?35W6tp0LiXfzEwfJCcEJeOg/j9EJvn3slnvpv+KsH2jQZEzC/JkVhC6wsVOp?= =?us-ascii?Q?1l93Tyw0uVViiXYRbzeXmd/S4wiHFZjp4RqEyJIOV/HZhC6RqOCR5Kp/8XWe?= =?us-ascii?Q?ptrug3tPzi7phLnPvLQZeNp+FzjzsL1gm1XoZD8IndmitmomT4D4P0+SXcQy?= =?us-ascii?Q?8YlFbLNZ+0gXC6lJit+iEkpzJ8P6bPTitj/E3i5M7+gAnMe08p2z71HcojTC?= =?us-ascii?Q?F5y609wY2oMAofYNcI3ZEsh4N2jXweTy3QeUqdv2HWljvEO7PAH19xJf1M7J?= =?us-ascii?Q?8qy8Wpt1F9Bfjys/tR9iphcNfjW6vwvC/Lu3S5ZIiX0ufmQimYC3qGAQ36Fj?= =?us-ascii?Q?h8j4BBg10Trylu8ZTQqMZivxLbUz2osog+EgSeYWlQ0dSdP0Stil86xpO9S1?= =?us-ascii?Q?09MuCc4naCmg/Ju3fsdFOahHsJoENbWSkfJ8171OoHD+Gka1kFBf66nKJ2EV?= =?us-ascii?Q?l4e4nU8kJFrwYBcJeWPDXL1nN6S/oK+pYchUJT990luYZVpUXlff/QkjYDWg?= =?us-ascii?Q?UVxHGeIWn/lO+SUxjH0soH/JWNV3A7J61xcQR+zhTBHLwPdwJw9ELAlDFM97?= =?us-ascii?Q?wU5tET1anlaBw1JSyqLLUU8otxJrQHhWfMor23DLVpp1lXBmQrjbk7X5Spup?= =?us-ascii?Q?ZHuH8+EVWhnRxx5u6EF8k+lWnaA6GOXbcZptpqAirmY2UIFiUJ/UgfDh2Rkw?= =?us-ascii?Q?B8xq7cuXZRQe8AI2JIfYLGIBPwj307TWeVc2hNEec8gLvbgMeinW4LQnSAh/?= =?us-ascii?Q?IdrMyFXT8fmBUcaO6gxVvpOQHgmMTZVOPHrUAtJ7D/0NA2EY+5PlEEfsuO4B?= =?us-ascii?Q?Q0ptKDLlN2xHMAR+LbgNYAGbZQXbO7c/chXbu0GoSZvDmcSEXSj2eLC5HoFO?= =?us-ascii?Q?qU8pqmfxMP9nSdPtZOtLEzHlT6gRGWi7rEAxsadPPVfu9NirnUNICdc0eYBg?= =?us-ascii?Q?i02pP3XFgNifqQpCL2B311RvNXJtquMcpZmcNHVXbEwbgbJKpLOvx1VyMnCg?= =?us-ascii?Q?+8rqnjuPS73zwexurl5Y0gs1CB//wGaCkZtN2CJZucanEZ6LbdX8OUnv+29B?= =?us-ascii?Q?PA=3D=3D?= Content-ID: <177E43F2B167D045B3B99EAE33C56E21@namprd04.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?neSeCggN25s33cD6dy0D2w/SiLIXqZVSpYUq1y2nYuq4mgSWbyD0MZUeYvCt?= =?us-ascii?Q?OpXsZhKEzqECrg1qpFM+pMSSWjMkfZM5uXXuQ/94WqsKnR1JazDTmF5/SIIt?= =?us-ascii?Q?Lvvg5uWnd1ilBy7V46h/HZj88nyjZx837kXAK/m5bwVTlLkD71GGPG6OYExs?= =?us-ascii?Q?+5NfYOdljuK9fvttzdaXZNDjUTzaVESwlXKRg/nxmpz6Jb7OGL++8uuPDbwp?= =?us-ascii?Q?uRjuIC9sn5hceLxEtfoyfDnP68MWSdRJb7Nv09o4srbTWhcfoPBrvzayXcQV?= =?us-ascii?Q?C25lZvvIzRFHcLw6NLi81NAQSJ25BNuXrn9vZTBLZMAiKQfW29Ol/1V/NewX?= =?us-ascii?Q?iX/+TB6VoyvTSYxVdoTc2rbPL1EV2fPuA4S547QgQ9K5NpzJHm292Z3tJAG1?= =?us-ascii?Q?WHM9rnK1WkE2rKJLewiQPcJGFATGe9BCX+B6K1lGKPmj/Rp6miCk5qu1XARS?= =?us-ascii?Q?n39gZI4L+0gj/v+peWCdxaVlu+pKD/clJyNimZAsM6wzvZgAIABEBvKQrtF8?= =?us-ascii?Q?HTrrHhqvzIzRFPUQYhQmb+NpvnYfvyzJzCZsBBWseee2IOm7qoY/pLRYCnSV?= =?us-ascii?Q?1t8srGZBpVFoQ7DznFAJlL3nPE1vyT8EqEqC6cX/hkvPh4DzqwHXpfMjZrpp?= =?us-ascii?Q?56QU3qeed3LQDapXkltnuVT97YOCWRSb5niwfiPIDmWjQQRLmGY71wt/RhCj?= =?us-ascii?Q?APo8AxOCUwzQZbKKlhJnUJlqGlkjmL/8uJqL4YseP8sWCHgS3J0SCtjz+olb?= =?us-ascii?Q?8wrHwLmq8kBSXHDus6q165Z47zDjybQ2QJhT4H/fd+jynhfkQHpCGOsoQ5uY?= =?us-ascii?Q?2OfSg9yZePnyuofP8f5g2aUn015uTe8SxPDxDXjsLfkLN8rp23j/iooDujZH?= =?us-ascii?Q?OZNGe8ZoC1kTAvmU0g+gQOMDzYOpsxfen+E2bNUp6PvwVCBluj7rwoIEQM31?= =?us-ascii?Q?VK8hjyf3IycD/GOrCw29lQ=3D=3D?= X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6272.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78ed62bd-4110-42fb-a9ab-08dbc8d49f0f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2023 14:32:53.0204 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uXmAyZ12YkJ9JBOoQ3Q8Il2sNvvBZnfYeWzbrCYI3Hr5FDnyMfXGkPqS2ZJMKJv2cFIELO4ahjTR6CRk6LYxkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR04MB8078 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231009_073301_065296_B3427AF0 X-CRM114-Status: GOOD ( 20.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 06, 2023 at 04:44:42PM -0500, Rob Herring wrote: > Use preferred device_get_match_data() instead of of_match_device() to > get the driver match data. With this, adjust the includes to explicitly > include the correct headers. > > Signed-off-by: Rob Herring > --- > drivers/ata/ahci_imx.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c > index 9fa005965f3b..cb768f66f0a7 100644 > --- a/drivers/ata/ahci_imx.c > +++ b/drivers/ata/ahci_imx.c > @@ -9,10 +9,11 @@ > #include > #include > #include > +#include > #include > #include > #include > -#include > +#include > #include > #include > #include > @@ -1050,16 +1051,11 @@ static int imx8_sata_probe(struct device *dev, struct imx_ahci_priv *imxpriv) > static int imx_ahci_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > - const struct of_device_id *of_id; > struct ahci_host_priv *hpriv; > struct imx_ahci_priv *imxpriv; > unsigned int reg_val; > int ret; > > - of_id = of_match_device(imx_ahci_of_match, dev); > - if (!of_id) > - return -EINVAL; > - > imxpriv = devm_kzalloc(dev, sizeof(*imxpriv), GFP_KERNEL); > if (!imxpriv) > return -ENOMEM; > @@ -1067,7 +1063,7 @@ static int imx_ahci_probe(struct platform_device *pdev) > imxpriv->ahci_pdev = pdev; > imxpriv->no_device = false; > imxpriv->first_time = true; > - imxpriv->type = (unsigned long)of_id->data; > + imxpriv->type = (enum ahci_imx_type)device_get_match_data(dev); > > imxpriv->sata_clk = devm_clk_get(dev, "sata"); > if (IS_ERR(imxpriv->sata_clk)) { > -- > 2.40.1 > Reviewed-by: Niklas Cassel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel